incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Filip Maj <...@adobe.com>
Subject Re: cordova-js Code Review request
Date Sat, 26 May 2012 04:14:04 GMT
Hey Becky (and rest of team), I'm not back in action until Wednesday so..
I'll check it out then :)

On 5/25/12 10:03 PM, "Becky Gibson" <gibson.becky@gmail.com> wrote:

>OK, I realize an hour and a half isn't much time for a code review. But, I
>gotta power down as my office is moving.  Checked in the code.  Will check
>in later to make sure there are no issues.
>
>
>
>On Fri, May 25, 2012 at 2:30 PM, Becky Gibson
><gibson.becky@gmail.com>wrote:
>
>> The pull request for codova-js didn't come through - although the one
>>for
>> cordova-ios did post to the list?
>>
>> At any rate, since I am changing common code, would appreciate a quick
>> code review of my changes for camera.   Will commit as soon as some
>>gives
>> this a once over.  Note that I added the CameraPopoverOptions object
>>ONLY
>> for iOS.  I think that is appropriate.  Although I added the
>> arrowDirections to the already existing public CameraConstants.
>>
>> Associated iOS pull request is out there as well if your interested.
>>
>> thanks,
>> -becky
>>


Mime
View raw message