incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Drew Walters <deedu...@gmail.com>
Subject Re: [Android] Accelerometer plugin rewrite
Date Wed, 16 May 2012 19:07:44 GMT
Will do.

On Wed, May 16, 2012 at 2:04 PM, Filip Maj <fil@adobe.com> wrote:
> Haha sweet.. whatever, scrap mine. IF yours works then that¹s better than
> mine! ;P
>
> On 5/16/12 11:55 AM, "Drew Walters" <deedubbu@gmail.com> wrote:
>
>>Yeah, I was a bit confused when I saw that, since I have a completely
>>working implementation in my sandbox that I am just doing the final
>>testing on.
>>
>>On Wed, May 16, 2012 at 1:31 PM, Filip Maj <fil@adobe.com> wrote:
>>> Drew, just a heads up that I've got the implementation ported, but am
>>> seeing issues with watchAcceleration on-device, and also calling
>>>multiple
>>> getCurrentAcceleration's in a row.
>>>
>>> I've added a branch to the apache repo, details are in the issue thread.
>>>
>>> On 5/15/12 12:13 PM, "Drew Walters" <deedubbu@gmail.com> wrote:
>>>
>>>>Cool, I'll get started on it.
>>>>
>>>>On Tue, May 15, 2012 at 12:04 PM, Filip Maj <fil@adobe.com> wrote:
>>>>> Hey Drew,
>>>>>
>>>>> The issue tracking this change for BB is here:
>>>>> https://issues.apache.org/jira/browse/CB-465
>>>>>
>>>>> If you want to take that over that would be appreciated as I have the
>>>>> other platforms slated to implement as well :)
>>>>>
>>>>> You can likely base most of the plugin rewrite on the Android plugin
>>>>> rewrite I did and pushed to a branch on the repo:
>>>>>
>>>>>http://git-wip-us.apache.org/repos/asf?p=incubator-cordova-android.git;
>>>>>a=
>>>>>bl
>>>>>
>>>>>ob;f=framework/src/org/apache/cordova/AccelListener.java;h=bc8bf170e4ee
>>>>>e1
>>>>>48
>>>>> 6a61ee7263a423a98bebfc5e;hb=463
>>>>>
>>>>> The JS for the new accelerometer API is here:
>>>>>
>>>>>http://git-wip-us.apache.org/repos/asf?p=incubator-cordova-js.git;a=blo
>>>>>b;
>>>>>f=
>>>>>
>>>>>lib/common/plugin/accelerometer.js;h=f0841e0967c8f9841d9f058640fc5977a6
>>>>>53
>>>>>e2
>>>>> 18;hb=462
>>>>>
>>>>> On 5/15/12 8:46 AM, "Drew Walters" <deedubbu@gmail.com> wrote:
>>>>>
>>>>>>Do you need help with the BlackBerry smartphone implementation or
is
>>>>>>that under control?
>>>>>>
>>>>>>On Tue, May 15, 2012 at 10:16 AM, Filip Maj <fil@adobe.com>
wrote:
>>>>>>> Yep, I've got issues filed for each platform (most assigned to
me).
>>>>>>>They
>>>>>>> will get done this week before we tag the RC.
>>>>>>>
>>>>>>> If JIRA was up I could link you to them :/
>>>>>>>
>>>>>>> On 5/15/12 7:44 AM, "Drew Walters" <deedubbu@gmail.com>
wrote:
>>>>>>>
>>>>>>>>Fil, wouldn't the other native implementations need updated
as well
>>>>>>>>before merging in the changes that are required for cordova-js?
>>>>>>>>
>>>>>>>>On Mon, May 14, 2012 at 5:26 PM, Filip Maj <fil@adobe.com>
wrote:
>>>>>>>>> Hey all,
>>>>>>>>>
>>>>>>>>> Part of the 1.8 work was to change the accelerometer
plugin to
>>>>>>>>>line
>>>>>>>>>it
>>>>>>>>>up
>>>>>>>>> more with the way the Geolocation plugin was rewritten.
>>>>>>>>>Essentially:
>>>>>>>>>
>>>>>>>>> - store callback ids in the plugin for incoming requests
>>>>>>>>> - privatize start() and stop() methods
>>>>>>>>> - start and stop the accel listener based on how many
callbacks
>>>>>>>>>are
>>>>>>>>> waiting for accel data
>>>>>>>>>
>>>>>>>>> The Accel plugin now should implement only 3 actions:
>>>>>>>>>getAcceleration,
>>>>>>>>> addWatch, clearWatch. The plugin should handle calling
start() and
>>>>>>>>>stop()
>>>>>>>>> privately on its own. This also eliminates the awkward
>>>>>>>>>"getTimeout"
>>>>>>>>>and
>>>>>>>>> "setTimeout" actions, and now we are ensured that the
>>>>>>>>>accelerometer
>>>>>>>>>plugin
>>>>>>>>> stops as soon as possible (namely, when no callbacks
in JS are
>>>>>>>>>waiting
>>>>>>>>>for
>>>>>>>>> acceleration values), instead of waiting for the timeout
period to
>>>>>>>>>expire.
>>>>>>>>>
>>>>>>>>> I added a few extra things to the android plugin rewrite
as well,
>>>>>>>>>mainly
>>>>>>>>> checking for accuracy level before returning values to
the web
>>>>>>>>>view.
>>>>>>>>>
>>>>>>>>> If any Android maintainers want to take a look at the
rewrite,
>>>>>>>>>please
>>>>>>>>>have
>>>>>>>>> a look at the 463 branch on the Apache git repo [1].
Would love
>>>>>>>>>feedback
>>>>>>>>> if you have the time to look it over.
>>>>>>>>>
>>>>>>>>> I will be merging it later this week unless someone has
any issues
>>>>>>>>>with
>>>>>>>>>it.
>>>>>>>>>
>>>>>>>>> Thanks,
>>>>>>>>> Fil
>>>>>>>>>
>>>>>>>>> [1]
>>>>>>>>>
>>>>>>>>>http://git-wip-us.apache.org/repos/asf?p=incubator-cordova-android.
>>>>>>>>>gi
>>>>>>>>>t;
>>>>>>>>>a=
>>>>>>>>>sh
>>>>>>>>> ortlog;h=refs/heads/463
>>>>>>>>>
>>>>>>>
>>>>>
>>>
>

Mime
View raw message