incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jukka Zitting <>
Subject Re: Apache Release?
Date Wed, 02 May 2012 23:37:33 GMT

On Thu, May 3, 2012 at 12:57 AM, Tim Kim <> wrote:
> Here's the folder with the latest release:

Great, thanks!

I gave it a quick look and it looks much better than the last time I
tried reviewing. :-)

Here are some quick comments based on a cursory look:

- Some of the nonstandard licenses should be cleared by ASF legal as
described in
- Based on quick reading the only potentially troublesome one seems to
be the Apple license for the Reachability code, as it doesn't allow
modification and thus strictly speaking isn't open source.

- The copyright year should be 2012.
- Drop the extra comment and formatting lines, the file should just
list the actually required notices.
- The first project reference should be "Apache Cordova", not just "Cordova".
- Quite a few bits still refer to PhoneGap, though they're properly
qualified. Those references are IMHO fine for an incubating release,
but should be fixed before graduation.

missing license headers
- many scripts under incubator-cordova-android/bin
- incubator-cordova-android/framework/src/org/apache/cordova/
- many files under incubator-cordova-android/test

embedded binaries
- incubator-cordova-android/framework/libs/commons-codec-1.3.jar
- incubator-cordova-android/test/libs/cordova-1.6.0.jar
- incubator-cordova-blackberry-webworks/template/project/lib/ant-contrib/ant-contrib-1.0b3.jar
- incubator-cordova-wp7/
- As discussed to some length last month on general@, the source
release archive should contain *no* binary build artifacts. Depending
on the type of the artifacts the source release may build such
binaries from sources, download them at build time or ask the user to
manually provide them, but they should not be included as an integral
part of the source archive.

embedded node modules
- incubator-cordova-android/bin/node_modules
- We should either make the build download these automatically, ask
the user to do so, or mention the license(s) of the embedded sprojects
in the LICENSE file.


Jukka Zitting

View raw message