incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Don Coleman <don.cole...@gmail.com>
Subject Re: Adding HTTP status code to FileTransferError
Date Wed, 23 May 2012 19:27:15 GMT
So would it make sense to re-assign the completed tickets to the
platform maintainers?

Are these the right people?

iOS - Shazron
Android - Joe
Webworks - Michael
Mobile Spec - Fil

On Wed, May 23, 2012 at 2:46 PM, Shazron <shazron@gmail.com> wrote:
> This shouldn't be closed until all pull requests + issue subtasks are
> resolved. I would assume the platform maintainers will resolve the
> sub-tasks. Once the sub-tasks are resolved, the parent issue can be closed.
>
> On Wed, May 23, 2012 at 11:42 AM, Don Coleman <don.coleman@gmail.com> wrote:
>
>> I've created pull requests on github for iOS, Android and Webworks
>>
>> Should I close (or resolve) the JIRA ticket?  Or do I assign them to
>> someone else?
>>
>> https://issues.apache.org/jira/browse/CB-790
>>
>> On Fri, May 18, 2012 at 1:12 PM, Simon MacDonald
>> <simon.macdonald@gmail.com> wrote:
>> > Never mind I realize now that Don sent it to the right place. Fil and
>> > I were CC'ed on it.
>> >
>> > Simon Mac Donald
>> > http://hi.im/simonmacdonald
>> >
>> >
>> > On Fri, May 18, 2012 at 1:06 PM, Simon MacDonald
>> > <simon.macdonald@gmail.com> wrote:
>> >> It's here:
>> >>
>> >> https://people.apache.org/committer-index.html
>> >>
>> >> Don sent me the CLA and I'm going to forward it to the right place.
>> >>
>> >> Simon Mac Donald
>> >> http://hi.im/simonmacdonald
>> >>
>> >>
>> >> On Fri, May 18, 2012 at 1:07 PM, Filip Maj <fil@adobe.com> wrote:
>> >>> Where do we check the list of people who've submitted the CLA?
>> >>>
>> >>> On 5/17/12 7:09 PM, "Simon MacDonald" <simon.macdonald@gmail.com>
>> wrote:
>> >>>
>> >>>>I may have missed it but did you sign the Apache CLA? IIRC we need
>> >>>>this before we can merge your pull requests.
>> >>>>
>> >>>>Simon Mac Donald
>> >>>>http://hi.im/simonmacdonald
>> >>>>
>> >>>>
>> >>>>On Thu, May 17, 2012 at 9:33 PM, Don Coleman <don.coleman@gmail.com>
>> >>>>wrote:
>> >>>>> What's the workflow for fixing issues?
>> >>>>>
>> >>>>> I issued pull requests on Github.  (Should these go to Apache
>> instead?)
>> >>>>>
>> >>>>> Do I mark the JIRA issues as resolved or assign it to someone?
>> >>>>>
>> >>>>> android -
>> https://github.com/apache/incubator-cordova-android/pull/22
>> >>>>> iOS - https://github.com/apache/incubator-cordova-ios/pull/18
>> >>>>> mobile-spec -
>> >>>>>https://github.com/apache/incubator-cordova-mobile-spec/pull/6
>> >>>>>
>> >>>>> On Tue, May 15, 2012 at 9:09 PM, Shazron <shazron@gmail.com>
wrote:
>> >>>>>> done
>> >>>>>>
>> >>>>>> On Tue, May 15, 2012 at 5:48 PM, Don Coleman <don.coleman@gmail.com
>> >
>> >>>>>>wrote:
>> >>>>>>> Created https://issues.apache.org/jira/browse/CB-790
>> >>>>>>>
>> >>>>>>> Can someone assign it to me?
>> >>>>>>>
>> >>>>>>> On Tue, May 15, 2012 at 2:02 PM, Filip Maj <fil@adobe.com>
wrote:
>> >>>>>>>> We can drop issues into the issue tracker for the
missing
>> platforms
>> >>>>>>>>and
>> >>>>>>>> hopefully our platform implementers will have time
to get it in
>> for
>> >>>>>>>>1.8.
>> >>>>>>>>
>> >>>>>>>> On 5/15/12 10:47 AM, "Don Coleman" <don.coleman@gmail.com>
wrote:
>> >>>>>>>>
>> >>>>>>>>>I should be able to get most of these changes
this week.  After
>> >>>>>>>>>looking the Blackberry code, I need to redo the
Android patch.
>> I'll
>> >>>>>>>>>look at WP7 tomorrow.  Symbian, Bada, et al
may be more
>> challenging
>> >>>>>>>>>since I don't have test devices.
>> >>>>>>>>>
>> >>>>>>>>>On Tue, May 15, 2012 at 11:56 AM, Filip Maj <fil@adobe.com>
>> wrote:
>> >>>>>>>>>> Sure. Thanks for taking the lead on this
one Don. With your
>> help we
>> >>>>>>>>>>should
>> >>>>>>>>>> be able to get this in for 1.8, possibly
even for the RC
>> >>>>>>>>>>(presumably
>> >>>>>>>>>>later
>> >>>>>>>>>> this week?)
>> >>>>>>>>>>
>> >>>>>>>>>> On 5/14/12 8:20 PM, "Don Coleman" <don.coleman@gmail.com>
>> wrote:
>> >>>>>>>>>>
>> >>>>>>>>>>>Should I create an JIRA ticket for this?
>> >>>>>>>>>>>
>> >>>>>>>>>>>
>> https://github.com/don/incubator-cordova-mobile-spec/tree/FileTrans
>> >>>>>>>>>>>ferEr
>> >>>>>>>>>>>ro
>> >>>>>>>>>>>r
>> >>>>>>>>>>>
>> https://github.com/don/incubator-cordova-ios/tree/FileTransferError
>> >>>>>>>>>>>
>> https://github.com/don/incubator-cordova-android/tree/FileTransferE
>> >>>>>>>>>>>rror
>> >>>>>>>>>>>
>> >>>>>>>>>>>I need to clean up the Android version
before issuing a pull
>> >>>>>>>>>>>request.
>> >>>>>>>>>>>
>> >>>>>>>>>>>I'll take a look at WP7 tomorrow.
>> >>>>>>>>>>>
>> >>>>>>>>>>>On Mon, May 14, 2012 at 3:00 PM, Joe
Bowser <bowserj@gmail.com>
>> >>>>>>>>>>>wrote:
>> >>>>>>>>>>>> +1
>> >>>>>>>>>>>>
>> >>>>>>>>>>>> On Mon, May 14, 2012 at 11:54 AM,
Shazron <shazron@gmail.com>
>> >>>>>>>>>>>>wrote:
>> >>>>>>>>>>>>
>> >>>>>>>>>>>>> +1
>> >>>>>>>>>>>>>
>> >>>>>>>>>>>>> On Mon, May 14, 2012 at 11:56
AM, Filip Maj <fil@adobe.com>
>> >>>>>>>>>>>>>wrote:
>> >>>>>>>>>>>>> > +1 !
>> >>>>>>>>>>>>> >
>> >>>>>>>>>>>>> > On 5/14/12 11:50 AM, "Simon
MacDonald"
>> >>>>>>>>>>>>><simon.macdonald@gmail.com>
>> >>>>>>>>>>>>> wrote:
>> >>>>>>>>>>>>> >
>> >>>>>>>>>>>>> >>Sounds good to me. I'd
probably skip the "http_message" as
>> you
>> >>>>>>>>>>>>>pretty
>> >>>>>>>>>>>>> much
>> >>>>>>>>>>>>> >>get all you need from
the status and you don't need to
>> >>>>>>>>>>>>>localize the
>> >>>>>>>>>>>>> >>string.
>> >>>>>>>>>>>>> >>
>> >>>>>>>>>>>>> >>Simon Mac Donald
>> >>>>>>>>>>>>> >>http://hi.im/simonmacdonald
>> >>>>>>>>>>>>> >>
>> >>>>>>>>>>>>> >>
>> >>>>>>>>>>>>> >>On Mon, May 14, 2012
at 9:29 AM, Don Coleman
>> >>>>>>>>>>>>><don.coleman@gmail.com>
>> >>>>>>>>>>>>> >>wrote:
>> >>>>>>>>>>>>> >>
>> >>>>>>>>>>>>> >>> I'd like to add
HTTP Status Code and HTTP Status Message
>> to
>> >>>>>>>>>>>>> >>> FileTransferError.
>> >>>>>>>>>>>>> >>>
>> >>>>>>>>>>>>> >>> Any objections?
>> >>>>>>>>>>>>> >>>
>> >>>>>>>>>>>>> >>> {
>> >>>>>>>>>>>>> >>>       "code":
FILE_NOT_FOUND_ERR
>> >>>>>>>>>>>>> >>>       "source":
"http://example.com/missing.txt",
>> >>>>>>>>>>>>> >>>       "target":
"file:///mnt/sdcard/foo.txt",
>> >>>>>>>>>>>>> >>>       "http_status":
404
>> >>>>>>>>>>>>> >>>       "http_message":
"Not Found"
>> >>>>>>>>>>>>> >>> }
>> >>>>>>>>>>>>> >>>
>> >>>>>>>>>>>>> >>> {
>> >>>>>>>>>>>>> >>>       "code":
CONNECTION_ERR
>> >>>>>>>>>>>>> >>>       "source":
"http://example.com/protected.txt",
>> >>>>>>>>>>>>> >>>       "target":
"file:///mnt/sdcard/bar.txt",
>> >>>>>>>>>>>>> >>>       "http_status":
401
>> >>>>>>>>>>>>> >>>       "http_message":
"Authorization Required"
>> >>>>>>>>>>>>> >>> }
>> >>>>>>>>>>>>> >>>
>> >>>>>>>>>>>>> >>> {
>> >>>>>>>>>>>>> >>>       "code":
CONNECTION_ERR
>> >>>>>>>>>>>>> >>>       "source":
"http://example.com/admin.txt",
>> >>>>>>>>>>>>> >>>       "target":
"file:///mnt/sdcard/baz.txt",
>> >>>>>>>>>>>>> >>>       "http_status":
403
>> >>>>>>>>>>>>> >>>       "http_message":
"Forbidden"
>> >>>>>>>>>>>>> >>> }
>> >>>>>>>>>>>>> >>>
>> >>>>>>>>>>>>> >
>> >>>>>>>>>>>>>
>> >>>>>>>>>>
>> >>>>>>>>
>> >>>
>>

Mime
View raw message