incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Shazron <shaz...@gmail.com>
Subject Re: Ready to Tag 1.7.0?
Date Tue, 01 May 2012 00:36:40 GMT
Cool, will wait for your report. Probably will have to pick this up
again tomorrow, and re-test since it will be common code.

On Tue, May 1, 2012 at 12:32 AM, Jesse <purplecabbage@gmail.com> wrote:
> many, nope
>
> On Mon, Apr 30, 2012 at 5:30 PM, Shazron <shazron@gmail.com> wrote:
>
>> Failing tests? WP7 specific ones?
>>
>>
>> On Tue, May 1, 2012 at 12:28 AM, Jesse <purplecabbage@gmail.com> wrote:
>> > I will still have changes ...
>> >
>> > On Mon, Apr 30, 2012 at 5:12 PM, Joe Bowser <bowserj@gmail.com> wrote:
>> >
>> >> OK
>> >>
>> >> On Mon, Apr 30, 2012 at 5:06 PM, Anis KADRI <anis.kadri@gmail.com>
>> wrote:
>> >>
>> >> > do it
>> >> >
>> >> > On Mon, Apr 30, 2012 at 5:00 PM, Shazron <shazron@gmail.com>
wrote:
>> >> >
>> >> > > The fix for this so we can get 1.7.0 out is:
>> >> > >
>> >> > > 1. Revert
>> >> > >
>> >> >
>> >>
>> https://github.com/apache/incubator-cordova-js/blob/master/lib/cordova.js#L280-285
>> >> > > to it's previous use (no deprecation function call, straight
>> >> > > assignment to cordova object - I've already re-opened CB-298)
>> >> > > 2. Commit the fix
>> >> > > 3. Un-tag and re-tag 1.7.0 cordova-js
>> >> > > 4. All platforms get the new cordova-js, then re-test
>> >> > >
>> >> > > What do you guys think?
>> >> > >
>> >> > > On Mon, Apr 30, 2012 at 11:39 PM, Shazron <shazron@gmail.com>
>> wrote:
>> >> > > > Found the problem, it's a timing issue:
>> >> > > >
>> >> > > > Before this function is called:
>> >> > > >
>> >> > >
>> >> >
>> >>
>> https://github.com/apache/incubator-cordova-js/blob/master/lib/cordova.js#L281
>> >> > > >
>> >> > > > ... cordova.exec is not defined yet.
>> >> > > >
>> >> > > > On Mon, Apr 30, 2012 at 11:13 PM, Joe Bowser <bowserj@gmail.com>
>> >> > wrote:
>> >> > > >> I do see it on Android, but this looks to me like a janky
test
>> when
>> >> > you
>> >> > > >> look at it.  I guess we should un-tag and re-tag this.
:(
>> >> > > >>
>> >> > > >> On Mon, Apr 30, 2012 at 4:01 PM, Shazron <shazron@gmail.com>
>> wrote:
>> >> > > >>
>> >> > > >>> iOS is fine except for
>> >> https://issues.apache.org/jira/browse/CB-560
>> >> > > >>> being broken by the fix for
>> >> > > >>> https://issues.apache.org/jira/browse/CB-298 which
would fail
>> for
>> >> > your
>> >> > > >>> platforms as well, I'm sure you've seen this.
>> >> > > >>>
>> >> > > >>> Fil can you take a look at this when you get the
chance since it
>> >> was
>> >> > > >>> your commit? I'm taking a look at it now, but you
probably could
>> >> > > >>> pinpoint this faster.
>> >> > > >>>
>> >> > > >>>
>> >> > > >>>
>> >> > > >>> On Mon, Apr 30, 2012 at 10:40 PM, Shazron <shazron@gmail.com>
>> >> wrote:
>> >> > > >>> > Don't know what's going on with the tests, I've
verified that
>> >> the:
>> >> > > >>> > 1. Contact update works, and does return a success
callback
>> (in
>> >> > > Obj-C)
>> >> > > >>> > - might be a faulty test, dunno?
>> >> > > >>> >
>> >> > > >>> >
>> >> > > >>> > This one really fails -- PhoneGap.exec is not
defined -
>> probably
>> >> > > >>> > related to this change:
>> >> > > >>> >
>> >> > > >>>
>> >> > >
>> >> >
>> >>
>> https://github.com/apache/incubator-cordova-js/commit/b80ff3407ee5de1736b26fd2f82a96c2dd8d34c5
>> >> > > >>> >
>> >> > > >>> >
>> >> > > >>> >
>> >> > > >>> > On Mon, Apr 30, 2012 at 8:49 PM, Shazron <shazron@gmail.com>
>> >> > wrote:
>> >> > > >>> >> Investigating two failing tests that didn't
fail before:
>> >> > > >>> >>
>> >> > > >>> >> 1. Contacts (navigator.contacts) save method
updated a
>> contact.
>> >> > > >>> >> (saveSuccess timeout)
>> >> > > >>> >> 2. Platform (cordova) Platform (PhoneGap)
exec method should
>> >> exist
>> >> > > >>> >>
>> >> > > >>> >>
>> >> > > >>> >> On Mon, Apr 30, 2012 at 8:43 PM, Joe Bowser
<
>> bowserj@gmail.com>
>> >> > > wrote:
>> >> > > >>> >>> Android is tested and tagged.
>> >> > > >>> >>>
>> >> > > >>> >>> On Mon, Apr 30, 2012 at 1:29 PM, Joe
Bowser <
>> bowserj@gmail.com
>> >> >
>> >> > > wrote:
>> >> > > >>> >>>
>> >> > > >>> >>>> Agreed. I have cb7a4c7a4 on this
end.
>> >> > > >>> >>>>
>> >> > > >>> >>>> On Mon, Apr 30, 2012 at 1:18 PM,
Jesse <
>> >> purplecabbage@gmail.com
>> >> > >
>> >> > > >>> wrote:
>> >> > > >>> >>>>
>> >> > > >>> >>>>> Ah, that is the merge commit
to my own fork ...
>> >> > > >>> >>>>>
>> >> > > >>> >>>>>
>> >> > > >>>
>> >> > >
>> >> >
>> >>
>> https://github.com/purplecabbage/incubator-cordova-js/commit/97d4ff51d1c63ce1017fd54e1493795c193722f6
>> >> > > >>> >>>>>
>> >> > > >>> >>>>>
>> >> > > >>> >>>>> Seems this commit output file
logging does not function as
>> >> > > expected.
>> >> > > >>> >>>>>
>> >> > > >>> >>>>> On Mon, Apr 30, 2012 at 1:11
PM, Shazron <
>> shazron@gmail.com>
>> >> > > wrote:
>> >> > > >>> >>>>>
>> >> > > >>> >>>>> > I don't think it's 97d4.
>> >> > > >>> >>>>> > The tag was:
>> >> > > >>> >>>>> >
>> >> > > >>> >>>>> > Updated Tags:  refs/tags/1.7.0
[created] cb7a4c7a4
>> >> > > >>> >>>>> >
>> >> > > >>> >>>>> >
>> >> > > >>> >>>>> > On Mon, Apr 30, 2012 at
12:29 PM, Jesse <
>> >> > > purplecabbage@gmail.com>
>> >> > > >>> >>>>> wrote:
>> >> > > >>> >>>>> > > Thanks Shaz!
>> >> > > >>> >>>>> > >
>> >> > > >>> >>>>> > > So everyone should
be working from a platform js file
>> >> that
>> >> > > has
>> >> > > >>> the
>> >> > > >>> >>>>> SHA:
>> >> > > >>> >>>>> > > // commit 97d4ff51d1c63ce1017fd54e1493795c193722f6
>> >> > > >>> >>>>> > >
>> >> > > >>> >>>>> > > On Mon, Apr 30, 2012
at 12:23 PM, Shazron <
>> >> > shazron@gmail.com
>> >> > > >
>> >> > > >>> wrote:
>> >> > > >>> >>>>> > >
>> >> > > >>> >>>>> > >> I tagged cordova-js
so we can move on with testing.
>> >> > > >>> >>>>> > >>
>> >> > > >>> >>>>> > >> On Mon, Apr 30,
2012 at 12:05 PM, Shazron <
>> >> > > shazron@gmail.com>
>> >> > > >>> wrote:
>> >> > > >>> >>>>> > >> > I can tag
- no one is making changes anymore I
>> reckon?
>> >> > > >>> >>>>> > >> >
>> >> > > >>> >>>>> > >> > On Mon, Apr
30, 2012 at 11:31 AM, Joe Bowser <
>> >> > > >>> bowserj@gmail.com>
>> >> > > >>> >>>>> > wrote:
>> >> > > >>> >>>>> > >> >> Who is
tagging cordova-js again?
>> >> > > >>> >>>>> > >> >>
>> >> > > >>> >>>>> > >> >> On Mon,
Apr 30, 2012 at 11:27 AM, Brian LeRoux <
>> >> > > b@brian.io>
>> >> > > >>> >>>>> wrote:
>> >> > > >>> >>>>> > >> >>
>> >> > > >>> >>>>> > >> >>> tag
it, and create a branche for 1.8
>> >> > > >>> >>>>> > >> >>>
>> >> > > >>> >>>>> > >> >>> On
Mon, Apr 30, 2012 at 11:18 AM, Jesse <
>> >> > > >>> purplecabbage@gmail.com
>> >> > > >>> >>>>> >
>> >> > > >>> >>>>> > >> wrote:
>> >> > > >>> >>>>> > >> >>> >
+1 on readiness
>> >> > > >>> >>>>> > >> >>> >
>> >> > > >>> >>>>> > >> >>> >
On Mon, Apr 30, 2012 at 11:13 AM, Anis KADRI <
>> >> > > >>> >>>>> > anis.kadri@gmail.com>
>> >> > > >>> >>>>> > >> >>> wrote:
>> >> > > >>> >>>>> > >> >>> >
>> >> > > >>> >>>>> > >> >>> >>
I am ready to tag my repos. I actually I'd
>> like
>> >> to
>> >> > > do it
>> >> > > >>> >>>>> today so
>> >> > > >>> >>>>> > >> that I
>> >> > > >>> >>>>> > >> >>> >>
can tackle the 1.8.0 tasks.
>> >> > > >>> >>>>> > >> >>> >>
>> >> > > >>> >>>>> > >> >>> >>
On Mon, Apr 30, 2012 at 10:24 AM, Shazron
>> >> Abdullah
>> >> > <
>> >> > > >>> >>>>> > >> shazron@gmail.com
>> >> > > >>> >>>>> > >> >>> >>
>wrote:
>> >> > > >>> >>>>> > >> >>> >>
>> >> > > >>> >>>>> > >> >>> >>
> I'm gonna punt that one to 1.8. All I have
>> to
>> >> do
>> >> > is
>> >> > > >>> update
>> >> > > >>> >>>>> > >> guides, etc
>> >> > > >>> >>>>> > >> >>> >>
> - looking at the checklist. And perhaps new
>> >> bugs
>> >> > > filed
>> >> > > >>> over
>> >> > > >>> >>>>> the
>> >> > > >>> >>>>> > >> >>> >>
> weekend, seeing if they are critical.
>> >> > > >>> >>>>> > >> >>> >>
>
>> >> > > >>> >>>>> > >> >>> >>
> On 2012-04-30, at 10:01 AM, Joe Bowser <
>> >> > > >>> bowserj@gmail.com>
>> >> > > >>> >>>>> > wrote:
>> >> > > >>> >>>>> > >> >>> >>
>
>> >> > > >>> >>>>> > >> >>> >>
> > Hey
>> >> > > >>> >>>>> > >> >>> >>
> >
>> >> > > >>> >>>>> > >> >>> >>
> > How are people feeling about tagging 1.7.0
>> >> > > today? I
>> >> > > >>> notice
>> >> > > >>> >>>>> > that
>> >> > > >>> >>>>> > >> the
>> >> > > >>> >>>>> > >> >>> >>
> tracker
>> >> > > >>> >>>>> > >> >>> >>
> > only has a single iOS bug.
>> >> > > >>> >>>>> > >> >>> >>
> >
>> >> > > >>> >>>>> > >> >>> >>
> > Joe
>> >> > > >>> >>>>> > >> >>> >>
>
>> >> > > >>> >>>>> > >> >>> >>
>> >> > > >>> >>>>> > >> >>> >
>> >> > > >>> >>>>> > >> >>> >
>> >> > > >>> >>>>> > >> >>> >
>> >> > > >>> >>>>> > >> >>> >
--
>> >> > > >>> >>>>> > >> >>> >
@purplecabbage
>> >> > > >>> >>>>> > >> >>> >
risingj.com
>> >> > > >>> >>>>> > >> >>>
>> >> > > >>> >>>>> > >>
>> >> > > >>> >>>>> > >
>> >> > > >>> >>>>> > >
>> >> > > >>> >>>>> > >
>> >> > > >>> >>>>> > > --
>> >> > > >>> >>>>> > > @purplecabbage
>> >> > > >>> >>>>> > > risingj.com
>> >> > > >>> >>>>> >
>> >> > > >>> >>>>>
>> >> > > >>> >>>>>
>> >> > > >>> >>>>>
>> >> > > >>> >>>>> --
>> >> > > >>> >>>>> @purplecabbage
>> >> > > >>> >>>>> risingj.com
>> >> > > >>> >>>>>
>> >> > > >>> >>>>
>> >> > > >>> >>>>
>> >> > > >>>
>> >> > >
>> >> >
>> >>
>> >
>> >
>> >
>> > --
>> > @purplecabbage
>> > risingj.com
>>
>
>
>
> --
> @purplecabbage
> risingj.com

Mime
View raw message