incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Shazron <shaz...@gmail.com>
Subject Re: tag rc monday?
Date Sat, 26 May 2012 01:15:16 GMT
Filed as: https://issues.apache.org/jira/browse/CB-831

On Fri, May 25, 2012 at 6:13 PM, Shazron <shazron@gmail.com> wrote:

> Becky brought up the failing spec test here (no response):
> http://apache.markmail.org/thread/hgc7cpwoca6wl7rx
>
> I'm filing it as a mobile-spec issue...
>
> On Fri, May 25, 2012 at 6:11 PM, Shazron <shazron@gmail.com> wrote:
>
>> I tried to verify the failing test by calling the watchPosition directly
>> -- and it wasn't working. So I tracked it down to this line:
>>
>> https://github.com/apache/incubator-cordova-ios/blob/master/CordovaLib/Classes/CDVLocation.m#L362
>>
>> Set it to setKeepCallbackAsBool:YES and it works.... BUT the same unit
>> test still fails for some reason.
>>
>> What the returnLocation function needs is a parameter to keep the
>> callback or not, since getLocation uses this function (don't keep the
>> callback) but watchPosition needs to keep the callback, and if I change it
>> there might be side-effects, dunno. Sleeping on it...(at least thinking
>> about it some more) ... it's not a trivial change by any means, but in the
>> meantime watchPosition is broken...
>>
>> Shaz
>>
>>
>> On Fri, May 25, 2012 at 4:37 PM, Shazron <shazron@gmail.com> wrote:
>>
>>> 1 test failing, trying to track it down. Pretty good! (on device - on
>>> Simulator it fails as expected on some stuff)
>>>
>>> Geolocation (navigator.geolocation) watchPostition method success
>>> callback should be called with a Position object.
>>> TypeError: "undefined" is not a function
>>> timeout: timed out after 20000 msec waiting for win never called
>>>
>>>
>>> On Fri, May 25, 2012 at 3:14 PM, Herm Wong <herm.wong@hotmail.com>wrote:
>>>
>>>>
>>>> ran the RAT on webos and tagged webos 1.8.0rc1.
>>>>
>>>> > Date: Fri, 25 May 2012 10:14:21 -0700
>>>> > Subject: Re: tag rc monday?
>>>> > From: anis.kadri@gmail.com
>>>> > To: callback-dev@incubator.apache.org
>>>> >
>>>> > Bada tagged 1.8.0rc1
>>>> >
>>>> > On Fri, May 25, 2012 at 8:07 AM, Michael Brooks <
>>>> michael@michaelbrooks.ca>wrote:
>>>> >
>>>> > > Great Shazron. I've reviewed the documentation and it can be tagged
>>>> once
>>>> > > you've written the upgrade guide.
>>>> > >
>>>> > > Michael
>>>> > >
>>>> > > On Thu, May 24, 2012 at 9:17 PM, Shazron <shazron@gmail.com>
wrote:
>>>> > >
>>>> > > > iOS is almost ready except for the Upgrade Guide, which I
will
>>>> finish
>>>> > > > tomorrow, then tag.
>>>> > > >
>>>> > > > On Thu, May 24, 2012 at 6:53 PM, Simon MacDonald
>>>> > > > <simon.macdonald@gmail.com>wrote:
>>>> > > >
>>>> > > > > I pulled the latest JS into the Android repo and tagged
it to
>>>> 1.8.0rc1.
>>>> > > > Did
>>>> > > > > a quick run of mobile spec and it looked okay. The real
testing
>>>> in
>>>> > > > earnest
>>>> > > > > is tomorrow.
>>>> > > > >
>>>> > > > > Simon Mac Donald
>>>> > > > > http://hi.im/simonmacdonald
>>>> > > > >
>>>> > > > >
>>>> > > > > On Thu, May 24, 2012 at 5:52 PM, Jesse <purplecabbage@gmail.com
>>>> >
>>>> > > wrote:
>>>> > > > >
>>>> > > > > > cordova-js has been tagged 1.8.0rc1
>>>> > > > > > Please verify a new build of the js on your platform
and
>>>> report your
>>>> > > > > > status.
>>>> > > > > > Pending it working okay everywhere, we can move
on to tagging
>>>> the
>>>> > > rest
>>>> > > > of
>>>> > > > > > the repos.
>>>> > > > > >
>>>> > > > > > Cheers,
>>>> > > > > >  Jesse
>>>> > > > > >
>>>> > > > > > On Thu, May 24, 2012 at 9:53 AM, Herm Wong <
>>>> herm.wong@hotmail.com>
>>>> > > > > wrote:
>>>> > > > > >
>>>> > > > > > >
>>>> > > > > > > FYI - Monday is a stat holiday in the US (Memorial
Day).
>>>> > > > > > >
>>>> > > > > > > > Date: Thu, 24 May 2012 09:31:52 -0700
>>>> > > > > > > > Subject: Re: tag rc monday?
>>>> > > > > > > > From: bowserj@gmail.com
>>>> > > > > > > > To: callback-dev@incubator.apache.org
>>>> > > > > > > >
>>>> > > > > > > > So, I guess we're dropping CordovaWebView
support for
>>>> 1.8.0?
>>>> > > > > > > >
>>>> > > > > > > > On Thu, May 24, 2012 at 5:34 AM, Michael
Brooks <
>>>> > > > > > > michael@michaelbrooks.ca>wrote:
>>>> > > > > > > >
>>>> > > > > > > > > Awesome, thanks Simon!
>>>> > > > > > > > >
>>>> > > > > > > > > Let's tag and roll out 1.8.0rc1 today!
>>>> > > > > > > > >
>>>> > > > > > > > > Michael
>>>> > > > > > > > >
>>>> > > > > > > > > On Thu, May 24, 2012 at 4:41 AM,
Simon MacDonald
>>>> > > > > > > > > <simon.macdonald@gmail.com>wrote:
>>>> > > > > > > > >
>>>> > > > > > > > > > +1 on Android
>>>> > > > > > > > > >
>>>> > > > > > > > > > On Wednesday, May 23, 2012,
Michael Brooks wrote:
>>>> > > > > > > > > >
>>>> > > > > > > > > > > Great.
>>>> > > > > > > > > > >
>>>> > > > > > > > > > > Can someone from IBM please
speak up about Android?
>>>> > > > > > > > > > >
>>>> > > > > > > > > > > Michael
>>>> > > > > > > > > > >
>>>> > > > > > > > > > > On Wed, May 23, 2012 at
5:53 PM, Tim Kim <
>>>> > > timkim85@gmail.com
>>>> > > > > > > > > > <javascript:;>>
>>>> > > > > > > > > > > wrote:
>>>> > > > > > > > > > >
>>>> > > > > > > > > > > > +1
>>>> > > > > > > > > > > >
>>>> > > > > > > > > > >
>>>> > > > > > > > > >
>>>> > > > > > > > > >
>>>> > > > > > > > > > --
>>>> > > > > > > > > > Simon Mac Donald
>>>> > > > > > > > > > http://hi.im/simonmacdonald
>>>> > > > > > > > > >
>>>> > > > > > > > >
>>>> > > > > > >
>>>> > > > > > >
>>>> > > > > >
>>>> > > > > >
>>>> > > > > >
>>>> > > > > > --
>>>> > > > > > @purplecabbage
>>>> > > > > > risingj.com
>>>> > > > > >
>>>> > > > >
>>>> > > >
>>>> > >
>>>>
>>>>
>>>
>>>
>>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message