incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dave Johnson <dave.c.john...@gmail.com>
Subject Re: Java Style
Date Wed, 16 May 2012 05:34:16 GMT
4 tabs, 1 space.

On Tue, May 15, 2012 at 2:48 PM, Simon MacDonald
<simon.macdonald@gmail.com> wrote:
> +1 on 4 spaces, no tabs.
>
> Simon Mac Donald
> http://hi.im/simonmacdonald
>
>
> On Tue, May 15, 2012 at 5:39 PM, Joe Bowser <bowserj@gmail.com> wrote:
>
>> Remember to set Indentation and Tabs the same.  I had Indentation 2 and
>> Tabs 4.
>>
>> On Tue, May 15, 2012 at 2:30 PM, Filip Maj <fil@adobe.com> wrote:
>>
>> > Holy crap a bit tougher in Eclipse on mac.
>> >
>> > Eclipse -> Preferences -> Java -> Code Style -> Formatter ->
Edit the
>> > selected Profile -> Change its name -> First option (tab policy): Spaces
>> > only -> Indentation: 4
>> >
>> > Phew!
>> >
>> > On 5/15/12 2:17 PM, "Filip Maj" <fil@adobe.com> wrote:
>> >
>> > >OK will add that to the style guide then. Please adjust Eclipse
>> > >accordingly, everyone!
>> > >
>> > >On 5/15/12 2:12 PM, "Bryce Curtis" <curtis.bryce@gmail.com> wrote:
>> > >
>> > >>+1 on 4 spaces, no tabs.
>> > >>
>> > >>On Tue, May 15, 2012 at 4:07 PM, Michael Brooks
>> > >><michael@michaelbrooks.ca> wrote:
>> > >>> +1 on 4 spaces in Java.
>> > >>>
>> > >>> On Tue, May 15, 2012 at 1:55 PM, Joe Bowser <bowserj@gmail.com>
>> wrote:
>> > >>>
>> > >>>> +1 on spaces.  It should be noted that this isn't the default
in
>> > >>>>Eclipse.
>> > >>>> :(
>> > >>>>
>> > >>>> On Tue, May 15, 2012 at 1:52 PM, Drew Walters <deedubbu@gmail.com>
>> > >>>>wrote:
>> > >>>>
>> > >>>> > Should note, all the BlackBerry Java code is 4 space indentation
>> > >>>> > except for maybe a few spots where someone else edited
the file.
>> > >>>> >
>> > >>>> > On Tue, May 15, 2012 at 3:50 PM, Drew Walters <deedubbu@gmail.com
>> >
>> > >>>> wrote:
>> > >>>> > > +1 spaces
>> > >>>> > >
>> > >>>> > > On Tue, May 15, 2012 at 3:48 PM, Shazron <shazron@gmail.com>
>> > >>>>wrote:
>> > >>>> > >> Spaces.
>> > >>>> > >> I've an issue filed against iOS regarding this:
>> > >>>> > >> https://issues.apache.org/jira/browse/CB-625
>> > >>>> > >>
>> > >>>> > >>
>> > >>>> > >> On Tue, May 15, 2012 at 1:49 PM, Filip Maj <fil@adobe.com>
>> > wrote:
>> > >>>> > >>> I suppose I should post my refs too
>> > >>>> > >>>
>> > >>>> > >>> [1] http://wiki.apache.org/cordova/StyleGuide
>> > >>>> > >>> [2]
>> > >>>> > >>>
>> > >>>> >
>> > >>>>
>> > >>>>
>> > http://www.oracle.com/technetwork/java/javase/documentation/codeconvent
>> > >>>>i
>> > >>>>ons
>> > >>>> > >>> -136091.html#262
>> > >>>> > >>>
>> > >>>> > >>> On 5/15/12 1:48 PM, "Filip Maj" <fil@adobe.com>
wrote:
>> > >>>> > >>>
>> > >>>> > >>>>Let's see how this one pans out ;)
>> > >>>> > >>>>
>> > >>>> > >>>>This came up during the code review of
the CordovaWebView
>> stuff
>> > >>>>for
>> > >>>> > >>>>Android. Our style guide [1] specifies
to follow the Eclipse
>> > >>>>Coding
>> > >>>> > >>>>Conventions, which point to standards
set out by Sun, which of
>> > >>>>course
>> > >>>> > now
>> > >>>> > >>>>points to an Oracle web site.
>> > >>>> > >>>>
>> > >>>> > >>>>The Sun standards say [2] about indentation:
>> > >>>> > >>>>
>> > >>>> > >>>>----
>> > >>>> > >>>>
>> > >>>> > >>>>4 - Indentation
>> > >>>> > >>>>
>> > >>>> > >>>>Four spaces should be used as the unit
of indentation. The
>> exact
>> > >>>> > >>>>construction of the indentation (spaces
vs. tabs) is
>> > >>>>unspecified.
>> > >>>> Tabs
>> > >>>> > >>>>must be set exactly every 8 spaces (not
4).
>> > >>>> > >>>>
>> > >>>> > >>>>----
>> > >>>> > >>>>
>> > >>>> > >>>>
>> > >>>> > >>>>So my question is: tabs or spaces in Java
code?
>> > >>>> > >>>>
>> > >>>> > >>>>My vote: spaces.
>> > >>>> > >>>>
>> > >>>> > >>>>Let your voice be heard.
>> > >>>> > >>>>
>> > >>>> > >>>
>> > >>>> >
>> > >>>>
>> > >
>> >
>> >
>>

Mime
View raw message