incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Becky Gibson <gibson.be...@gmail.com>
Subject Re: cordova-js Code Review request
Date Fri, 25 May 2012 20:03:10 GMT
OK, I realize an hour and a half isn't much time for a code review. But, I
gotta power down as my office is moving.  Checked in the code.  Will check
in later to make sure there are no issues.



On Fri, May 25, 2012 at 2:30 PM, Becky Gibson <gibson.becky@gmail.com>wrote:

> The pull request for codova-js didn't come through - although the one for
> cordova-ios did post to the list?
>
> At any rate, since I am changing common code, would appreciate a quick
> code review of my changes for camera.   Will commit as soon as some gives
> this a once over.  Note that I added the CameraPopoverOptions object ONLY
> for iOS.  I think that is appropriate.  Although I added the
> arrowDirections to the already existing public CameraConstants.
>
> Associated iOS pull request is out there as well if your interested.
>
> thanks,
> -becky
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message