incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shazron Abdullah (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-560) Cordova breaking iOS plugins
Date Tue, 01 May 2012 20:32:49 GMT

    [ https://issues.apache.org/jira/browse/CB-560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266048#comment-13266048
] 

Shazron Abdullah commented on CB-560:
-------------------------------------

Of course it does - it worked without using the deprecateFunctions call when doing window.PhoneGap
= cordova for example, but after applying CB-298 PhoneGap.exec is missing - thus CB-298 broke
this. Like I said it's a timing issue (see my previous comment).

Moving them to common.js will fix this but essentially CB-298 (deprecations) is not applied
to PhoneGap and Cordova globals at all.


                
> Cordova breaking iOS plugins
> ----------------------------
>
>                 Key: CB-560
>                 URL: https://issues.apache.org/jira/browse/CB-560
>             Project: Apache Callback
>          Issue Type: Bug
>          Components: CordovaJS
>    Affects Versions: 1.6.1
>         Environment: From https://groups.google.com/forum/?fromgroups#!topic/phonegap/2G5OPKV_FdQ
someone apparently tried upgrading from PhoneGap 1.1 to 1.6.
>            Reporter: Chris Brody
>            Assignee: Filip Maj
>             Fix For: 1.7.0
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> From 1.4 to 1.5, the namespace was changed from PhoneGap to Cordova which was breaking
all of the existing plugins. I eventually provided a shim class but it was too late to stop
the pain. Then in Javascript only Cordova was changed to cordova, breaking the iOS plugins
yet again. I noticed in cordova (1.6.0) JS:
> if (!window.PhoneGap) {
>     window.PhoneGap = cordova;
> }
> This should have been done for Cordova like:
> if (!Cordova) {
>  Cordova = cordova;
> }
> Yes we should be deprecating the old namespaces for removal in another major release.
Any API changes made before a major release should be made with a workaround, to be deprecated,
and tested with some plugins before shipping.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message