incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Filip Maj (JIRA)" <>
Subject [jira] [Commented] (CB-298) DEPRECATE "plugins" and "PhoneGap" global objects in JavaScript implementation
Date Tue, 01 May 2012 20:06:51 GMT


Filip Maj commented on CB-298:

Nevermind, I was wrong. Sorry Shaz.

Just wrote up a test to prove what's going on. The new object reference created by {{deprecateFunctions}}
causes exec to not exist on the root {{cordova}} object. The {{PhoneGap}} and {{Cordova}}
globals reference the {{cordova}} object directly by reference prior to the fix commit in
this issue, and thus get the {{exec}} method once it is tacked on via the platform definition
common.js file.

The test is here:

You can run the above test, and in cordova.js, swap between using {{deprecateFunctions}} and
not, and see the failing tests in each case.
> DEPRECATE "plugins" and "PhoneGap" global objects in JavaScript implementation
> ------------------------------------------------------------------------------
>                 Key: CB-298
>                 URL:
>             Project: Apache Callback
>          Issue Type: Improvement
>          Components: CordovaJS
>    Affects Versions: 1.4.0, 1.5.0, 1.6.0
>            Reporter: Filip Maj
>            Assignee: Shazron Abdullah
>            Priority: Minor
>              Labels: api-change, javascript
>             Fix For: 1.7.0
> There are two globals currently defined in Cordova-JS' common platform definition, which
get dropped onto the `window` object: `plugins` and `PhoneGap`.
> Let's slate these for removal.
> In 1.6, let's set up deprecation notices for these.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:!default.jspa
For more information on JIRA, see:


View raw message