incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Page (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-629) File API tests failing on WP7
Date Mon, 07 May 2012 04:48:45 GMT

    [ https://issues.apache.org/jira/browse/CB-629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269363#comment-13269363
] 

Ben Page commented on CB-629:
-----------------------------

I'm pretty sure I'm correct is saying that the way the WP7 library reads the options from
the exec command are completely wrong. The exec command sends an array of options, eg this
one (I know this doesn't relate to the File API but it seems to be throughout the code):

exec(successCallback, errorCallback, "Capture", "getFormatData", [this.fullPath, this.type]);

However, in the WP7 library, it tries to evaluate that array via a JSON deserializer?? In
the above example, it tries to deserialize to an object 'MediaFormatOptions' - but all the
deserializer gets is a JSON representation of an array (ie, no member names), like this:

mediaFormatOptions = JSON.JsonHelper.Deserialize<MediaFormatOptions>(options);

Either the js code needs to be modified thus:
exec(successCallback, errorCallback, "Capture", "getFormatData", {fullPath:this.fullPath,
type:this.type});
OR the library needs to be changed so that each class (in this case, MediaFormatOptions) are
built by deserializing a JSON **ARRAY** and then referring to the relevant member names.
                
> File API tests failing on WP7
> -----------------------------
>
>                 Key: CB-629
>                 URL: https://issues.apache.org/jira/browse/CB-629
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: WP7
>    Affects Versions: 1.7.0
>         Environment: WP7 Jasmine tests
>            Reporter: Jesse MacFadyen
>            Assignee: Jesse MacFadyen
>            Priority: Blocker
>             Fix For: 1.8.0
>
>
> There are multiple failing tests in the updated Jasmine tests for the File API on WP7.
 Need to evaluate them individually, and fix them. 
> Some are trivial like "//" in a file path versus "/" or returning error result of 1 instead
of 5, ... These all need to be evaluated and fixed, so we can have a clear idea of API support.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message