Mailing-List: contact callback-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: callback-dev@incubator.apache.org
Received-SPF: neutral (athena.apache.org: local policy)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Apple Message framework v1257)
Subject: Re: Pull request for ticket CB-442
From: Marcus Wu <wum@bibliolabs.com>
In-Reply-To: <89E97633190845B895DF75FADC387F8E@gmail.com>
Date: Fri, 6 Apr 2012 13:51:42 -0400
Content-Transfer-Encoding: quoted-printable
Message-Id: <DD29F019-6A5B-485A-8F0E-CA9925204060@bibliolabs.com>
References: <FC06B8C9-ABFF-4B91-B98A-0CEB84CD7693@bibliolabs.com>
 <89E97633190845B895DF75FADC387F8E@gmail.com>
To: callback-dev@incubator.apache.org

Yes, I did.

Thanks,
Marcus

On Apr 6, 2012, at 1:33 PM, Shazron Abdullah wrote:

> Thanks Marcus, I'll test it today. Did you send in your Apache iCLA?=20=

>=20
>=20
> On Friday, 6 April, 2012 at 7:40 AM, Marcus Wu wrote:
>=20
>> I've submitted a pull request for ticket CB-442 to prevent the =
FileTransfer download command from blocking javascript on iOS. For =
convenience I have pasted my pull request comments below:
>>=20
>>> I have converted the download command from using the blocking NSData =
dataWithContentsOfURL: call to use a NSURLConnection so that performance =
is improved.
>>>=20
>>> I added on to the existing delegate rather than creating a second =
one for the download. Additionally, I am checking the HTTP status code =
on the response so we don't end up saving an error page and returning =
success.
>>=20
>> The changes are rather significant for the download command so please =
let me know if I need to improve it in any way.
>>=20
>> Thanks,
>> Marcus
>>=20
>>=20
>=20
>=20