Mailing-List: contact callback-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: callback-dev@incubator.apache.org
Received-SPF: pass (athena.apache.org: domain of bowserj@gmail.com designates
 74.125.82.43 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CAMT1KGN6W8qJ4RnDEtwomCZxg_XgKXBOa57L79_kHZhPEMAjSQ@mail.gmail.com>
References: 
 <CAOBL_k5TCOCBqC2x9vUsHCSACUPEz+Ze-8wKxcgbBdPf83MPrQ@mail.gmail.com>
	<CBB1B408.4541%fil@adobe.com>
	<CAMT1KGN6W8qJ4RnDEtwomCZxg_XgKXBOa57L79_kHZhPEMAjSQ@mail.gmail.com>
Date: Mon, 16 Apr 2012 15:55:26 -0700
Message-ID: 
 <CAOBL_k51RL5iLhUWv0rNTY6mm7QJddfBexPnNeex98vz8vrBqA@mail.gmail.com>
Subject: Re: [Android] CordovaWebView - loadUrlIntoView
From: Joe Bowser <bowserj@gmail.com>
To: callback-dev@incubator.apache.org
Content-Type: multipart/alternative; boundary=f46d044268e6d4dc6204bdd3b7b7

--f46d044268e6d4dc6204bdd3b7b7
Content-Type: text/plain; charset=ISO-8859-1

Undocumented or poorly documented APIs are bad, since the only people who
really know about them are the people who wrote them initially.

The problem right now is that none of these properties are documented
anywhere other than the header file on DroidGap.  Also, they currently are
in DroidGap.  I personally don't think that we should have the loading
dialog in the activity and that it should be a plugin where we can control
the text via javascript (either as a part of Cordova's API, or something
external).  I've closed a bug because it could be worked around using one
of these properties, but this is a new doc task that we have to add that's
Android specific, which I'm not a big fan of.

BTW: I moved CordovaWebView to 1.8.0, because I don't think we'll get it
done in the next two weeks with the testing required.  Does anyone have any
strong objections to this?

Joe


On Mon, Apr 16, 2012 at 3:49 PM, Bryce Curtis <curtis.bryce@gmail.com>wrote:

> There are several properties that can be set on DroidGap that deal
> with UI - loading dialog, splash screen and background color.  They
> are used to give the user an indication that something is going on
> before the app is ready to be displayed.
>
> I think they are needed, but should be moved out of the webview into
> DroidGap (or other activity that the user can extend).  The webview
> can broadcast events that the activity can register for to management
> these things.
>
> I know that other platforms have splash screen, so would it work to
> abstract this?
>
> On Mon, Apr 16, 2012 at 4:24 PM, Filip Maj <fil@adobe.com> wrote:
> > +1 ripping it out, sounds like a great candidate for a plugin.
> >
> > None of the other native platform implementations have this sort of stuff
> > "built-in" (loading dialog UI niceties) so I am not super keen on keeping
> > it. Esp. if it's done in a way that makes Android antsy.
> >
> > That being said, we don't wanna just rip it out out of nowhere. Probably
> > need to deprecate somehow [1], ya? I.e. Deprecate til 2.0 and then axe
> it!
> >
> > [1] http://wiki.apache.org/cordova/DeprecationPolicy
> >
> > On 4/16/12 11:29 AM, "Joe Bowser" <bowserj@gmail.com> wrote:
> >
> >>Hey
> >>
> >>After looking at CordovaWebView code this morning, I have some concerns
> >>about the method that we're currently using in DroidGap to load the URL,
> >>namely this spinner that was added into the method.  I know that this was
> >>added last year, but I'm thinking that we should actually abstract out
> the
> >>indeterminate progress indicator.  In addition to that, this code is
> going
> >>to break on future versions of Android, because we're calling methods on
> >>WebView that should be called on the UIThread.
> >>
> >>So, what's the story with this spinner, does it have to be there, or can
> >>we
> >>rip it out? Should I create a ticket to do this?
> >>
> >>Joe
> >
>

--f46d044268e6d4dc6204bdd3b7b7--