Mailing-List: contact callback-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: callback-dev@incubator.apache.org
Received-SPF: pass (nike.apache.org: domain of purplecabbage@gmail.com
 designates 74.125.82.43 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CAE6O_-Y4O2OD+FaKpVYx5g86FcefMaK2TyoTRSpnphGDeNN-+Q@mail.gmail.com>
References: 
 <CADjNb+=PmPnDmu7nFg3=QyrnEKvPVUMF0uEZ2_cG-y5cwTGLVQ@mail.gmail.com>
	<CAE6O_-YhGDBMsjcM6C21mRT01bNNLXJ8xqrmZbp5MZp2VuwGRg@mail.gmail.com>
	<CADjNb+k7Tp4ps1T2-1r5b6q+fu0BheT05ACFu7YyWaNexNUgYw@mail.gmail.com>
	<CAE6O_-Y4O2OD+FaKpVYx5g86FcefMaK2TyoTRSpnphGDeNN-+Q@mail.gmail.com>
Date: Mon, 9 Apr 2012 11:19:46 -0700
Message-ID: 
 <CAKP6k2uwLzf-Coc2aj3KQnzrAqS1TV6fiFDc-LfNSGujXpmWGQ@mail.gmail.com>
Subject: Re: Advice for upgrading iOS plugins for 1.6?
From: Jesse <purplecabbage@gmail.com>
To: callback-dev@incubator.apache.org
Content-Type: multipart/alternative; boundary=f46d0444047a103fd504bd430dc7

--f46d0444047a103fd504bd430dc7
Content-Type: text/plain; charset=ISO-8859-1

My 'advice' would be, inside the closure that the plugin code 'should' be
wrapped in, the developer of the plugin writes something like :

var myCordovaRef = window.PhoneGap || window.Cordova || window.cordova;

No need to pollute the window with all the aliases it has ever had. The dev
just needs to find it ...

On Mon, Apr 9, 2012 at 11:14 AM, Shazron <shazron@gmail.com> wrote:

> That went away in 1.6.0 right? What would be the shim, would you know?
> Do you think that is only used by core or third party plugins as well
>
> On Mon, Apr 9, 2012 at 11:10 AM, Becky Gibson <gibson.becky@gmail.com>
> wrote:
> > We might want to consider something similar for Cordova.hasResource()
> >
> >
> > On Mon, Apr 9, 2012 at 1:52 PM, Shazron <shazron@gmail.com> wrote:
> >
> >> What about advice to add a shim like we already have for the PhoneGap
> >> object
> >>
> >> if (!window.Cordova) {
> >>    window.Cordova = cordova;
> >> }
> >>
> >> I should add this in the Cordova Plugin Upgrade Guide
> >>
> >>
> >> On Mon, Apr 9, 2012 at 7:07 AM, Becky Gibson <gibson.becky@gmail.com>
> >> wrote:
> >> > We created a new repository for iOS plugins that that have been
> updated
> >> to
> >> > Cordova (https://github.com/phonegap/phonegap-plugins/tree/master/iOS
> ).
> >> >  Now that 1.6 has changed the cordova object from Cordova (capital C)
> to
> >> > cordova (little c) do we have any advice for people updating /
> submitting
> >> > plugins to distinguish between 1.5 and 1.6?
> >>
>

--f46d0444047a103fd504bd430dc7--