Mailing-List: contact callback-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: callback-dev@incubator.apache.org
Received-SPF: pass (nike.apache.org: domain of shazron@gmail.com designates
 209.85.210.175 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CAOBL_k5fEoqZfpcuwLPQ0NbSJKesGFhReZ-m5TJzXzOemFfAhA@mail.gmail.com>
References: 
 <CAE6O_-Z3+qszzHMSPOdoYno_8XZGQOK+4QT4=it1QoF7_MKvLw@mail.gmail.com>
 <CBACA413.4208%fil@adobe.com>
 <CAE6O_-YzFs25-YNFsbVqiAOLgVc7PjdAdL+E98CTm8b1KYQLpA@mail.gmail.com>
 <CAOBL_k5fEoqZfpcuwLPQ0NbSJKesGFhReZ-m5TJzXzOemFfAhA@mail.gmail.com>
From: Shazron <shazron@gmail.com>
Date: Thu, 12 Apr 2012 15:37:32 -0700
Message-ID: 
 <CAE6O_-bBPTEV5EQew3yojtquLcU0_=-_TPRr0LzoRW6z1_reZw@mail.gmail.com>
Subject: Re: 1.6.1
To: callback-dev@incubator.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Then we have to scrap the other three(?) iOS parameters ones that
already exist in common if you noticed. Don't know how we merge
(unmerge?) this one properly because taking those out will break
everyone that is using it, but a deprecation is the way to go as per
http://wiki.apache.org/cordova/DeprecationPolicy . We can remove this
new commit and I'll find a way to get this in somehow.


On Thu, Apr 12, 2012 at 3:32 PM, Joe Bowser <bowserj@gmail.com> wrote:
> The problem is that this parameter doesn't belong in the common API. It'd
> be just ignored in Android, but the whole point of cordova-js is so that
> it's common. =A0It'd look pretty screwed up to add this to the docs, IMO.
>
> On Thu, Apr 12, 2012 at 3:26 PM, Shazron <shazron@gmail.com> wrote:
>
>> To fix two bugs for Camera.takePicture on iOS
>>
>> On Thu, Apr 12, 2012 at 3:24 PM, Filip Maj <fil@adobe.com> wrote:
>> > so what's the point of this new parameter?
>> >
>> > On 4/12/12 3:16 PM, "Shazron" <shazron@gmail.com> wrote:
>> >
>> >>I did. Do we want to revert the cordova-js? I can branch 1.6.0 and
>> >>cherry-pick your latest commit for 1.6.1
>> >>
>> >>On Thu, Apr 12, 2012 at 3:04 PM, Filip Maj <fil@adobe.com> wrote:
>> >>> I saw something in the iOS commit logs for this.
>> >>>
>> >>> Shaz can you comment?
>> >>>
>> >>> On 4/12/12 2:59 PM, "Joe Bowser" <bowserj@gmail.com> wrote:
>> >>>
>> >>>>Can we revert this, since this looks like it's intended for both
>> Android
>> >>>>and iOS, but I don't think it should be in 1.6.1.
>> >>>>
>> >>>>On Thu, Apr 12, 2012 at 2:52 PM, Filip Maj <fil@adobe.com> wrote:
>> >>>>
>> >>>>> I was actually just looking at that myself.
>> >>>>>
>> >>>>> Looks like it's an iOS-only param.. =A0sigh. We gotta stop doing t=
hat,
>> >>>>> especially if we don't update documentation.
>> >>>>>
>> >>>>> On 4/12/12 2:49 PM, "Joe Bowser" <bowserj@gmail.com> wrote:
>> >>>>>
>> >>>>> >Has anyone tested the cropToSize param for Camera.getPicture yet?=
 =A0I
>> >>>>> >didn't
>> >>>>> >notice that change until now.
>> >>>>> >
>> >>>>> >On Thu, Apr 12, 2012 at 2:46 PM, Filip Maj <fil@adobe.com> wrote:
>> >>>>> >
>> >>>>> >> JS tagged 1.6.1 - the build task in the JS should work properly
>> >>>>>now.
>> >>>>> >>
>> >>>>> >> FYI if anyone has to modify the jake tasks in the future and ma=
ke
>> >>>>>them
>> >>>>> >> async, make sure you add the 4th "async" parameter to the task(=
)
>> >>>>> >>function
>> >>>>> >> and set it to true, and call complete() when the task is done.
>> >>>>> >>
>> >>>>> >> See http://howtonode.org/intro-to-jake/async-jakefile.js for an
>> >>>>> example.
>> >>>>> >>
>> >>>>> >> On 4/12/12 2:35 PM, "Joe Bowser" <bowserj@gmail.com> wrote:
>> >>>>> >>
>> >>>>> >> >Ready to tag once cordova-js is tagged 1.6.1.
>> >>>>> >> >
>> >>>>> >> >On Thu, Apr 12, 2012 at 2:33 PM, Anis KADRI <
>> anis.kadri@gmail.com>
>> >>>>> >>wrote:
>> >>>>> >> >
>> >>>>> >> >> I will tag my repository to 1.6.1 before end of day today af=
ter
>> >>>>>some
>> >>>>> >> >> thorough testing.
>> >>>>> >> >>
>> >>>>> >> >> On Thu, Apr 12, 2012 at 2:30 PM, Shazron <shazron@gmail.com>
>> >>>>>wrote:
>> >>>>> >> >>
>> >>>>> >> >> > I also created a 1.6.1 version tag as well in jira...
>> >>>>> >> >> >
>> >>>>> >> >> > On Thu, Apr 12, 2012 at 2:29 PM, Shazron <shazron@gmail.co=
m>
>> >>>>> wrote:
>> >>>>> >> >> > > Alright guys since 1.6.0 was released, I'm going to
>> >>>>>"Release"
>> >>>>>the
>> >>>>> >> >> > > 1.6.0 version in jira and move outstanding issues to 1.7=
.0
>> >>>>> >>version
>> >>>>> >> >> > > tag.
>> >>>>> >> >> > >
>> >>>>> >> >> > >
>> >>>>> >> >> > > On Thu, Apr 12, 2012 at 2:26 PM, Filip Maj <fil@adobe.co=
m>
>> >>>>> wrote:
>> >>>>> >> >> > >> The JS needs patching too. Since adding the commit ID i=
nto
>> >>>>>the
>> >>>>> >> >> packaging
>> >>>>> >> >> > >> in the jakefile, the default task isn't running properl=
y.
>> >>>>> >> >> > >>
>> >>>>> >> >> > >> You can manually run "jake build" and "jake test" but n=
ot
>> >>>>> >>"jake" on
>> >>>>> >> >> its
>> >>>>> >> >> > >> own - gonna try to figure it out.
>> >>>>> >> >> > >>
>> >>>>> >> >> > >> On 4/12/12 2:21 PM, "Shazron" <shazron@gmail.com> wrote=
:
>> >>>>> >> >> > >>
>> >>>>> >> >> > >>>I'm good with tagging. =A0iOS has a few commits (one co=
mmit
>> >>>>>in
>> >>>>> >> >> > >>>cordova-js) as well. Aim for first thing tomorrow for y=
ou
>> >>>>>to
>> >>>>> >> >> > >>>repackage?
>> >>>>> >> >> > >>>
>> >>>>> >> >> > >>>On Thu, Apr 12, 2012 at 2:17 PM, Steven Gill
>> >>>>> >> >><stevengill97@gmail.com>
>> >>>>> >> >> > >>>wrote:
>> >>>>> >> >> > >>>> So a bug has been discovered in Cordova Android that
>> >>>>>requires
>> >>>>> >>a
>> >>>>> >> >>new
>> >>>>> >> >> > tag
>> >>>>> >> >> > >>>>and
>> >>>>> >> >> > >>>> release. You can check out the bug on the issue track=
er
>> >>>>>at
>> >>>>> >> >> > >>>>
>> >>>>> >> >> > >>>>
>> >>>>> >> >> >
>> >>>>> >> >>
>> >>>>> >> >>
>> >>>>> >>
>> >>>>> >>
>> >>>>>
>> >>>>>
>> https://issues.apache.org/jira/browse/CB-490?focusedCommentId=3D13252809=
#
>> >>>>>co
>> >>>>> >> >> > >>>>mment-13252809
>> >>>>> >> >> > >>>>
>> >>>>> >> >> > >>>> It doesn't make sense to just repackage 1.6.0 with th=
is
>> >>>>>bug
>> >>>>> >> >>fixed as
>> >>>>> >> >> > we
>> >>>>> >> >> > >>>> will have no way to know if people are experiencing t=
his
>> >>>>>or
>> >>>>> >>not.
>> >>>>> >> >> > >>>>
>> >>>>> >> >> > >>>> Anis mentioned Bada also had some major issues which =
he
>> >>>>>has
>> >>>>> >>fixed
>> >>>>> >> >> now
>> >>>>> >> >> > >>>>and
>> >>>>> >> >> > >>>> would like in a 1.6.1 release.
>> >>>>> >> >> > >>>>
>> >>>>> >> >> > >>>> Thoughts?
>> >>>>> >> >> > >>>>
>> >>>>> >> >> > >>>> -Steve
>> >>>>> >> >> > >>
>> >>>>> >> >> >
>> >>>>> >> >>
>> >>>>> >>
>> >>>>> >>
>> >>>>>
>> >>>>>
>> >>>
>> >
>>