Return-Path: 
 <callback-dev-return-5380-apmail-incubator-callback-dev-archive=incubator.apache.org@incubator.apache.org>
X-Original-To: apmail-incubator-callback-dev-archive@minotaur.apache.org
Delivered-To: apmail-incubator-callback-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 18C43919E
	for <apmail-incubator-callback-dev-archive@minotaur.apache.org>;
 Wed, 18 Apr 2012 17:01:08 +0000 (UTC)
Received: (qmail 83453 invoked by uid 500); 18 Apr 2012 17:01:07 -0000
Delivered-To: apmail-incubator-callback-dev-archive@incubator.apache.org
Received: (qmail 83424 invoked by uid 500); 18 Apr 2012 17:01:07 -0000
Mailing-List: contact callback-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:callback-dev-help@incubator.apache.org>
List-Unsubscribe: <mailto:callback-dev-unsubscribe@incubator.apache.org>
List-Post: <mailto:callback-dev@incubator.apache.org>
List-Id: <callback-dev.incubator.apache.org>
Reply-To: callback-dev@incubator.apache.org
Delivered-To: mailing list callback-dev@incubator.apache.org
Received: (qmail 83415 invoked by uid 99); 18 Apr 2012 17:01:07 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Apr 2012 17:01:07 +0000
X-ASF-Spam-Status: No, hits=-2000.0 required=5.0
	tests=ALL_TRUSTED,T_RP_MATCHES_RCVD
X-Spam-Check-By: apache.org
Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Apr 2012 17:01:02 +0000
Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116])
	by hel.zones.apache.org (Postfix) with ESMTP id 173083A1A1F
	for <callback-dev@incubator.apache.org>;
 Wed, 18 Apr 2012 17:00:41 +0000 (UTC)
Date: Wed, 18 Apr 2012 17:00:41 +0000 (UTC)
From: "Patrick Mueller (Commented) (JIRA)" <jira@apache.org>
To: callback-dev@incubator.apache.org
Message-ID: 
 <646758765.1421.1334768441096.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1317307982.35454.1334707993756.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (CB-532) Update JS module IDs and remove
 extraneous <platform> directory under lib/<platform>/plugin
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/CB-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256699#comment-13256699 ] 

Patrick Mueller commented on CB-532:
------------------------------------

If by "wordy" you mean, in our existing modules, things like this: [1]

{noformat}
polling = require('cordova/plugin/android/polling')
{noformat}

which happens to be called from the module with module id "cordva/plugin/android/callback".

There's a fix for that. [2]

The patch for [2] would allow you to replace the line above with:

{noformat}
polling = require('./polling')
{noformat}

I believe the only feedback received from this bug (musta been on the ml) was "we don't need that yet".  Do we need it yet?  :-)

I'm sure [2] will need a bit of re-work, it's a bit old, but I'm happy to land it, and then add the additional CommonJS tests into the mix as well.

[1] https://github.com/apache/incubator-cordova-js/blob/master/lib/android/plugin/android/callback.js#L4
[2] https://issues.apache.org/jira/browse/CB-272
                
> Update JS module IDs and remove extraneous <platform> directory under lib/<platform>/plugin
> -------------------------------------------------------------------------------------------
>
>                 Key: CB-532
>                 URL: https://issues.apache.org/jira/browse/CB-532
>             Project: Apache Callback
>          Issue Type: Task
>          Components: CordovaJS
>            Reporter: Filip Maj
>            Assignee: Filip Maj
>            Priority: Minor
>             Fix For: 1.8.0
>
>
> Unnecessary to have that extra dir - as long as the module IDs map to the module string in an obvious manner, that's all we want.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira