incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Bowser <bows...@gmail.com>
Subject Re: 1.6.1
Date Thu, 12 Apr 2012 22:21:27 GMT
git rebase -i HEAD~2

I can push up what I have and then we can go with that!

On Thu, Apr 12, 2012 at 3:16 PM, Shazron <shazron@gmail.com> wrote:

> I did. Do we want to revert the cordova-js? I can branch 1.6.0 and
> cherry-pick your latest commit for 1.6.1
>
> On Thu, Apr 12, 2012 at 3:04 PM, Filip Maj <fil@adobe.com> wrote:
> > I saw something in the iOS commit logs for this.
> >
> > Shaz can you comment?
> >
> > On 4/12/12 2:59 PM, "Joe Bowser" <bowserj@gmail.com> wrote:
> >
> >>Can we revert this, since this looks like it's intended for both Android
> >>and iOS, but I don't think it should be in 1.6.1.
> >>
> >>On Thu, Apr 12, 2012 at 2:52 PM, Filip Maj <fil@adobe.com> wrote:
> >>
> >>> I was actually just looking at that myself.
> >>>
> >>> Looks like it's an iOS-only param..  sigh. We gotta stop doing that,
> >>> especially if we don't update documentation.
> >>>
> >>> On 4/12/12 2:49 PM, "Joe Bowser" <bowserj@gmail.com> wrote:
> >>>
> >>> >Has anyone tested the cropToSize param for Camera.getPicture yet?  I
> >>> >didn't
> >>> >notice that change until now.
> >>> >
> >>> >On Thu, Apr 12, 2012 at 2:46 PM, Filip Maj <fil@adobe.com> wrote:
> >>> >
> >>> >> JS tagged 1.6.1 - the build task in the JS should work properly
now.
> >>> >>
> >>> >> FYI if anyone has to modify the jake tasks in the future and make
> >>>them
> >>> >> async, make sure you add the 4th "async" parameter to the task()
> >>> >>function
> >>> >> and set it to true, and call complete() when the task is done.
> >>> >>
> >>> >> See http://howtonode.org/intro-to-jake/async-jakefile.js for an
> >>> example.
> >>> >>
> >>> >> On 4/12/12 2:35 PM, "Joe Bowser" <bowserj@gmail.com> wrote:
> >>> >>
> >>> >> >Ready to tag once cordova-js is tagged 1.6.1.
> >>> >> >
> >>> >> >On Thu, Apr 12, 2012 at 2:33 PM, Anis KADRI <anis.kadri@gmail.com>
> >>> >>wrote:
> >>> >> >
> >>> >> >> I will tag my repository to 1.6.1 before end of day today
after
> >>>some
> >>> >> >> thorough testing.
> >>> >> >>
> >>> >> >> On Thu, Apr 12, 2012 at 2:30 PM, Shazron <shazron@gmail.com>
> >>>wrote:
> >>> >> >>
> >>> >> >> > I also created a 1.6.1 version tag as well in jira...
> >>> >> >> >
> >>> >> >> > On Thu, Apr 12, 2012 at 2:29 PM, Shazron <shazron@gmail.com>
> >>> wrote:
> >>> >> >> > > Alright guys since 1.6.0 was released, I'm going
to "Release"
> >>>the
> >>> >> >> > > 1.6.0 version in jira and move outstanding issues
to 1.7.0
> >>> >>version
> >>> >> >> > > tag.
> >>> >> >> > >
> >>> >> >> > >
> >>> >> >> > > On Thu, Apr 12, 2012 at 2:26 PM, Filip Maj <fil@adobe.com>
> >>> wrote:
> >>> >> >> > >> The JS needs patching too. Since adding
the commit ID into
> >>>the
> >>> >> >> packaging
> >>> >> >> > >> in the jakefile, the default task isn't
running properly.
> >>> >> >> > >>
> >>> >> >> > >> You can manually run "jake build" and "jake
test" but not
> >>> >>"jake" on
> >>> >> >> its
> >>> >> >> > >> own - gonna try to figure it out.
> >>> >> >> > >>
> >>> >> >> > >> On 4/12/12 2:21 PM, "Shazron" <shazron@gmail.com>
wrote:
> >>> >> >> > >>
> >>> >> >> > >>>I'm good with tagging.  iOS has a few
commits (one commit in
> >>> >> >> > >>>cordova-js) as well. Aim for first thing
tomorrow for you to
> >>> >> >> > >>>repackage?
> >>> >> >> > >>>
> >>> >> >> > >>>On Thu, Apr 12, 2012 at 2:17 PM, Steven
Gill
> >>> >> >><stevengill97@gmail.com>
> >>> >> >> > >>>wrote:
> >>> >> >> > >>>> So a bug has been discovered in
Cordova Android that
> >>>requires
> >>> >>a
> >>> >> >>new
> >>> >> >> > tag
> >>> >> >> > >>>>and
> >>> >> >> > >>>> release. You can check out the bug
on the issue tracker at
> >>> >> >> > >>>>
> >>> >> >> > >>>>
> >>> >> >> >
> >>> >> >>
> >>> >> >>
> >>> >>
> >>> >>
> >>>
> >>>
> https://issues.apache.org/jira/browse/CB-490?focusedCommentId=13252809#co
> >>> >> >> > >>>>mment-13252809
> >>> >> >> > >>>>
> >>> >> >> > >>>> It doesn't make sense to just repackage
1.6.0 with this
> bug
> >>> >> >>fixed as
> >>> >> >> > we
> >>> >> >> > >>>> will have no way to know if people
are experiencing this
> or
> >>> >>not.
> >>> >> >> > >>>>
> >>> >> >> > >>>> Anis mentioned Bada also had some
major issues which he
> has
> >>> >>fixed
> >>> >> >> now
> >>> >> >> > >>>>and
> >>> >> >> > >>>> would like in a 1.6.1 release.
> >>> >> >> > >>>>
> >>> >> >> > >>>> Thoughts?
> >>> >> >> > >>>>
> >>> >> >> > >>>> -Steve
> >>> >> >> > >>
> >>> >> >> >
> >>> >> >>
> >>> >>
> >>> >>
> >>>
> >>>
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message