incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Steven Gill <stevengil...@gmail.com>
Subject Re: JS: tagged 1.6.1
Date Wed, 18 Apr 2012 20:17:31 GMT
So you guys are suggesting making the changelog only show 1.6.1 to 1.6.0
changes and new blog post for 1.6.1?

I shall make it happen.


On Wed, Apr 18, 2012 at 1:06 PM, Shazron <shazron@gmail.com> wrote:

> New one. Why confuse users trying to hunt for 1.6.1 changes?
>
> On Wed, Apr 18, 2012 at 1:02 PM, Steven Gill <stevengill97@gmail.com>
> wrote:
> > yes, the changelog is still showing 1.6.1 to 1.5.0. For patches, that is
> > how I usually handle it. Even the blog post, I am planning to update the
> > 1.6.0 one instead of creating a new one for 1.6.1 because it is so minor.
> > Thoughts?
> >
> >
> >
> > On Wed, Apr 18, 2012 at 12:57 PM, Shazron <shazron@gmail.com> wrote:
> >
> >> No it's incorrect, clearly it's not a difference between 1.6.0 and
> >> 1.6.1 -- seems too large.
> >> https://github.com/phonegap/phonegap/blob/master/changelog
> >>
> >>
> >> On Wed, Apr 18, 2012 at 12:55 PM, Steven Gill <stevengill97@gmail.com>
> >> wrote:
> >> > The changelog is generated from the short log! I will add the iOS
> >> specific
> >> > ones to the blog post.
> >> >
> >> > If we want to start using the jira one instead, we should think about
> >> that
> >> > for 1.7
> >> >
> >> > -Steve
> >> >
> >> > On Wed, Apr 18, 2012 at 12:44 PM, Shazron <shazron@gmail.com> wrote:
> >> >
> >> >> yeah Steve :) I gave you the links for getting the Release Notes
> >> >>
> >> >> 2012/4/18 Filip Maj <fil@adobe.com>:
> >> >> > Is the change log updated?
> >> >> >
> >> >> > JIRA has a pretty nice change log feature/view/page thing
> >> >> >
> >> >> > On 4/18/12 12:39 PM, "Steven Gill" <stevengill97@gmail.com>
wrote:
> >> >> >
> >> >> >>Hey Guys,
> >> >> >>
> >> >> >>I have packaged 1.6.1. https://github.com/phonegap/phonegap.
Take
> a
> >> >> look.
> >> >> >>I
> >> >> >>am getting everything ready to go live on PhoneGap.com pretty
quick
> >> here.
> >> >> >>Anyone see any last minute issues?
> >> >> >>
> >> >> >>-Steve
> >> >> >>
> >> >> >>On Wed, Apr 18, 2012 at 11:24 AM, Shazron <shazron@gmail.com>
> wrote:
> >> >> >>
> >> >> >>> The tag is actually on the 1.6.1 branch, not master. I
had to
> branch
> >> >> >>> for 1.6.1 because there were commits on the mainline that
should
> not
> >> >> >>> be in 1.6.1 -- I had already started new dev on the mainline
> when we
> >> >> >>> decided to do 1.6.1
> >> >> >>>
> >> >> >>> On Wed, Apr 18, 2012 at 11:18 AM, Drew Walters <
> deedubbu@gmail.com>
> >> >> >>>wrote:
> >> >> >>> > If I look at the shortlog [1] it doesn't look like
the tag is
> >> >> >>> > associated to a commit.  Is that a glitch or is it
> unassociated?
> >> >> >>> >
> >> >> >>> > [1]
> >> >> >>>
> >> >> >>>
> >> >>
> >>
> http://git-wip-us.apache.org/repos/asf?p=incubator-cordova-ios.git;a=shor
> >> >> >>>tlog
> >> >> >>> >
> >> >> >>> > On Wed, Apr 18, 2012 at 1:12 PM, Shazron <shazron@gmail.com>
> >> wrote:
> >> >> >>> >> Drew, I see the 1.6.1 tag under the "tags" section
here?
> >> >> >>> >>
> >> >> >>>
> >> >> >>>
> >> >>
> >>
> http://git-wip-us.apache.org/repos/asf?p=incubator-cordova-ios.git;a=summ
> >> >> >>>ary
> >> >> >>> >>
> >> >> >>> >> On Wed, Apr 18, 2012 at 10:56 AM, Drew Walters
<
> >> deedubbu@gmail.com>
> >> >> >>> wrote:
> >> >> >>> >>> I noticed that Docs and iOS are not tagged
for 1.6.1.  Is
> there
> >> >> >>> something
> >> >> >>> >>> pending for those or should they be tagged.
 Curiously the
> >> github
> >> >> >>>repo
> >> >> >>> for
> >> >> >>> >>> iOS shows a 1.6.1 tag but the apache repo
does not.
> >> >> >>> >>>
> >> >> >>> >>> On Tue, Apr 17, 2012 at 5:20 PM, Steven Gill
> >> >> >>><stevengill97@gmail.com>
> >> >> >>> wrote:
> >> >> >>> >>>
> >> >> >>> >>>> Commencing tagging. No more fixes!
> >> >> >>> >>>>
> >> >> >>> >>>> On Tue, Apr 17, 2012 at 3:03 PM, Shazron
<shazron@gmail.com
> >
> >> >> wrote:
> >> >> >>> >>>>
> >> >> >>> >>>> > Fix inserted and re-tagged.
> >> >> >>> >>>> >
> >> >> >>> >>>> > 2012/4/17 Shazron <shazron@gmail.com>:
> >> >> >>> >>>> > > Going....
> >> >> >>> >>>> > >
> >> >> >>> >>>> > > 2012/4/17 Filip Maj <fil@adobe.com>:
> >> >> >>> >>>> > >> Steve's tagging so if he
hasn't started: gogo!
> >> >> >>> >>>> > >>
> >> >> >>> >>>> > >> On 4/17/12 2:42 PM, "Shazron"
<shazron@gmail.com>
> wrote:
> >> >> >>> >>>> > >>
> >> >> >>> >>>> > >>>Are we good to go or
can I sneak one fix in for 1.6.1
> >> >> >>> (Objective-C
> >> >> >>> >>>> > >>>only)?
> >> >> >>> >>>> > >>>
> >> >> >>> >>>> >
> >> >> >>> >>>>
> >> >> >>>
> >> >> >>>
> >> >>
> >>
> https://issues.apache.org/jira/browse/CB-330?focusedCommentId=13255975#co
> >> >> >>>m
> >> >> >>> >>>> > >>>ment-13255975
> >> >> >>> >>>> > >>>
> >> >> >>> >>>> > >>>This is in relation
to
> >> >> >>> https://issues.apache.org/jira/browse/CB-347
> >> >> >>> >>>> > >>>iOS 5 bug by Apple.
> >> >> >>> >>>> > >>>
> >> >> >>> >>>> > >>>On Tue, Apr 17, 2012
at 12:54 PM, Jesse
> >> >> >>><purplecabbage@gmail.com
> >> >> >>> >
> >> >> >>> >>>> > wrote:
> >> >> >>> >>>> > >>>> WP7 Tagged 1.6.1
and release packaged with cordova-js
> >> >> >>> >>>> > >>>> commit b2de4baa76a94ecb916619a536339ffee9ef6843
> >> >> >>> >>>> > >>>>
> >> >> >>> >>>> > >>>>
> >> >> >>> >>>> > >>>>
> >> >> >>> >>>> >
> >> >> >>> >>>>
> >> >> >>>
> >> >> >>>
> >> >>
> >>
> https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-wp7.git;a=com
> >> >> >>> >>>> > >>>>mit;h=a40a0ce645b82bd66dad6a36ab1d20ed150f34f0
> >> >> >>> >>>> > >>>>
> >> >> >>> >>>> > >>>>
> >> >> >>> >>>> > >>>>
> >> >> >>> >>>> > >>>>
> >> >> >>> >>>> > >>>> On Tue, Apr 17,
2012 at 12:40 PM, Filip Maj <
> >> fil@adobe.com
> >> >> >
> >> >> >>> wrote:
> >> >> >>> >>>> > >>>>
> >> >> >>> >>>> > >>>>> Yeh understood.
Don't want to retag 1.6.1 and have
> all
> >> >> >>>other
> >> >> >>> native
> >> >> >>> >>>> > >>>>> platforms update
as well just to change a '0' string
> >> to a
> >> >> >>>'1'.
> >> >> >>> >>>> > >>>>>
> >> >> >>> >>>> > >>>>> On 4/17/12
12:33 PM, "Drew Walters" <
> >> deedubbu@gmail.com>
> >> >> >>> wrote:
> >> >> >>> >>>> > >>>>>
> >> >> >>> >>>> > >>>>> >Hey Fil,
one minor thing, since the
> >> cordova.blackberry.js
> >> >> >>> file was
> >> >> >>> >>>> > not
> >> >> >>> >>>> > >>>>> >updated
it does not have the commit id which was
> >> added to
> >> >> >>> the file
> >> >> >>> >>>> > >>>>> >post 1.6.0.
> >> >> >>> >>>> > >>>>> >
> >> >> >>> >>>> > >>>>> >On Tue,
Apr 17, 2012 at 2:25 PM, Filip Maj <
> >> >> fil@adobe.com>
> >> >> >>> wrote:
> >> >> >>> >>>> > >>>>> >> Done.
> >> >> >>> >>>> > >>>>> >>
> >> >> >>> >>>> > >>>>> >> Forgot
that the blackberry playbook JS has a
> >> hard-coded
> >> >> >>> version
> >> >> >>> >>>> > >>>>>string
> >> >> >>> >>>> > >>>>> >>in
> >> >> >>> >>>> > >>>>> >> there҆
ugh. Just updated the copied-in
> >> >> >>>cordova.playbook.js
> >> >> >>> -
> >> >> >>> >>>> will
> >> >> >>> >>>> > >>>>>figure
> >> >> >>> >>>> > >>>>> >> out
a better way to avoid this in cordova-js for
> >> next
> >> >> >>> release.
> >> >> >>> >>>> > >>>>>(possibly
> >> >> >>> >>>> > >>>>> >> replacing
a string token in the playbook JS with
> the
> >> >> >>> contents of
> >> >> >>> >>>> > the
> >> >> >>> >>>> > >>>>> >> VERSION
file in the root of the cordova-js repo)
> >> >> >>> >>>> > >>>>> >>
> >> >> >>> >>>> > >>>>> >> On
4/17/12 11:54 AM, "Steven Gill"
> >> >> >>><stevengill97@gmail.com
> >> >> >>> >
> >> >> >>> >>>> > wrote:
> >> >> >>> >>>> > >>>>> >>
> >> >> >>> >>>> > >>>>> >>>blackberry?
> >> >> >>> >>>> > >>>>> >>>
> >> >> >>> >>>> > >>>>> >>>On
Mon, Apr 16, 2012 at 5:41 PM, Shazron <
> >> >> >>> shazron@gmail.com>
> >> >> >>> >>>> > wrote:
> >> >> >>> >>>> > >>>>> >>>
> >> >> >>> >>>> > >>>>> >>>>
iOS tested and tagged 1.6.1
> >> >> >>> >>>> > >>>>> >>>>
> >> >> >>> >>>> > >>>>> >>>>
On Mon, Apr 16, 2012 at 4:45 PM, Shazron <
> >> >> >>> shazron@gmail.com>
> >> >> >>> >>>> > >>>>>wrote:
> >> >> >>> >>>> > >>>>> >>>>
> Cool beans - will do that and re-test.
> Thanks!
> >> >> >>> >>>> > >>>>> >>>>
>
> >> >> >>> >>>> > >>>>> >>>>
> On Mon, Apr 16, 2012 at 4:46 PM, Filip Maj <
> >> >> >>> fil@adobe.com>
> >> >> >>> >>>> > >>>>>wrote:
> >> >> >>> >>>> > >>>>> >>>>
>> With respect to 1.6.1, I would change the
> >> native
> >> >> >>>side
> >> >> >>> on
> >> >> >>> >>>> iOS,
> >> >> >>> >>>> > >>>>>Shaz,
> >> >> >>> >>>> > >>>>> >>>>to
> >> >> >>> >>>> > >>>>> >>>>
>> call:
> >> >> >>> >>>> > >>>>> >>>>
>>
> >> >> >>> >>>> > >>>>> >>>>
>>
> >> >> cordova.require('cordova/channel').onResume.fire();
> >> >> >>> (or
> >> >> >>> >>>> > >>>>>onPause)
> >> >> >>> >>>> > >>>>> >>>>
>>
> >> >> >>> >>>> > >>>>> >>>>
>> Depending on what approach everyone thinks
> we
> >> >> >>>should
> >> >> >>> use
> >> >> >>> >>>> (the
> >> >> >>> >>>> > >>>>>first
> >> >> >>> >>>> > >>>>> >>>>or
> >> >> >>> >>>> > >>>>> >>>>
>> second of my suggestions below, or something
> >> else
> >> >> >>> entirely)
> >> >> >>> >>>> > we
> >> >> >>> >>>> > >>>>>can
> >> >> >>> >>>> > >>>>> >>>>slate
> >> >> >>> >>>> > >>>>> >>>>
>> that change for all platforms for 1.7.
> >> >> >>> >>>> > >>>>> >>>>
>>
> >> >> >>> >>>> > >>>>> >>>>
>> On 4/16/12 4:42 PM, "Filip Maj" <
> fil@adobe.com
> >> >
> >> >> >>> wrote:
> >> >> >>> >>>> > >>>>> >>>>
>>
> >> >> >>> >>>> > >>>>> >>>>
>>>I see the issue.
> >> >> >>> >>>> > >>>>> >>>>
>>>
> >> >> >>> >>>> > >>>>> >>>>
>>>fireDocumentEvent looks at the
> >> >> >>>documentEventHandlers
> >> >> >>> and
> >> >> >>> >>>> > >>>>>checks if
> >> >> >>> >>>> > >>>>> >>>>
>>>something exists in that object with the
> name
> >> of
> >> >> >>>the
> >> >> >>> event.
> >> >> >>> >>>> > We
> >> >> >>> >>>> > >>>>> >>>>never
> >> >> >>> >>>> > >>>>> >>>>
>>>actually register resume or pause channels
> with
> >> >> the
> >> >> >>> >>>> > >>>>> >>>>
>>>"documentEventHandlers" object, so calling
> >> >> >>> >>>> firedocumentevent
> >> >> >>> >>>> > >>>>>will
> >> >> >>> >>>> > >>>>> >>>>never
> >> >> >>> >>>> > >>>>> >>>>
>>>work.
> >> >> >>> >>>> > >>>>> >>>>
>>>
> >> >> >>> >>>> > >>>>> >>>>
>>>Android just requires the channel module
> >> directly
> >> >> >>>and
> >> >> >>> fires
> >> >> >>> >>>> > the
> >> >> >>> >>>> > >>>>> >>>>proper
> >> >> >>> >>>> > >>>>> >>>>
>>>onResume / onPause channels [1].
> >> >> >>> >>>> > >>>>> >>>>
>>>
> >> >> >>> >>>> > >>>>> >>>>
>>>This is implemented inconsistently. We
> should
> >> do
> >> >> >>> something
> >> >> >>> >>>> > one
> >> >> >>> >>>> > >>>>>way
> >> >> >>> >>>> > >>>>> >>>>and
> >> >> >>> >>>> > >>>>> >>>>
>>>stick to it. Either have:
> >> >> >>> >>>> > >>>>> >>>>
>>>
> >> >> >>> >>>> > >>>>> >>>>
>>>- cordova.js create the resume + pause
> channels
> >> >> and
> >> >> >>> >>>> register
> >> >> >>> >>>> > >>>>>them
> >> >> >>> >>>> > >>>>> >>>>using
> >> >> >>> >>>> > >>>>> >>>>
>>>the addDocumentEventHandler [2] method, and
> >> have
> >> >> >>> native
> >> >> >>> >>>> side
> >> >> >>> >>>> > >>>>>call
> >> >> >>> >>>> > >>>>> >>>>
>>>cordova.fireDocumentEvent, OR
> >> >> >>> >>>> > >>>>> >>>>
>>>- keep the manual creation of the
> pause/resume
> >> >> >>> channels
> >> >> >>> >>>> [3],
> >> >> >>> >>>> > >>>>>and
> >> >> >>> >>>> > >>>>> >>>>have
> >> >> >>> >>>> > >>>>> >>>>
>>>native call
> >> >> >>> cordova.require('corodva/channel').(onPause ||
> >> >> >>> >>>> > >>>>> >>>>
>>>onResume).fire()
> >> >> >>> >>>> > >>>>> >>>>
>>>
> >> >> >>> >>>> > >>>>> >>>>
>>>[1]
> >> >> >>> >>>> > >>>>> >>>>
>>>
> >> >> >>> >>>> > >>>>> >>>>
> >> >> >>> >>>> > >>>>> >>>>
> >> >> >>> >>>> > >>>>>
> >> >> >>> >>>> >
> >> >> >>>
> >> >>
> https://github.com/apache/incubator-cordova-android/blob/master/framewo
> >> >> >>> >>>> > >>>>> >>>>rk
> >> >> >>> >>>> > >>>>> >>>>/
> >> >> >>> >>>> > >>>>> >>>>
>>>s
> >> >> >>> >>>> > >>>>> >>>>
>>>rc/org/apache/cordova/DroidGap.java#L889
> >> >> >>> >>>> > >>>>> >>>>
>>>[2]
> >> >> >>> >>>> > >>>>> >>>>
>>>
> >> >> >>> >>>> > >>>>> >>>>
> >> >> >>> >>>> > >>>>>
> >> >> >>> >>>> > >>>>>>>>>
> >> >> >>> >>>> >
> >> >> >>>
> >> https://github.com/apache/incubator-cordova-js/blob/master/lib/cordo
> >> >> >>> >>>> > >>>>>>>>>va
> >> >> >>> >>>> > >>>>> .
> >> >> >>> >>>> > >>>>> >>>>js
> >> >> >>> >>>> > >>>>> >>>>#
> >> >> >>> >>>> > >>>>> >>>>
>>>L
> >> >> >>> >>>> > >>>>> >>>>
>>>94
> >> >> >>> >>>> > >>>>> >>>>
>>>[3]
> >> >> >>> >>>> > >>>>> >>>>
>>>
> >> >> >>> >>>> > >>>>> >>>>
> >> >> >>> >>>> > >>>>> >>>>
> >> >> >>> >>>> > >>>>>
> >> >> >>> >>>> >
> >> >> >>>
> >> >>
> https://github.com/apache/incubator-cordova-js/blob/master/lib/common/c
> >> >> >>> >>>> > >>>>> >>>>ha
> >> >> >>> >>>> > >>>>> >>>>n
> >> >> >>> >>>> > >>>>> >>>>
>>>n
> >> >> >>> >>>> > >>>>> >>>>
>>>el.js#L225-L229
> >> >> >>> >>>> > >>>>> >>>>
>>>
> >> >> >>> >>>> > >>>>> >>>>
>>>On 4/16/12 4:30 PM, "Shazron" <
> >> shazron@gmail.com>
> >> >> >>> wrote:
> >> >> >>> >>>> > >>>>> >>>>
>>>
> >> >> >>> >>>> > >>>>> >>>>
>>>>I'm failing two manual tests. Step 1 of
> >> >> >>> >>>> > >>>>> >>>>
>>>>
> http://wiki.apache.org/cordova/iOSManualTests-
> >> >> >>>I'm
> >> >> >>> not
> >> >> >>> >>>> > >>>>>getting
> >> >> >>> >>>> > >>>>> >>>>pause
> >> >> >>> >>>> > >>>>> >>>>
>>>>and resume events for some reason, but all
> >> other
> >> >> >>> events
> >> >> >>> >>>> are
> >> >> >>> >>>> > >>>>>fine.
> >> >> >>> >>>> > >>>>> >>>>
>>>>
> >> >> >>> >>>> > >>>>> >>>>
>>>>I've verified I'm getting the lifecycle
> >> events in
> >> >> >>> native,
> >> >> >>> >>>> > but
> >> >> >>> >>>> > >>>>>when
> >> >> >>> >>>> > >>>>> >>>>
>>>>calling to javascript
> >> >> >>> "cordova.fireDocumentEvent('pause')
> >> >> >>> >>>> "
> >> >> >>> >>>> > >>>>>and
> >> >> >>> >>>> > >>>>> >>>>
>>>>"cordova.fireDocumentEvent('resume') " -
> none
> >> of
> >> >> >>>the
> >> >> >>> my
> >> >> >>> >>>> > >>>>>callbacks
> >> >> >>> >>>> > >>>>> >>>>are
> >> >> >>> >>>> > >>>>> >>>>
>>>>receiving the event.
> >> >> >>> >>>> > >>>>> >>>>
>>>>
> >> >> >>> >>>> > >>>>> >>>>
>>>>Any clue? I see there are overrides for
> >> >> >>> >>>> > >>>>>document.addEventListener
> >> >> >>> >>>> > >>>>> >>>>that
> >> >> >>> >>>> > >>>>> >>>>
>>>>special-case these two events though, not
> sure
> >> >> >>>what's
> >> >> >>> >>>> going
> >> >> >>> >>>> > >>>>>on in
> >> >> >>> >>>> > >>>>> >>>>
>>>>there yet. Debugging.
> >> >> >>> >>>> > >>>>> >>>>
>>>>
> >> >> >>> >>>> > >>>>> >>>>
>>>>On Mon, Apr 16, 2012 at 3:20 PM, Joe Bowser
> >> >> >>> >>>> > >>>>><bowserj@gmail.com>
> >> >> >>> >>>> > >>>>> >>>>wrote:
> >> >> >>> >>>> > >>>>> >>>>
>>>>> Re-tagged Android at 1.6.1, somehow the
> JS
> >> was
> >> >> >>> already
> >> >> >>> >>>> > >>>>>changed.
> >> >> >>> >>>> > >>>>> >>>>
>>>>>Creepy!
> >> >> >>> >>>> > >>>>> >>>>
>>>>>
> >> >> >>> >>>> > >>>>> >>>>
>>>>> On Mon, Apr 16, 2012 at 3:09 PM, Filip
> Maj <
> >> >> >>> >>>> fil@adobe.com
> >> >> >>> >>>> > >
> >> >> >>> >>>> > >>>>> >>>>wrote:
> >> >> >>> >>>> > >>>>> >>>>
>>>>>
> >> >> >>> >>>> > >>>>> >>>>
>>>>>> Do what you need to do, team.
> >> >> >>> >>>> > >>>>> >>>>
>>>>>>
> >> >> >>> >>>> > >>>>> >>>>
>>>>>>
> >> >> >>> >>>> > >>>>> >>>>
>>>
> >> >> >>> >>>> > >>>>> >>>>
>>
> >> >> >>> >>>> > >>>>> >>>>
> >> >> >>> >>>> > >>>>> >>
> >> >> >>> >>>> > >>>>>
> >> >> >>> >>>> > >>>>>
> >> >> >>> >>>> > >>
> >> >> >>> >>>> >
> >> >> >>> >>>>
> >> >> >>>
> >> >> >
> >> >>
> >>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message