incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Shazron <shaz...@gmail.com>
Subject Re: [jira] [Resolved] (CB-442) FileTransfer download should not block the UI
Date Tue, 10 Apr 2012 16:29:15 GMT
Doesn't matter - reverting the whole feature. WIll go in 1.7.0

On Tue, Apr 10, 2012 at 9:16 AM, Marcus Wu <wum@bibliolabs.com> wrote:
> As in revert the download blocking fixes for 1.6.0? I don't think that will entirely
fix the issue as the callback casts are also causing problems with the 1.6.0 javascript.
>
> On Apr 10, 2012, at 11:59 AM, Shazron wrote:
>
>> I'll have to revert the change for 1.6.0
>>
>> On Tue, Apr 10, 2012 at 8:56 AM, Shazron <shazron@gmail.com> wrote:
>>> Re-open the issue
>>>
>>> On Tue, Apr 10, 2012 at 7:19 AM, Marcus Wu <wum@bibliolabs.com> wrote:
>>>> I've noticed some problems with my fix for this since I committed it. I noticed
two things.
>>>>
>>>> First, my error callbacks were never being called. This was because I didn't
realize the first time around that there is a different call for converting the error callback
string.
>>>> Second, the success callbacks were failing. I tracked this down to errors
in the success callback string due to the cast now being integrated into the success callback
code.
>>>>
>>>> I have some changes to properly call the error callbacks and to eliminate
the cast in calling the success callback for the download. I was about to create another pull
request when I realized that the upload code is also using a cast which appears to no longer
be valid (although I am not as familiar with this code as I am sure others are). Should I
go ahead and eliminate that upload cast before creating another pull request?
>>>>
>>>> Another question is does a ticket need to be created (or the original ticket
reopened) prior to creating a pull request?
>>>>
>>>> Thanks,
>>>> Marcus
>>>>
>>>> On Apr 6, 2012, at 6:16 PM, Shazron Abdullah (Resolved) (JIRA) wrote:
>>>>
>>>>>
>>>>>     [ https://issues.apache.org/jira/browse/CB-442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
>>>>>
>>>>> Shazron Abdullah resolved CB-442.
>>>>> ---------------------------------
>>>>>
>>>>>       Resolution: Fixed
>>>>>    Fix Version/s: 1.6.0
>>>>>
>>>>> Fix commit merged in (from Marcus Wu): http://git-wip-us.apache.org/repos/asf?p=incubator-cordova-ios.git;a=commit;h=2bf695b0bc7ec47e2ec1f40842035106811e35f2
>>>>>
>>>>>> FileTransfer download should not block the UI
>>>>>> ---------------------------------------------
>>>>>>
>>>>>>                Key: CB-442
>>>>>>                URL: https://issues.apache.org/jira/browse/CB-442
>>>>>>            Project: Apache Callback
>>>>>>         Issue Type: Bug
>>>>>>         Components: iOS
>>>>>>   Affects Versions: Master
>>>>>>           Reporter: Shazron Abdullah
>>>>>>           Assignee: Shazron Abdullah
>>>>>>            Fix For: 1.6.0
>>>>>>
>>>>>>        Attachments: CB-442-test.html
>>>>>>
>>>>>>
>>>>>> Right now the way it downloads items, it blocks the UI:
>>>>>> https://github.com/apache/incubator-cordova-ios/blob/master/CordovaLib/Classes/CDVFileTransfer.m#L167
>>>>>> NSData dataWithContentsOfUrl:
>>>>>> https://developer.apple.com/library/mac/#documentation/Cocoa/Reference/Foundation/Classes/NSData_Class/Reference/Reference.html
>>>>>> Change to an async download method.
>>>>>
>>>>> --
>>>>> This message is automatically generated by JIRA.
>>>>> If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
>>>>> For more information on JIRA, see: http://www.atlassian.com/software/jira
>>>>>
>>>>>
>>>>
>

Mime
View raw message