incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Shazron <shaz...@gmail.com>
Subject Re: JS: tagged 1.6.1
Date Tue, 17 Apr 2012 21:42:32 GMT
Are we good to go or can I sneak one fix in for 1.6.1 (Objective-C
only)? https://issues.apache.org/jira/browse/CB-330?focusedCommentId=13255975#comment-13255975

This is in relation to https://issues.apache.org/jira/browse/CB-347
iOS 5 bug by Apple.

On Tue, Apr 17, 2012 at 12:54 PM, Jesse <purplecabbage@gmail.com> wrote:
> WP7 Tagged 1.6.1 and release packaged with cordova-js
> commit b2de4baa76a94ecb916619a536339ffee9ef6843
>
> https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-wp7.git;a=commit;h=a40a0ce645b82bd66dad6a36ab1d20ed150f34f0
>
>
>
>
> On Tue, Apr 17, 2012 at 12:40 PM, Filip Maj <fil@adobe.com> wrote:
>
>> Yeh understood. Don't want to retag 1.6.1 and have all other native
>> platforms update as well just to change a '0' string to a '1'.
>>
>> On 4/17/12 12:33 PM, "Drew Walters" <deedubbu@gmail.com> wrote:
>>
>> >Hey Fil, one minor thing, since the cordova.blackberry.js file was not
>> >updated it does not have the commit id which was added to the file
>> >post 1.6.0.
>> >
>> >On Tue, Apr 17, 2012 at 2:25 PM, Filip Maj <fil@adobe.com> wrote:
>> >> Done.
>> >>
>> >> Forgot that the blackberry playbook JS has a hard-coded version string
>> >>in
>> >> there҆ ugh. Just updated the copied-in cordova.playbook.js - will figure
>> >> out a better way to avoid this in cordova-js for next release. (possibly
>> >> replacing a string token in the playbook JS with the contents of the
>> >> VERSION file in the root of the cordova-js repo)
>> >>
>> >> On 4/17/12 11:54 AM, "Steven Gill" <stevengill97@gmail.com> wrote:
>> >>
>> >>>blackberry?
>> >>>
>> >>>On Mon, Apr 16, 2012 at 5:41 PM, Shazron <shazron@gmail.com> wrote:
>> >>>
>> >>>> iOS tested and tagged 1.6.1
>> >>>>
>> >>>> On Mon, Apr 16, 2012 at 4:45 PM, Shazron <shazron@gmail.com>
wrote:
>> >>>> > Cool beans - will do that and re-test. Thanks!
>> >>>> >
>> >>>> > On Mon, Apr 16, 2012 at 4:46 PM, Filip Maj <fil@adobe.com>
wrote:
>> >>>> >> With respect to 1.6.1, I would change the native side on
iOS, Shaz,
>> >>>>to
>> >>>> >> call:
>> >>>> >>
>> >>>> >> cordova.require('cordova/channel').onResume.fire(); (or
onPause)
>> >>>> >>
>> >>>> >> Depending on what approach everyone thinks we should use
(the first
>> >>>>or
>> >>>> >> second of my suggestions below, or something else entirely)
we can
>> >>>>slate
>> >>>> >> that change for all platforms for 1.7.
>> >>>> >>
>> >>>> >> On 4/16/12 4:42 PM, "Filip Maj" <fil@adobe.com> wrote:
>> >>>> >>
>> >>>> >>>I see the issue.
>> >>>> >>>
>> >>>> >>>fireDocumentEvent looks at the documentEventHandlers
and checks if
>> >>>> >>>something exists in that object with the name of the
event. We
>> >>>>never
>> >>>> >>>actually register resume or pause channels with the
>> >>>> >>>"documentEventHandlers" object, so calling firedocumentevent
will
>> >>>>never
>> >>>> >>>work.
>> >>>> >>>
>> >>>> >>>Android just requires the channel module directly and
fires the
>> >>>>proper
>> >>>> >>>onResume / onPause channels [1].
>> >>>> >>>
>> >>>> >>>This is implemented inconsistently. We should do something
one way
>> >>>>and
>> >>>> >>>stick to it. Either have:
>> >>>> >>>
>> >>>> >>>- cordova.js create the resume + pause channels and
register them
>> >>>>using
>> >>>> >>>the addDocumentEventHandler [2] method, and have native
side call
>> >>>> >>>cordova.fireDocumentEvent, OR
>> >>>> >>>- keep the manual creation of the pause/resume channels
[3], and
>> >>>>have
>> >>>> >>>native call cordova.require('corodva/channel').(onPause
||
>> >>>> >>>onResume).fire()
>> >>>> >>>
>> >>>> >>>[1]
>> >>>> >>>
>> >>>>
>> >>>>
>> https://github.com/apache/incubator-cordova-android/blob/master/framewo
>> >>>>rk
>> >>>>/
>> >>>> >>>s
>> >>>> >>>rc/org/apache/cordova/DroidGap.java#L889
>> >>>> >>>[2]
>> >>>> >>>
>> >>>>
>> >>>>https://github.com/apache/incubator-cordova-js/blob/master/lib/cordova
>> .
>> >>>>js
>> >>>>#
>> >>>> >>>L
>> >>>> >>>94
>> >>>> >>>[3]
>> >>>> >>>
>> >>>>
>> >>>>
>> https://github.com/apache/incubator-cordova-js/blob/master/lib/common/c
>> >>>>ha
>> >>>>n
>> >>>> >>>n
>> >>>> >>>el.js#L225-L229
>> >>>> >>>
>> >>>> >>>On 4/16/12 4:30 PM, "Shazron" <shazron@gmail.com>
wrote:
>> >>>> >>>
>> >>>> >>>>I'm failing two manual tests. Step 1 of
>> >>>> >>>>http://wiki.apache.org/cordova/iOSManualTests -
I'm not getting
>> >>>>pause
>> >>>> >>>>and resume events for some reason, but all other
events are fine.
>> >>>> >>>>
>> >>>> >>>>I've verified I'm getting the lifecycle events in
native, but when
>> >>>> >>>>calling to javascript "cordova.fireDocumentEvent('pause')
" and
>> >>>> >>>>"cordova.fireDocumentEvent('resume') " - none of
the my callbacks
>> >>>>are
>> >>>> >>>>receiving the event.
>> >>>> >>>>
>> >>>> >>>>Any clue? I see there are overrides for document.addEventListener
>> >>>>that
>> >>>> >>>>special-case these two events though, not sure what's
going on in
>> >>>> >>>>there yet. Debugging.
>> >>>> >>>>
>> >>>> >>>>On Mon, Apr 16, 2012 at 3:20 PM, Joe Bowser <bowserj@gmail.com>
>> >>>>wrote:
>> >>>> >>>>> Re-tagged Android at 1.6.1, somehow the JS
was already changed.
>> >>>> >>>>>Creepy!
>> >>>> >>>>>
>> >>>> >>>>> On Mon, Apr 16, 2012 at 3:09 PM, Filip Maj
<fil@adobe.com>
>> >>>>wrote:
>> >>>> >>>>>
>> >>>> >>>>>> Do what you need to do, team.
>> >>>> >>>>>>
>> >>>> >>>>>>
>> >>>> >>>
>> >>>> >>
>> >>>>
>> >>
>>
>>

Mime
View raw message