incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Marcus Wu <...@bibliolabs.com>
Subject Re: [jira] [Created] (CB-475) FileTransfer js callbacks not working in 1.6.0
Date Tue, 10 Apr 2012 19:14:35 GMT
Alright, that works. I would like to point out that for downloads right now the success callback
is always being run. Take a look at this if you have a moment: https://github.com/marcuswu/incubator-cordova-ios/compare/CB-475

The issue was that there were a couple of error conditions I handled properly in connectionDidFinishLoading
while creating the result, but at the bottom of the routine I always wrote the javascript
with toSuccessCallbackString. The changes referenced above make it run toErrorCallbackString
when it is proper to do so.

On Apr 10, 2012, at 3:05 PM, Shazron wrote:

> Thanks Marcus - I've already fixed it, I'm just working out a crash
> bug in uploads which is inconsistent sometimes it happens sometime it
> doesnt (Xcode is being wonky)
> 
> On Tue, Apr 10, 2012 at 12:03 PM, Marcus Wu <wum@bibliolabs.com> wrote:
>> Shazron,
>> 
>> I have some code in a branch that removes the cast references from FileTransfer.
It works for the download, but I don't have code handy to test uploads. Shall I create a pull
request?
>> 
>> Thanks,
>> Marcus
>> 
>> On Apr 10, 2012, at 1:49 PM, Shazron Abdullah (Created) (JIRA) wrote:
>> 
>>> FileTransfer js callbacks not working in 1.6.0
>>> ----------------------------------------------
>>> 
>>>                 Key: CB-475
>>>                 URL: https://issues.apache.org/jira/browse/CB-475
>>>             Project: Apache Callback
>>>          Issue Type: Bug
>>>          Components: iOS
>>>            Reporter: Shazron Abdullah
>>>            Assignee: Shazron Abdullah
>>>            Priority: Blocker
>>> 
>>> 
>>> The callbacks are still using the old cast style. Remove.
>>> 
>>> --
>>> This message is automatically generated by JIRA.
>>> If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
>>> For more information on JIRA, see: http://www.atlassian.com/software/jira
>>> 
>>> 
>> 


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message