incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Patrick Mueller (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-605) Running a build modifies every file in lib
Date Mon, 30 Apr 2012 16:23:49 GMT

    [ https://issues.apache.org/jira/browse/CB-605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13265007#comment-13265007
] 

Patrick Mueller commented on CB-605:
------------------------------------

Do it.

The only inefficiency is that we're holding multiple copies of the source in memory.  For
the lifetime of the build.  Which is very short.  So who cares.

I believe if you look at the build process, I'm already caching all the files there as well
- I do this because we reuse most of the modules (common) for most of the builds, so it shaves
a huge percent off the 10ms build (per platform) to cache :-) . No one has complained about
that.

I'm not sure I even want it written out; error message generated?  Shore.  But having the
build rewrite the source seems ... wrong.  If we want to change to just generating an error
message, then we should add another task that makes the fixes to files that need the fixes,
since folks may not know how to make the fixes, or more likely, it will be a pain in the rear
to find all of them and fix them.
                
> Running a build modifies every file in lib
> ------------------------------------------
>
>                 Key: CB-605
>                 URL: https://issues.apache.org/jira/browse/CB-605
>             Project: Apache Callback
>          Issue Type: Bug
>          Components: CordovaJS
>    Affects Versions: 1.7.0
>            Reporter: Drew Walters
>            Priority: Trivial
>             Fix For: 1.7.0
>
>
> The build process (Jakefile) was enhanced to automatically enforce some style guidelines
on files in the lib folder. Every file is rewritten regardless of whether a change was made
or not. Currently, this is causing the modification date to change on every file in lib every
time a build is performed. This causes some development tools to assume the file has changed
when it may not have.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message