incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Patrick Mueller (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-532) Update JS module IDs and remove extraneous <platform> directory under lib/<platform>/plugin
Date Wed, 18 Apr 2012 17:00:41 GMT

    [ https://issues.apache.org/jira/browse/CB-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256699#comment-13256699
] 

Patrick Mueller commented on CB-532:
------------------------------------

If by "wordy" you mean, in our existing modules, things like this: [1]

{noformat}
polling = require('cordova/plugin/android/polling')
{noformat}

which happens to be called from the module with module id "cordva/plugin/android/callback".

There's a fix for that. [2]

The patch for [2] would allow you to replace the line above with:

{noformat}
polling = require('./polling')
{noformat}

I believe the only feedback received from this bug (musta been on the ml) was "we don't need
that yet".  Do we need it yet?  :-)

I'm sure [2] will need a bit of re-work, it's a bit old, but I'm happy to land it, and then
add the additional CommonJS tests into the mix as well.

[1] https://github.com/apache/incubator-cordova-js/blob/master/lib/android/plugin/android/callback.js#L4
[2] https://issues.apache.org/jira/browse/CB-272
                
> Update JS module IDs and remove extraneous <platform> directory under lib/<platform>/plugin
> -------------------------------------------------------------------------------------------
>
>                 Key: CB-532
>                 URL: https://issues.apache.org/jira/browse/CB-532
>             Project: Apache Callback
>          Issue Type: Task
>          Components: CordovaJS
>            Reporter: Filip Maj
>            Assignee: Filip Maj
>            Priority: Minor
>             Fix For: 1.8.0
>
>
> Unnecessary to have that extra dir - as long as the module IDs map to the module string
in an obvious manner, that's all we want.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message