Return-Path: X-Original-To: apmail-incubator-callback-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-callback-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 87C5395C5 for ; Fri, 9 Mar 2012 19:07:40 +0000 (UTC) Received: (qmail 88147 invoked by uid 500); 9 Mar 2012 19:07:40 -0000 Delivered-To: apmail-incubator-callback-dev-archive@incubator.apache.org Received: (qmail 88117 invoked by uid 500); 9 Mar 2012 19:07:40 -0000 Mailing-List: contact callback-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: callback-dev@incubator.apache.org Delivered-To: mailing list callback-dev@incubator.apache.org Received: (qmail 88109 invoked by uid 99); 9 Mar 2012 19:07:40 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Mar 2012 19:07:40 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of bowserj@gmail.com designates 209.85.215.47 as permitted sender) Received: from [209.85.215.47] (HELO mail-lpp01m010-f47.google.com) (209.85.215.47) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Mar 2012 19:07:35 +0000 Received: by lagw12 with SMTP id w12so2053376lag.6 for ; Fri, 09 Mar 2012 11:07:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=bn47aGWMDcw+hpHvdVCcuIRGUT+vic4eXT73nEgDC5Y=; b=M4P3Z/I8sgiA4PzEsWfbEoVHWIatqPV8dZfr5vY8IiMlfqqoTQI1FWSRdi0Y/TQ9VC p25aQ8DAMXhVuryP2Ab/1Uh7wvqFS8/b0Dzg13x2SVs6F0YRVwnCEIWH7Yr3N1O0CSE2 IIrRJj4uB24nBVkPJXLqt4gjacfCv2xv2fnlQwYqV2cHUzKIoPt/VyxRaEwQVtY2LxYW 6XdHc+BtB6jX8dPcyvgPJYvQqIgQcUTd8guTdTJvZ4H2L5eGQyxEnyVxbJGzJXu1QaOs s4WxmMInrZX49aPYZOuOqNg3YTrhFh5ehrRXwBKaK3b3aQwizni7mYAbdPznKf9wx08q 3PJg== MIME-Version: 1.0 Received: by 10.112.37.40 with SMTP id v8mr514809lbj.8.1331320033946; Fri, 09 Mar 2012 11:07:13 -0800 (PST) Received: by 10.152.28.226 with HTTP; Fri, 9 Mar 2012 11:07:13 -0800 (PST) In-Reply-To: References: Date: Fri, 9 Mar 2012 11:07:13 -0800 Message-ID: Subject: Re: [Android] JS files in repo under framework/assets/js From: Joe Bowser To: callback-dev@incubator.apache.org Content-Type: multipart/alternative; boundary=485b390f79eab4abfa04bad41902 X-Virus-Checked: Checked by ClamAV on apache.org --485b390f79eab4abfa04bad41902 Content-Type: text/plain; charset=ISO-8859-1 None here. Go for it! On Fri, Mar 9, 2012 at 11:05 AM, Filip Maj wrote: > Any objections to me removing all of the old JS files in the repo [1] > except for the cordova-js script file? > > Also, I wanted to clean up the build file. Specifically, the old "check > javascript" target is completely commented out [2], and the old "build > javascript" target has a bunch of commented out stuff [3], [4], [5]. > > P.S. I'll be updating both the android and JS repos with a fix for issue > 304 [6], where our "require" + "define" implementations leak into global > scope and apparently break some frameworks like Dojo. > > [1] > https://github.com/apache/incubator-cordova-android/tree/master/framework/assets/js > [2] > https://github.com/apache/incubator-cordova-android/blob/master/framework/build.xml#L112-L143 > [3] > https://github.com/apache/incubator-cordova-android/blob/master/framework/build.xml#L149 > [4] > https://github.com/apache/incubator-cordova-android/blob/master/framework/build.xml#L155 > [5] > https://github.com/apache/incubator-cordova-android/blob/master/framework/build.xml#L171 > [6] https://issues.apache.org/jira/browse/CB-304 > --485b390f79eab4abfa04bad41902--