Return-Path: X-Original-To: apmail-incubator-callback-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-callback-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2BFD79111 for ; Thu, 29 Mar 2012 12:58:46 +0000 (UTC) Received: (qmail 85027 invoked by uid 500); 29 Mar 2012 12:58:46 -0000 Delivered-To: apmail-incubator-callback-dev-archive@incubator.apache.org Received: (qmail 84976 invoked by uid 500); 29 Mar 2012 12:58:46 -0000 Mailing-List: contact callback-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: callback-dev@incubator.apache.org Delivered-To: mailing list callback-dev@incubator.apache.org Received: (qmail 84968 invoked by uid 99); 29 Mar 2012 12:58:46 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 29 Mar 2012 12:58:46 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 29 Mar 2012 12:58:45 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id DA7D734C3B2 for ; Thu, 29 Mar 2012 12:58:24 +0000 (UTC) Date: Thu, 29 Mar 2012 12:58:24 +0000 (UTC) From: "Patrick Mueller (Commented) (JIRA)" To: callback-dev@incubator.apache.org Message-ID: <1243511103.32334.1333025904946.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <571242484.19852.1332798867092.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (CB-387) try/catch wrapper in native iOS code for cordova-js initialization firing alerts when page without cordova.js is loaded in MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/CB-387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241196#comment-13241196 ] Patrick Mueller commented on CB-387: ------------------------------------ After thinking about this for 5 more seconds, there's a chicken-and-egg problem with expecting a {{cordova}} global (got the case right this time) to be available, when it's not available :-) Doesn't mean a consistent logging story used throughout Cordova isn't a bad thing, and I'll open a separate JIRA feature request on that. It also doesn't mean we can take advantage of that, somehow, in this case. For instance, it's possible we could design some kind of 'logger' module which could be used as a plain old module with {{require()}} (and/or attached to {{cordova}}) *AND* > try/catch wrapper in native iOS code for cordova-js initialization firing alerts when page without cordova.js is loaded in > -------------------------------------------------------------------------------------------------------------------------- > > Key: CB-387 > URL: https://issues.apache.org/jira/browse/CB-387 > Project: Apache Callback > Issue Type: Bug > Components: iOS > Affects Versions: 1.6.0 > Environment: 1.6.0rc1 <--- FYI!! > Reporter: Filip Maj > Assignee: Shazron Abdullah > Priority: Blocker > Fix For: 1.6.0 > > > Originally authored by code I wrote! My bad! > See line 370 of CDVViewController.m: > {code} > NSMutableString *result = [[NSMutableString alloc] initWithFormat:@"try{require('cordova/plugin/ios/device').setInfo(%@);}catch(e){alert('errorz1!!!');alert(JSON.stringify(e))}", [deviceProperties JSONString]]; > {code} > We should have a graceful way of degrading this, perhaps run a console.log instead? Suggestions? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira