incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Becky Gibson <gibson.be...@gmail.com>
Subject Pull request for updated contacts tests
Date Fri, 02 Mar 2012 22:33:51 GMT
I've updated the contacts test to test saving, updating and removing a
contact.  This also check for proper treatment of dates. These tests run on
the current iOS implementation.  I'd like to have it tested on other
implementations before I commit.   Here is the pull request against the
github repo:
https://github.com/apache/incubator-cordova-mobile-spec/pull/1

Pull Request comments:

Added tests to save, update and remove a contact.

Save and update verify Date is saved, updated and retrieved properly. Test
modifying a note, removing an email address.

These new tests work with the current iOS implementation. NOTE - these
tests now ADD and REMOVE a contact. You may want to run on a simulator
first so you don't risk losing contacts from an actual device!!!! Also, the
test to remove an invalid contact uses and id of 999 (it was previously 99
and I made it larger since I think it is conceivable that a device could
have a valid contact with id 99). I think even 999 is risky since different
devices may use different conventions for assigning ids. There is now a
test that uses an id for a contact that was removed to verify that trying
to remove a contact with an invalid ID returns the proper error. As long as
the remove works, this test should be valid and we could get rid of the
removal test with the arbitrary id of 999.

Please test and let me know of any issues before I commit.

These contacts tests could be HUGE in order to test all of the permutations
for contacts. There are other plugins that could use more testing love as
well.  Not sure if we want to make the automated tests that large?

thanks,

-becky

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message