incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Filip Maj (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-364) remove calls to alert()
Date Mon, 26 Mar 2012 00:40:26 GMT

    [ https://issues.apache.org/jira/browse/CB-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238021#comment-13238021
] 

Filip Maj commented on CB-364:
------------------------------

Actually fixed in [c10b80|https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-js.git;a=commit;h=c10b80eaf886a704fb144019bd869ea8962777bd].
                
> remove calls to alert()
> -----------------------
>
>                 Key: CB-364
>                 URL: https://issues.apache.org/jira/browse/CB-364
>             Project: Apache Callback
>          Issue Type: Bug
>          Components: CordovaJS
>            Reporter: Patrick Mueller
>            Assignee: Filip Maj
>             Fix For: 1.6.0
>
>
> I've run into some cases of alert() usage in the cordova-js code.  I think this is inappropriate,
since we are using the cordova-js code in other environments than the browser, like the test
harness.  I end up seeing errors thrown on "alert() not defined" and such, which is masking
the actual error from me.
> Instead, we should define an alert()-y function somewhere - like cordova.alert().  This
function can sniff if alert() is available, and if not, console.log() or the equivalent.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message