incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Patrick Mueller (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-387) try/catch wrapper in native iOS code for cordova-js initialization firing alerts when page without cordova.js is loaded in
Date Thu, 29 Mar 2012 13:44:29 GMT

    [ https://issues.apache.org/jira/browse/CB-387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241221#comment-13241221
] 

Patrick Mueller commented on CB-387:
------------------------------------

There's already a bug open on ["improve the console object"|https://issues.apache.org/jira/browse/CB-348],
and I think the things I've described in the comments above are a good fit for that bug. 


At this point, I think I'd just like to see more user-friendly messages (like hinting the
user may not have included {{cordova-x.y.z.js}} in their .html file), in the current little
wad of goo we have here.  If something comes of the "improve the console" bug, I'll open a
new set of bugs indicating how this wad of goo can further improved.
                
> try/catch wrapper in native iOS code for cordova-js initialization firing alerts when
page without cordova.js is loaded in
> --------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CB-387
>                 URL: https://issues.apache.org/jira/browse/CB-387
>             Project: Apache Callback
>          Issue Type: Bug
>          Components: iOS
>    Affects Versions: 1.6.0
>         Environment: 1.6.0rc1 <--- FYI!!
>            Reporter: Filip Maj
>            Assignee: Shazron Abdullah
>            Priority: Blocker
>             Fix For: 1.6.0
>
>
> Originally authored by code I wrote! My bad!
> See line 370 of CDVViewController.m: 
> {code}
> NSMutableString *result = [[NSMutableString alloc] initWithFormat:@"try{require('cordova/plugin/ios/device').setInfo(%@);}catch(e){alert('errorz1!!!');alert(JSON.stringify(e))}",
[deviceProperties JSONString]];
> {code}
> We should have a graceful way of degrading this, perhaps run a console.log instead? Suggestions?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message