incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gtan...@gmail.com
Subject Re: [jira] [Commented] (CB-304) Cordova's require/define can't be used with Dojo's require/define
Date Fri, 09 Mar 2012 02:36:23 GMT
I think with some builder sugaring magic we can have the best of both worlds.

Ie.. Cordova.require for native and require for everyone else.

All the modules should be fine with require, the only place we would need to update would
be the injection of the bootstrap.js file.
Sent on the TELUS Mobility network with BlackBerry

-----Original Message-----
From: "Patrick Mueller (Commented) (JIRA)" <jira@apache.org>
Date: Fri, 9 Mar 2012 02:31:57 
To: <callback-dev@incubator.apache.org>
Reply-To: callback-dev@incubator.apache.org
Subject: [jira] [Commented] (CB-304) Cordova's require/define can't be used
 with Dojo's require/define


    [ https://issues.apache.org/jira/browse/CB-304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225795#comment-13225795
] 

Patrick Mueller commented on CB-304:
------------------------------------

Having to hang {{require}} off of {{Cordova}} is believable for the reason you mention.

I will note, again, that we need to make sure folks don't start using that {{require()}} instead
of the {{require()}} they are passed (if they're in a module), as that won't resolve relative
module ids correctly (when we implement that).

So, I'd recommend we not actually call it {{require}} there.  {{rootRequire}}, {{requireRoot}},
{{baseRequire}}, etc come to mind as alternatives.
                
> Cordova's require/define can't be used with Dojo's require/define
> -----------------------------------------------------------------
>
>                 Key: CB-304
>                 URL: https://issues.apache.org/jira/browse/CB-304
>             Project: Apache Callback
>          Issue Type: Bug
>          Components: Android, CordovaJS
>            Reporter: Patrick Mueller
>            Assignee: Filip Maj
>
> summarized from https://groups.google.com/d/topic/phonegap/D1cm3kQzKJ0/discussion
> {quote}
> I was targeting Android and used Phonegap 1.2.0 in combination with Dojo 1.7 which worked
fine. Now I switched to Phonegap 1.5.0 and found a severe problem. The new module system in
Phonegap 1.5.0 uses global functions "define" and "require". Dojo 1.7 does the same for its
own module system. Hence, whatever is loaded first, breaks the other one. 
> Could the Phonegap developers consider to modify the module system in a way that it is
compatible with Dojo's? 
> {quote}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        
Mime
View raw message