incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jesse MacFadyen <purplecabb...@gmail.com>
Subject Re: [jira] [Updated] (CB-304) Cordova's require/define can't be used with Dojo's require/define
Date Fri, 09 Mar 2012 18:10:19 GMT
I don't think we should require require from native. My 2¥

Cheers,
  Jesse

Sent from my iPhone5

On 2012-03-08, at 6:04 PM, "Filip Maj (Updated) (JIRA)" <jira@apache.org> wrote:

>
>     [ https://issues.apache.org/jira/browse/CB-304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
>
> Filip Maj updated CB-304:
> -------------------------
>
>    Component/s: Android
>
> I've made changes to cordova-js and [pushed up to a branch on my fork|https://github.com/filmaj/incubator-cordova-js/commit/e75bcca3dfccd756fc05be268f23359b44dfb9a6].
To go along with those, I also [pushed needed changes to a branch on my fork of the android
implementation|https://github.com/filmaj/incubator-cordova-android/commit/b4292868eb2b50ec5cbe777ae74f24994da5e2d5].
>
> Turns out we need to hang at least {{require}} off of the {{cordova}} object. Otherwise,
the native side can't get a reference to any of the plugins' JavaScript (if we hide away {{require}},
then we can't call {{require}} from native :) ).
>
> Make sense? I think posting this to mailing list makes sense too...
>
>> Cordova's require/define can't be used with Dojo's require/define
>> -----------------------------------------------------------------
>>
>>                Key: CB-304
>>                URL: https://issues.apache.org/jira/browse/CB-304
>>            Project: Apache Callback
>>         Issue Type: Bug
>>         Components: Android, CordovaJS
>>           Reporter: Patrick Mueller
>>           Assignee: Filip Maj
>>
>> summarized from https://groups.google.com/d/topic/phonegap/D1cm3kQzKJ0/discussion
>> {quote}
>> I was targeting Android and used Phonegap 1.2.0 in combination with Dojo 1.7 which
worked fine. Now I switched to Phonegap 1.5.0 and found a severe problem. The new module system
in Phonegap 1.5.0 uses global functions "define" and "require". Dojo 1.7 does the same for
its own module system. Hence, whatever is loaded first, breaks the other one.
>> Could the Phonegap developers consider to modify the module system in a way that
it is compatible with Dojo's?
>> {quote}
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>

Mime
View raw message