incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Filip Maj <...@adobe.com>
Subject Re: Changes to File API
Date Wed, 22 Feb 2012 18:01:21 GMT
+1 to taking it out - not even exactly sure what it's there for

"Users may supply mimeType in order to simulate the optional mime-type
header associated with HTTP downloads."

On 12-02-22 9:42 AM, "Simon MacDonald" <simon.macdonald@gmail.com> wrote:

>It is in this spec which is the working draft:
>
>http://www.w3.org/TR/file-system-api/#widl-Entry-toURL
>
>but not in the editors draft:
>
>http://dev.w3.org/2009/dap/file-system/file-dir-sys.html
>
>so I'm happy to take it out if everyone is okay with that.
>
>Simon Mac Donald
>http://hi.im/simonmacdonald
>
>
>On Wed, Feb 22, 2012 at 12:33 PM, Drew Walters <deedubbu@gmail.com> wrote:
>
>> mimetype is not a parameter of toURL either though right?
>>
>> On Wed, Feb 22, 2012 at 11:30 AM, Simon MacDonald
>> <simon.macdonald@gmail.com> wrote:
>> > Okay, I've just put a change that adds toURI back into the Entry class
>> for
>> > backwards compatibility. I also removed the success/error parameters
>>from
>> > toURL as they are not according spec and they are never used.
>> >
>> > Take a look at the change and let me know if anything else is needed:
>> >
>> >
>> 
>>https://github.com/macdonst/callback-js/commit/de67a919af0aa5bdc81ab3c2ee
>>ce1ed17a7fd9de
>> >
>> > If I get a +1 I'll merge the code into the Apache cordova-js repo.
>> >
>> > Simon Mac Donald
>> > http://hi.im/simonmacdonald
>> >
>> >
>> > On Fri, Feb 17, 2012 at 2:55 PM, Filip Maj <fil@adobe.com> wrote:
>> >
>> >> I like that idea, Simon. Simple to add a method copy from toURL ->
>> toURI,
>> >> add a console.log, tag for 1.5, done.
>> >>
>> >> As for updating the error codes - can we shelve that for 1.6?
>> >>
>> >> On 12-02-17 11:52 AM, "Simon MacDonald" <simon.macdonald@gmail.com>
>> wrote:
>> >>
>> >> >For the 1.5.0 release can we support <Entry>.toURI() and
>> <Entry>.toURL()?
>> >> >We'll mark toURI as deprecated and remove it in 1.6.0 or 1.7.0.
>>What do
>> >> >you
>> >> >think?
>> >> >
>> >> >As for the FileError codes. Grrrrr...why did they have to change
>>them.
>> >> >
>> >> >Simon Mac Donald
>> >> >http://hi.im/simonmacdonald
>> >> >
>> >> >
>> >> >On Fri, Feb 17, 2012 at 2:36 PM, Becky Gibson
>> >> ><gibson.becky@gmail.com>wrote:
>> >> >
>> >> >> I was running the mobile-spec after Shaz completed and checked
in
>>the
>> >> >>iOS
>> >> >> name change (THANKS, Shaz!) and found that several file tests
>>fail.
>> The
>> >> >> issue is the name change of the <Entry>.toURI() api to
>> <Entry>.toURL().
>> >> >> Checking on the W3C File API: Directories and Systems spec. this
>>API
>> was
>> >> >> indeed renamed from the October, 2010, version of the spec that
we
>> >> >> implemented to the April and May, 2011 versions.   The FileError
>> codes
>> >> >>have
>> >> >> also been reassigned - although that has not been updated in the
>> >> >>unified-js
>> >> >> implementation.
>> >> >>
>> >> >> Other than the API name change and FileError code reassignments,
I
>> don't
>> >> >> see major changes in the specification.  However, this will
>>certainly
>> >> >>break
>> >> >> existing apps and I question making that change.   I realize it
>>has
>> to
>> >> >>be
>> >> >> made sooner or later, but it might be best to wait for the api
to
>>be
>> >> >> finalized.   If we are going to make this api change, then we
>>should
>> >> >> probably also make the FileError changes to be consistent.  And
>> update
>> >> >>the
>> >> >> docs and make sure this is well documented.
>> >> >>
>> >> >> my two cents,
>> >> >> -becky
>> >> >>
>> >>
>> >>
>>


Mime
View raw message