incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Bowser <bows...@gmail.com>
Subject Re: Bug in FileSystem.js
Date Fri, 24 Feb 2012 19:33:51 GMT
No, I think you are partially right.  I think the name should be blank for
the root directory of the persistent storage.  It definitely shouldn't say
that it's persistent, that seems to be very wrong.

Joe

On Fri, Feb 24, 2012 at 11:10 AM, Simon MacDonald <simon.macdonald@gmail.com
> wrote:

> Becky has found a bug in FileSystem.js and I just wanted to bring it up
> on the list before making any changes. At this line:
>
>
> https://github.com/apache/incubator-cordova-js/blob/master/lib/plugin/FileSystem.js#L13
>
> you see a new DirectoryEntry is created using the *name* of the filesystem
> and the *root* path of the filesystem. What is being passed in is something
> like this:
>
> name = PERSISTENT
> root = /data/data/com.phonegap
>
> so when the DirectoryEntry is created it will have a name of
> *PERSISTENT*which is wrong. The name property should be the name of
> the file or
> *com.phonegap* in my example.
>
> Does this makes sense to everyone or are we going crazy?
>
> Simon Mac Donald
> http://hi.im/simonmacdonald
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message