incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Simon MacDonald <simon.macdon...@gmail.com>
Subject Re: Unified JS - Casting
Date Wed, 08 Feb 2012 20:52:57 GMT
Pat found a bug. I fixed it.

https://github.com/macdonst/cordova-android/commit/03effaf724a4d4a84f6303ea0486e91a9c8e567f#diff-0

Simon Mac Donald
http://hi.im/simonmacdonald


On Wed, Feb 8, 2012 at 2:31 PM, Brian LeRoux <b@brian.io> wrote:

> DO IT
>
> On Wed, Feb 8, 2012 at 11:20 AM, Simon MacDonald
> <simon.macdonald@gmail.com> wrote:
> > One of the things I noticed when reading over the unified JS repo is that
> > it had gotten rid of casting functions. This means that some code would
> > need to change on the Android Java side. I quickly prototyped these
> changes
> > at:
> >
> >
> https://github.com/macdonst/cordova-android/commit/b774adb315d38ddd4c060680d78d9bbd53a21736
> >
> > All the mobile spec automated tests are working properly and my manual
> > testing seems to be okay as well. Need to double check Capture.
> >
> > So, I'd be happy to push these changes to the Android repo and then port
> > the JavaScript changes to Unified JS. What say you all?\
> >
> > Simon Mac Donald
> > http://hi.im/simonmacdonald
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message