incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Lanham (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-242) Change Reachability to PGReachability to avoid clashes
Date Wed, 08 Feb 2012 09:18:59 GMT

    [ https://issues.apache.org/jira/browse/CB-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203407#comment-13203407
] 

Matthew Lanham commented on CB-242:
-----------------------------------

Hi Shazron,

OK, hopefully i've done it right, i've just sent the pull request:

https://github.com/apache/incubator-cordova-ios/pull/4

Thanks

Matt
                
> Change Reachability to PGReachability to avoid clashes
> ------------------------------------------------------
>
>                 Key: CB-242
>                 URL: https://issues.apache.org/jira/browse/CB-242
>             Project: Apache Callback
>          Issue Type: Improvement
>          Components: iOS
>            Reporter: Matthew Lanham
>            Assignee: Shazron Abdullah
>            Priority: Minor
>             Fix For: 1.5.0
>
>
> We have been manually building each time a release is out to avoid this, often we have
libs in our iOS project that also package the Reachability class, it seems like that renaming
it is painless and causes no adverse affects, i have forked the GitHub project and made a
commit of our proposed changes, i wondered if someone could consider this being available
in the main repo.
> See commit here:
> https://github.com/swanify/incubator-cordova-ios/commit/87b601f1c64519d91d294629208f2a215a84a822

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message