Mailing-List: contact callback-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: callback-dev@incubator.apache.org
Received-SPF: pass (nike.apache.org: domain of anis.kadri@gmail.com designates
 209.85.213.175 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CB35E905.31DF%fil@adobe.com>
References: 
 <CACAoQH3VjAE+2Ym8WZHs_Tew+d49X+LQ2YKAxahDBRpxLLqXng@mail.gmail.com>
	<CB35E905.31DF%fil@adobe.com>
Date: Fri, 13 Jan 2012 15:56:38 -0800
Message-ID: 
 <CANpVHHzXAMOeZJHH+RGJdkuVZ5tuLryj1gcee0800-68HSPifQ@mail.gmail.com>
Subject: Re: cordova git repos at apache - shadowed at github
From: Anis KADRI <anis.kadri@gmail.com>
To: callback-dev@incubator.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

commiters emails addresses used to be checked when git was first setup
so I am guessing it should not be too hard to add a git hook to check
if a commiter has signed the ICLA.

On Fri, Jan 13, 2012 at 2:00 PM, Filip Maj <fil@adobe.com> wrote:
>
>
> On 12-01-13 1:54 PM, "Patrick Mueller" <pmuellr@gmail.com> wrote:
>
>>On Fri, Jan 13, 2012 at 16:45, Brian LeRoux <b@brian.io> wrote:
>>
>>> First cut off the top of my head:
>>>
>>> 1. I fork github.com/apache/cordova-ios
>>> 2. I make a few fixes and send a pull req
>>> 3. that pull req mails this list
>>> 4. ppl review it
>>> 5. looks good, I merge it to the apache.org git repo
>>> 6. changes are reflected on gh mirror
>>>
>>> Sound about right?
>>>
>>
>>Yup. =A0How we do 5) is what we need to figure out. =A0What format is the
>>commit in, and how do we apply it to a local repo? =A0Or maybe it's easie=
r
>>for a committer to add a remote to the contributors repo, and then just
>>merge at the command-line? =A0Once it's in a local repo, a committer can
>>commit it into the canonical Apache one easy-as-pie.
>
> Yeah, add remote locally on your machine, pull in the changes, test it ou=
t
> locally. I assume checking CLA stuff is done by hand (as we have done all
> along anyways). Once you have it merged in locally you can easily push it
> up to the git apache repo. Theoretically that then will eventually get
> mirrored back over to github.com/apache (and hopefully auto-close the pul=
l
> request, too).
>
>>
>>Also, is all the author/committer stuff maintained properly in the commit=
?
>> Are there some commit hooks to ensure the committer is really a
>>committer,
>>and that the author has signed the ICLA? =A0Guessing we'll have to do the
>>ICLA check by hand. =A0But it would be nice to know that the info is
>>maintained in the repo.
>
> Maybe Jukka knows the answer to this?
>