Mailing-List: contact callback-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: callback-dev@incubator.apache.org
Received-SPF: pass (nike.apache.org: domain of purdrew@gmail.com designates
 209.85.215.175 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CB123024.2333%fil@adobe.com>
References: 
 <CAO_65gz1BSrUqc2fzaX_VSjzb2BAvMmt++fEmKE3JKdhkTu9YA@mail.gmail.com>
	<CB123024.2333%fil@adobe.com>
Date: Sat, 17 Dec 2011 13:49:28 -0600
Message-ID: 
 <CAO_65gzuh3WL4wV6vFC+vEe3_2sM6Gjrdt2DGJaJgbkT4ibSeg@mail.gmail.com>
Subject: Re: Playbook code merge discussion
From: Drew Walters <purdrew@gmail.com>
To: callback-dev@incubator.apache.org
Content-Type: multipart/alternative; boundary=00151747afccee3e0c04b44f03f9

--00151747afccee3e0c04b44f03f9
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Thanks. That's awesome. Good luck.
On Dec 17, 2011 1:41 PM, "Filip Maj" <fil@adobe.com> wrote:

> Shit my bad guys.
>
> I'll merge the two pull requests shortly and re-test using the "manual"
> tests that are present in callback-test.
>
> If everything is cool then I'll retag.
>
> On 11-12-17 11:25 AM, "Drew Walters" <purdrew@gmail.com> wrote:
>
> >I spent time the last two days setting up and testing on playbook
> >simulator
> >but was unable to get the camera API to work with or without my change.
> >Not
> >sure if the simulator has an issue or what but I have been unable to
> >properly test it on playbook. I stepped through the JavaScript and was
> >getting a null response in one of the internal blackberry webworks API.
> >
> >On Saturday, December 17, 2011, Michael Brooks <michael@michaelbrooks.ca=
>
> >wrote:
> >> Drew, since you know how to replicate the issues, can you apply these
> >>two
> >> pull requests, test on both platforms, and push to the master repo?
> >>
> >> If everything is fine, then we can retag callback-blackberry.
> >>
> >> Michael
> >>
> >> On Fri, Dec 16, 2011 at 6:12 PM, Drew Walters <deedubbu@gmail.com>
> >>wrote:
> >>
> >>> Fil, it doesn't look like my pull requests have been merged in.
> >>> Without the pull request with the capture and camera fix, the
> >>> BlackBerry code would be a regression.  Not sure which tests you are
> >>> referring to, maybe the automated tests?  Those tests must not
> >>> exercise the issues that exist.  Namely, recording audio input,
> >>> reporting supported format types, specifying camera image size and
> >>> some others.
> >>>
> >>> On Fri, Dec 16, 2011 at 6:30 PM, Filip Maj <fil@adobe.com> wrote:
> >>> > Alright cool I'll tag shortly and update on the "don=B9t forget to =
tag"
> >>> > thread :P
> >>> >
> >>> > On 11-12-16 4:00 PM, "Dave Johnson" <dave.c.johnson@gmail.com>
> wrote:
> >>> >
> >>> >>+1 that sounds good to me.
> >>> >>On Dec 16, 2011 3:39 PM, "Filip Maj" <fil@adobe.com> wrote:
> >>> >>
> >>> >>> One more note on the PlayBook failing tests: pretty much all of t=
he
> >>> >>> failing tests on PlayBook are related to the File API, which I se=
em
> >to
> >>> >>> recall the RIM calls explicitly telling me when they were working
> >>>on
> >>> >>>it...
> >>> >>>
> >>> >>> APIs such as GPS, Accel, Network, Notification, Contacts all seem
> >>>to
> >be
> >>> >>> working according to the tests.
> >>> >>>
> >>> >>> So, once more, in terms of release notes for 1.3 maybe we can say
> >>> "Basic
> >>> >>> Playbook support, minus the File API" ?
> >>> >>>
> >>> >>> On 11-12-16 3:34 PM, "Filip Maj" <fil@adobe.com> wrote:
> >>> >>>
> >>> >>> >Hey guys,
> >>> >>> >
> >>> >>> >Quick update on the state of the BB implementations for 1.3.
> >>> >>> >
> >>> >>> >1.3.0rc2 currently has approximately 95% of the PhoneGap API tes=
ts
> >>> >>>passing
> >>> >>> >on the smartphone, and just over half passing on the PlayBook
> >>> >>>simulator. I
> >>> >>> >don't have a working PlayBook device so rocking the sim - which
> >>>may
> >>> >>>not be
> >>> >>> >giving us a true reflection of the state of callback/cordova on
> >>>the
> >>> >>> >playbook.
> >>> >>> >
> >>> >>> >So, obviously some issues on the playbook that I am working
> >>>through
> >to
> >>> >>> >document and fix, but no regressions on the smartphone.
> >>> >>> >
> >>> >>> >Is that good to tag? I'll be documenting both smartphone and
> >playbook
> >>> >>> >issues. Marketing/release notes-wise, can we label 1.3.0 as havi=
ng
> >>> >>>"basic
> >>> >>> >PlayBook support", or what do we do with respect to that?
> >>> >>> >
> >>> >>> >On 11-12-15 1:30 PM, "Filip Maj" <fil@adobe.com> wrote:
> >>> >>> >
> >>> >>> >>Drew, thanks for the clarification. I am going to double-check
> >>>both
> >>> >>> >>playbook and smartphone implementations and make sure we are
> >>>golden
> >>> >>> >>before
> >>> >>> >>tomorrow.
> >>> >>> >>
> >>> >>> >>On 11-12-15 8:59 AM, "Drew Walters" <deedubbu@gmail.com> wrote:
> >>> >>> >>
> >>> >>> >>>Ok, I've submitted two pull requests which resolve numbers 3
> >>>and 4
> >>> >>>from
> >>> >>> >>>my list:
> >>> >>> >>>
> >>> >>> >>>3. Restore camera and capture native functionality.
> >>> >>> >>>    https://github.com/callback/callback-blackberry/pull/13
> >>> >>> >>>
> >>> >>> >>>4. Delete duplicate blackberry.identity and blackberry.system
> >>> feature
> >>> >>> >>>ids in config.xml.
> >>> >>> >>>
>
>

--00151747afccee3e0c04b44f03f9--