incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Brooks <mikeywbro...@gmail.com>
Subject Re: Playbook code merge discussion
Date Thu, 22 Dec 2011 00:04:20 GMT
Woo, thank you Jeff and Gord!

Thanks for testing it Fil. I only had a simulator on hand.

We should kick up a new discussion about the subdirectory issue that you're experiencing.

Michael

On 2011-12-21, at 5:47 PM, Filip Maj <fil@adobe.com> wrote:

> Thanks indeed! That fixed phonegap on a real playbook. Merged now. Werd.
> 
> Funny how it still worked on the simulator... ? Would love to figure that
> one out :P
> 
> P.S. Loading the playbook-specific phonegap.js from a subdirectory does
> *not* work for me, I have to put that file in the root of the webworks
> archive. Weird eh?
> 
> On 11-12-21 7:40 AM, "Gord Tanner" <gord@tinyhippos.com> wrote:
> 
>> Issued a pull request to fix the playbook support in 1.3.
>> 
>> https://github.com/callback/callback-blackberry/pull/14
>> Looks like there was a small merge issue that broke it.  Thanks to Jeffrey
>> Heifetz for finding and fixing this.
>> 
>> Gord
>> 
>> On Mon, Dec 19, 2011 at 11:55 AM, Michael Brooks
>> <michael@michaelbrooks.ca>wrote:
>> 
>>>> 
>>>> Once deployed to an actual Playbook, callback tests and even the
>>> sample
>>>> app don't run at all. Identical code working fine on the simulator.
>>> Crap
>>> :/
>>> 
>>> 
>>> Ouch.
>>> 
>>> I remember kicking up the sample application on my PlayBook and seeing
>>> the
>>> confirm dialog. So, you may want to double check the application on a
>>> production PlayBook.
>>> 
>>> Regardless, until we can test further, I agree that we shouldn't claim
>>> PlayBook support. *sad panda*
>>> 
>>> Michael
>>> 
>>> 2011/12/18 Filip Maj <fil@adobe.com>
>>> 
>>>> Well, regarding PlayBook support I spoke too soon.
>>>> 
>>>> I ended up resuscitating the discharged Playbook I had by a
>>> combination
>>> of
>>>> hard resets and firmware reloads. Wasn't easy!
>>>> 
>>>> Once deployed to an actual Playbook, callback tests and even the
>>> sample
>>>> app don't run at all. Identical code working fine on the simulator.
>>> Crap
>>> :/
>>>> 
>>>> I hooked up the built-in Web Inspector support on the PlayBook (which
>>> is
>>>> rad, btw) but can't really tell what is going on other than some of
>>> the
>>>> built-in system foreground/background callbacks were throwing an
>>>> exception. This isn't any of our code, so I can't see the source that
>>> is
>>>> causing the exception, I can only try to catch uncaught exceptions in
>>> web
>>>> inspector and deduce what is going on that way... So, yeah, not much
>>> can
>>>> be discerned. So Inspector just ends up reporting "TypeError: Result
>>> of
>>>> expression 'response' [null] is not an object."
>>>> 
>>>> I think until I can figure out/set myself up on how to debug the
>>> native
>>>> extensions on the PB and find out what is breaking stuff on the actual
>>>> device, we shouldn't claim any Playbook support...
>>>> 
>>>> On 11-12-18 2:10 PM, "Filip Maj" <fil@adobe.com> wrote:
>>>> 
>>>>> Hey all
>>>>> 
>>>>> Merge looks fine. Works well on the smartphone. Can't test on a
>>> playbook
>>>>> device (waiting on signing keys) but I will once I get them. In any
>>> case,
>>>>> pretty much everything but the File API was working fine on the
>>> playbook
>>>>> sim.
>>>>> 
>>>>> Still some issues to work out but they are documented. Based on the
>>> issue
>>>>> tracker we've got some work to do in 2012!
>>>>> 
>>>>> On 11-12-17 11:49 AM, "Drew Walters" <purdrew@gmail.com> wrote:
>>>>> 
>>>>>> Thanks. That's awesome. Good luck.
>>>>>> On Dec 17, 2011 1:41 PM, "Filip Maj" <fil@adobe.com> wrote:
>>>>>> 
>>>>>>> Shit my bad guys.
>>>>>>> 
>>>>>>> I'll merge the two pull requests shortly and re-test using the
>>> "manual"
>>>>>>> tests that are present in callback-test.
>>>>>>> 
>>>>>>> If everything is cool then I'll retag.
>>>>>>> 
>>>>>>> On 11-12-17 11:25 AM, "Drew Walters" <purdrew@gmail.com>
wrote:
>>>>>>> 
>>>>>>>> I spent time the last two days setting up and testing on
playbook
>>>>>>>> simulator
>>>>>>>> but was unable to get the camera API to work with or without
my
>>>>>>> change.
>>>>>>>> Not
>>>>>>>> sure if the simulator has an issue or what but I have been
>>> unable to
>>>>>>>> properly test it on playbook. I stepped through the JavaScript
>>> and
>>> was
>>>>>>>> getting a null response in one of the internal blackberry
>>> webworks
>>>>>>> API.
>>>>>>>> 
>>>>>>>> On Saturday, December 17, 2011, Michael Brooks
>>>>>>> <michael@michaelbrooks.ca>
>>>>>>>> wrote:
>>>>>>>>> Drew, since you know how to replicate the issues, can
you apply
>>>>>>> these
>>>>>>>>> two
>>>>>>>>> pull requests, test on both platforms, and push to the
master
>>> repo?
>>>>>>>>> 
>>>>>>>>> If everything is fine, then we can retag callback-blackberry.
>>>>>>>>> 
>>>>>>>>> Michael
>>>>>>>>> 
>>>>>>>>> On Fri, Dec 16, 2011 at 6:12 PM, Drew Walters
>>> <deedubbu@gmail.com
>>>> 
>>>>>>>>> wrote:
>>>>>>>>> 
>>>>>>>>>> Fil, it doesn't look like my pull requests have been
merged
>>> in.
>>>>>>>>>> Without the pull request with the capture and camera
fix, the
>>>>>>>>>> BlackBerry code would be a regression.  Not sure
which tests
>>> you
>>>>>>> are
>>>>>>>>>> referring to, maybe the automated tests?  Those tests
must not
>>>>>>>>>> exercise the issues that exist.  Namely, recording
audio
>>> input,
>>>>>>>>>> reporting supported format types, specifying camera
image size
>>> and
>>>>>>>>>> some others.
>>>>>>>>>> 
>>>>>>>>>> On Fri, Dec 16, 2011 at 6:30 PM, Filip Maj <fil@adobe.com>
>>> wrote:
>>>>>>>>>>> Alright cool I'll tag shortly and update on the
"donĀ¹t
>>> forget
>>> to
>>>>>>> tag"
>>>>>>>>>>> thread :P
>>>>>>>>>>> 
>>>>>>>>>>> On 11-12-16 4:00 PM, "Dave Johnson"
>>> <dave.c.johnson@gmail.com>
>>>>>>> wrote:
>>>>>>>>>>> 
>>>>>>>>>>>> +1 that sounds good to me.
>>>>>>>>>>>> On Dec 16, 2011 3:39 PM, "Filip Maj" <fil@adobe.com>
wrote:
>>>>>>>>>>>> 
>>>>>>>>>>>>> One more note on the PlayBook failing
tests: pretty much
>>> all
>>> of
>>>>>>> the
>>>>>>>>>>>>> failing tests on PlayBook are related
to the File API,
>>> which
>>> I
>>>>>>> seem
>>>>>>>> to
>>>>>>>>>>>>> recall the RIM calls explicitly telling
me when they were
>>>>>>> working
>>>>>>>>>> on
>>>>>>>>>>>>> it...
>>>>>>>>>>>>> 
>>>>>>>>>>>>> APIs such as GPS, Accel, Network, Notification,
Contacts
>>> all
>>>>>>> seem
>>>>>>>>>> to
>>>>>>>> be
>>>>>>>>>>>>> working according to the tests.
>>>>>>>>>>>>> 
>>>>>>>>>>>>> So, once more, in terms of release notes
for 1.3 maybe we
>>> can
>>>>>>> say
>>>>>>>>>> "Basic
>>>>>>>>>>>>> Playbook support, minus the File API"
?
>>>>>>>>>>>>> 
>>>>>>>>>>>>> On 11-12-16 3:34 PM, "Filip Maj" <fil@adobe.com>
wrote:
>>>>>>>>>>>>> 
>>>>>>>>>>>>>> Hey guys,
>>>>>>>>>>>>>> 
>>>>>>>>>>>>>> Quick update on the state of the
BB implementations for
>>> 1.3.
>>>>>>>>>>>>>> 
>>>>>>>>>>>>>> 1.3.0rc2 currently has approximately
95% of the PhoneGap
>>> API
>>>>>>> tests
>>>>>>>>>>>>> passing
>>>>>>>>>>>>>> on the smartphone, and just over
half passing on the
>>> PlayBook
>>>>>>>>>>>>> simulator. I
>>>>>>>>>>>>>> don't have a working PlayBook device
so rocking the sim -
>>>>>>> which
>>>>>>>>>> may
>>>>>>>>>>>>> not be
>>>>>>>>>>>>>> giving us a true reflection of the
state of
>>> callback/cordova
>>>>>>> on
>>>>>>>>>> the
>>>>>>>>>>>>>> playbook.
>>>>>>>>>>>>>> 
>>>>>>>>>>>>>> So, obviously some issues on the
playbook that I am
>>> working
>>>>>>>>>> through
>>>>>>>> to
>>>>>>>>>>>>>> document and fix, but no regressions
on the smartphone.
>>>>>>>>>>>>>> 
>>>>>>>>>>>>>> Is that good to tag? I'll be documenting
both smartphone
>>> and
>>>>>>>> playbook
>>>>>>>>>>>>>> issues. Marketing/release notes-wise,
can we label 1.3.0
>>> as
>>>>>>> having
>>>>>>>>>>>>> "basic
>>>>>>>>>>>>>> PlayBook support", or what do we
do with respect to that?
>>>>>>>>>>>>>> 
>>>>>>>>>>>>>> On 11-12-15 1:30 PM, "Filip Maj"
<fil@adobe.com> wrote:
>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>> Drew, thanks for the clarification.
I am going to
>>>>>>> double-check
>>>>>>>>>> both
>>>>>>>>>>>>>>> playbook and smartphone implementations
and make sure we
>>> are
>>>>>>>>>> golden
>>>>>>>>>>>>>>> before
>>>>>>>>>>>>>>> tomorrow.
>>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>> On 11-12-15 8:59 AM, "Drew Walters"
<deedubbu@gmail.com>
>>>>>>> wrote:
>>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>>> Ok, I've submitted two pull
requests which resolve
>>> numbers 3
>>>>>>>>>> and 4
>>>>>>>>>>>>> from
>>>>>>>>>>>>>>>> my list:
>>>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>>> 3. Restore camera and capture
native functionality.
>>>>>>>>>>>>>>>> 
>>> https://github.com/callback/callback-blackberry/pull/13
>>>>>>>>>>>>>>>> 
>>>>>>>>>>>>>>>> 4. Delete duplicate blackberry.identity
and
>>>>>>> blackberry.system
>>>>>>>>>> feature
>>>>>>>>>>>>>>>> ids in config.xml.
>>>>>>>>>>>>>>>> 
>>>>>>> 
>>>>>>> 
>>>>> 
>>>> 
>>>> 
>>> 
>> 
>> 
>> 
>> -- 
>> Gord Tanner
>> Senior Developer / Code Poet
>> tinyHippos Inc.
>> @tinyhippos
> 

Mime
View raw message