incubator-callback-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bra...@apache.org
Subject [18/18] android commit: Cleanups to CordovaPlugin.
Date Fri, 12 Oct 2012 21:06:18 GMT
Cleanups to CordovaPlugin.


Project: http://git-wip-us.apache.org/repos/asf/incubator-cordova-android/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-cordova-android/commit/891f8d00
Tree: http://git-wip-us.apache.org/repos/asf/incubator-cordova-android/tree/891f8d00
Diff: http://git-wip-us.apache.org/repos/asf/incubator-cordova-android/diff/891f8d00

Branch: refs/heads/master
Commit: 891f8d00cf3f3b58f84014f51197fdb06ce30b9d
Parents: 4e0c898
Author: Braden Shepherdson <braden@chromium.org>
Authored: Wed Oct 10 14:11:13 2012 -0400
Committer: Braden Shepherdson <braden@chromium.org>
Committed: Wed Oct 10 14:11:13 2012 -0400

----------------------------------------------------------------------
 .../src/org/apache/cordova/api/CordovaPlugin.java  |   29 ++++++++-------
 1 files changed, 15 insertions(+), 14 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-cordova-android/blob/891f8d00/framework/src/org/apache/cordova/api/CordovaPlugin.java
----------------------------------------------------------------------
diff --git a/framework/src/org/apache/cordova/api/CordovaPlugin.java b/framework/src/org/apache/cordova/api/CordovaPlugin.java
index 8a1da49..18f3c55 100644
--- a/framework/src/org/apache/cordova/api/CordovaPlugin.java
+++ b/framework/src/org/apache/cordova/api/CordovaPlugin.java
@@ -33,27 +33,28 @@ public class CordovaPlugin {
     public CordovaInterface cordova;
 
     /**
-     * @param ctx The context of the main Activity.
+     * @param cordova The context of the main Activity.
+     * @param webView The associated CordovaWebView.
      */
     public void initialize(CordovaInterface cordova, CordovaWebView webView) {
         assert this.cordova == null;
         this.cordova = cordova;
         this.webView = webView;
     }
-    
+
     /**
      * Executes the request.
-     * 
+     *
      * This method is called from the WebView thread. To do a non-trivial amount of work,
use:
      *     cordova.getThreadPool().execute(runnable);
-     * 
+     *
      * To run on the UI thread, use:
      *     cordova.getActivity().runOnUiThread(runnable);
      *
-     * @param action        The action to execute.
-     * @param rawArgs       The exec() arguments in JSON form.
-     * @param callbackId    The callback id used when calling back into JavaScript.
-     * @return              Whether the action was valid.
+     * @param action          The action to execute.
+     * @param rawArgs         The exec() arguments in JSON form.
+     * @param callbackContext The callback context used when calling back into JavaScript.
+     * @return                Whether the action was valid.
      */
     public boolean execute(String action, String rawArgs, CallbackContext callbackContext)
throws JSONException {
         JSONArray args = new JSONArray(rawArgs);
@@ -62,17 +63,17 @@ public class CordovaPlugin {
 
     /**
      * Executes the request.
-     * 
+     *
      * This method is called from the WebView thread. To do a non-trivial amount of work,
use:
      *     cordova.getThreadPool().execute(runnable);
-     * 
+     *
      * To run on the UI thread, use:
      *     cordova.getActivity().runOnUiThread(runnable);
      *
-     * @param action        The action to execute.
-     * @param args          The exec() arguments.
-     * @param callbackId    The callback id used when calling back into JavaScript.
-     * @return              Whether the action was valid.
+     * @param action          The action to execute.
+     * @param args            The exec() arguments.
+     * @param callbackContext The callback context used when calling back into JavaScript.
+     * @return                Whether the action was valid.
      */
     public boolean execute(String action, JSONArray args, CallbackContext callbackContext)
throws JSONException {
         return false;


Mime
View raw message