incubator-callback-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shaz...@apache.org
Subject [1/2] ios commit: [CB-1457] Remove unused CDVMotion core plugin - causes Apple App Store upload rejection
Date Thu, 13 Sep 2012 05:40:42 GMT
Updated Branches:
  refs/heads/master 94b0d791f -> f03d50253


[CB-1457] Remove unused CDVMotion core plugin - causes Apple App Store upload rejection


Project: http://git-wip-us.apache.org/repos/asf/incubator-cordova-ios/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-cordova-ios/commit/f03d5025
Tree: http://git-wip-us.apache.org/repos/asf/incubator-cordova-ios/tree/f03d5025
Diff: http://git-wip-us.apache.org/repos/asf/incubator-cordova-ios/diff/f03d5025

Branch: refs/heads/master
Commit: f03d50253305c6768b7329418bdc1ac5ddd8b5a9
Parents: 1041cac
Author: Shazron Abdullah <shazron@apache.org>
Authored: Wed Sep 12 22:27:38 2012 -0700
Committer: Shazron Abdullah <shazron@apache.org>
Committed: Wed Sep 12 22:27:38 2012 -0700

----------------------------------------------------------------------
 CordovaLib/Classes/CDV.h                        |    1 -
 CordovaLib/Classes/CDVMotion.h                  |   36 ---------
 CordovaLib/Classes/CDVMotion.m                  |   74 ------------------
 CordovaLib/CordovaLib.xcodeproj/project.pbxproj |    8 --
 4 files changed, 0 insertions(+), 119 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-cordova-ios/blob/f03d5025/CordovaLib/Classes/CDV.h
----------------------------------------------------------------------
diff --git a/CordovaLib/Classes/CDV.h b/CordovaLib/Classes/CDV.h
index f93b53b..b46e2bf 100644
--- a/CordovaLib/Classes/CDV.h
+++ b/CordovaLib/Classes/CDV.h
@@ -39,7 +39,6 @@
 #import "CDVFile.h"
 #import "CDVFileTransfer.h"
 #import "CDVLocation.h"
-#import "CDVMotion.h"
 #import "CDVNotification.h"
 #import "CDVPluginResult.h"
 #import "CDVReachability.h"

http://git-wip-us.apache.org/repos/asf/incubator-cordova-ios/blob/f03d5025/CordovaLib/Classes/CDVMotion.h
----------------------------------------------------------------------
diff --git a/CordovaLib/Classes/CDVMotion.h b/CordovaLib/Classes/CDVMotion.h
deleted file mode 100644
index 4abb037..0000000
--- a/CordovaLib/Classes/CDVMotion.h
+++ /dev/null
@@ -1,36 +0,0 @@
-/*
- Licensed to the Apache Software Foundation (ASF) under one
- or more contributor license agreements.  See the NOTICE file
- distributed with this work for additional information
- regarding copyright ownership.  The ASF licenses this file
- to you under the Apache License, Version 2.0 (the
- "License"); you may not use this file except in compliance
- with the License.  You may obtain a copy of the License at
- 
- http://www.apache.org/licenses/LICENSE-2.0
- 
- Unless required by applicable law or agreed to in writing,
- software distributed under the License is distributed on an
- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- KIND, either express or implied.  See the License for the
- specific language governing permissions and limitations
- under the License.
- */
-
-#import <Foundation/Foundation.h>
-#import "CDVPlugin.h"
-
-
-@interface CDVMotion : CDVPlugin {
-}
-
-@property (readonly, getter=isDeviceMotionAvailable) BOOL deviceMotionAvailable;
-@property (readonly, getter=isDeviceOrientationAvailable) BOOL deviceOrientationAvailable;
-
-
-/* Checks whether the DeviceMotionEvent is available in the UIWebView */
-- (BOOL) deviceMotionAvailable; 
-/* Checks whether the DeviceOrientationEvent is available in the UIWebView */
-- (BOOL) deviceOrientationAvailable; 
-
-@end

http://git-wip-us.apache.org/repos/asf/incubator-cordova-ios/blob/f03d5025/CordovaLib/Classes/CDVMotion.m
----------------------------------------------------------------------
diff --git a/CordovaLib/Classes/CDVMotion.m b/CordovaLib/Classes/CDVMotion.m
deleted file mode 100644
index 397393d..0000000
--- a/CordovaLib/Classes/CDVMotion.m
+++ /dev/null
@@ -1,74 +0,0 @@
-/*
- Licensed to the Apache Software Foundation (ASF) under one
- or more contributor license agreements.  See the NOTICE file
- distributed with this work for additional information
- regarding copyright ownership.  The ASF licenses this file
- to you under the Apache License, Version 2.0 (the
- "License"); you may not use this file except in compliance
- with the License.  You may obtain a copy of the License at
- 
- http://www.apache.org/licenses/LICENSE-2.0
- 
- Unless required by applicable law or agreed to in writing,
- software distributed under the License is distributed on an
- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- KIND, either express or implied.  See the License for the
- specific language governing permissions and limitations
- under the License.
- */
-
-
-#import "CDVMotion.h"
-
-@implementation CDVMotion
-
-@synthesize deviceMotionAvailable, deviceOrientationAvailable;
-
-- (void) startDeviceMotionEvents
-{
-	// TODO: all iOS devices have accelerometers. Barring a way to detect if any listeners are
bound,
-	// we will have to flood the UIWebView with these events
-	// If !isDeviceMotionAvailable, we pump out the events
-}
-
-- (void) startDeviceOrientationEvents
-{
-	// TODO: currently only iPhone 4 has support for gyro. We would only need to fill in support
for iOS 4.0 and 4.1 
-	// (since the DeviceOrientationEvent is supported in in 4.2 for UIWebView)
-	// If gyro is available (see CMMotionManagerin CoreMotion.framework) AND !isDeviceOrientationAvailable,
we pump out the events
-}
-
-- (CDVPlugin*) initWithWebView:(UIWebView*)theWebView
-{
-    self = (CDVMotion*)[super initWithWebView:theWebView];
-    if (self) {
-		// this class has to be created somewhere for it to pump out events,
-		// perhaps in the AppDelegate
-		if (self.isDeviceMotionAvailable) {
-			[self startDeviceMotionEvents];
-		}
-		if (self.isDeviceOrientationAvailable) {
-			[self startDeviceOrientationEvents];
-		}
-    }
-    return self;
-}
-
-- (BOOL) deviceMotionAvailable
-{
-	NSString* js = @"window.DeviceMotionEvent != undefined";
-	NSString* result = [self.webView stringByEvaluatingJavaScriptFromString:js];
-	
-	return [result isEqualToString:@"true"];
-}
-
-- (BOOL) deviceOrientationAvailable
-{
-	NSString* js = @"window.DeviceOrientationEvent != undefined";
-	NSString* result = [self.webView stringByEvaluatingJavaScriptFromString:js];
-	
-	return [result isEqualToString:@"true"];
-}
-
-
-@end

http://git-wip-us.apache.org/repos/asf/incubator-cordova-ios/blob/f03d5025/CordovaLib/CordovaLib.xcodeproj/project.pbxproj
----------------------------------------------------------------------
diff --git a/CordovaLib/CordovaLib.xcodeproj/project.pbxproj b/CordovaLib/CordovaLib.xcodeproj/project.pbxproj
index 09749d1..ec0d0fe 100644
--- a/CordovaLib/CordovaLib.xcodeproj/project.pbxproj
+++ b/CordovaLib/CordovaLib.xcodeproj/project.pbxproj
@@ -24,8 +24,6 @@
 		3062D122151D0EDB000D9128 /* UIDevice+Extensions.m in Sources */ = {isa = PBXBuildFile;
fileRef = 3062D11F151D0EDB000D9128 /* UIDevice+Extensions.m */; };
 		307A8F9E1385A2EC00E43782 /* CDVConnection.h in Headers */ = {isa = PBXBuildFile; fileRef
= 307A8F9C1385A2EC00E43782 /* CDVConnection.h */; settings = {ATTRIBUTES = (Public, ); };
};
 		307A8F9F1385A2EC00E43782 /* CDVConnection.m in Sources */ = {isa = PBXBuildFile; fileRef
= 307A8F9D1385A2EC00E43782 /* CDVConnection.m */; };
-		30956FD2138F1F5600FC3563 /* CDVMotion.h in Headers */ = {isa = PBXBuildFile; fileRef =
30956FD0138F1F5600FC3563 /* CDVMotion.h */; settings = {ATTRIBUTES = (Public, ); }; };
-		30956FD3138F1F5600FC3563 /* CDVMotion.m in Sources */ = {isa = PBXBuildFile; fileRef =
30956FD1138F1F5600FC3563 /* CDVMotion.m */; };
 		30A90B9114588697006178D3 /* JSONKit.h in Headers */ = {isa = PBXBuildFile; fileRef = 30A90B8F14588697006178D3
/* JSONKit.h */; settings = {ATTRIBUTES = (Public, ); }; };
 		30A90B9314588697006178D3 /* JSONKit.m in Sources */ = {isa = PBXBuildFile; fileRef = 30A90B9014588697006178D3
/* JSONKit.m */; settings = {COMPILER_FLAGS = "-fno-objc-arc"; }; };
 		30B39EBE13D0268B0009682A /* CDVSplashScreen.h in Headers */ = {isa = PBXBuildFile; fileRef
= 30B39EBC13D0268B0009682A /* CDVSplashScreen.h */; settings = {ATTRIBUTES = (Public, ); };
};
@@ -98,8 +96,6 @@
 		3062D11F151D0EDB000D9128 /* UIDevice+Extensions.m */ = {isa = PBXFileReference; fileEncoding
= 4; lastKnownFileType = sourcecode.c.objc; name = "UIDevice+Extensions.m"; path = "Classes/UIDevice+Extensions.m";
sourceTree = "<group>"; };
 		307A8F9C1385A2EC00E43782 /* CDVConnection.h */ = {isa = PBXFileReference; fileEncoding
= 4; lastKnownFileType = sourcecode.c.h; name = CDVConnection.h; path = Classes/CDVConnection.h;
sourceTree = "<group>"; };
 		307A8F9D1385A2EC00E43782 /* CDVConnection.m */ = {isa = PBXFileReference; fileEncoding
= 4; lastKnownFileType = sourcecode.c.objc; name = CDVConnection.m; path = Classes/CDVConnection.m;
sourceTree = "<group>"; };
-		30956FD0138F1F5600FC3563 /* CDVMotion.h */ = {isa = PBXFileReference; fileEncoding = 4;
lastKnownFileType = sourcecode.c.h; name = CDVMotion.h; path = Classes/CDVMotion.h; sourceTree
= "<group>"; };
-		30956FD1138F1F5600FC3563 /* CDVMotion.m */ = {isa = PBXFileReference; fileEncoding = 4;
lastKnownFileType = sourcecode.c.objc; name = CDVMotion.m; path = Classes/CDVMotion.m; sourceTree
= "<group>"; };
 		30A90B8F14588697006178D3 /* JSONKit.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType
= sourcecode.c.h; path = JSONKit.h; sourceTree = "<group>"; };
 		30A90B9014588697006178D3 /* JSONKit.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType
= sourcecode.c.objc; path = JSONKit.m; sourceTree = "<group>"; };
 		30B39EBC13D0268B0009682A /* CDVSplashScreen.h */ = {isa = PBXFileReference; fileEncoding
= 4; lastKnownFileType = sourcecode.c.h; name = CDVSplashScreen.h; path = Classes/CDVSplashScreen.h;
sourceTree = "<group>"; };
@@ -254,8 +250,6 @@
 				30B39EBD13D0268B0009682A /* CDVSplashScreen.m */,
 				30E33AF013A7E24B00594D64 /* CDVPlugin.h */,
 				30E33AF113A7E24B00594D64 /* CDVPlugin.m */,
-				30956FD0138F1F5600FC3563 /* CDVMotion.h */,
-				30956FD1138F1F5600FC3563 /* CDVMotion.m */,
 				307A8F9C1385A2EC00E43782 /* CDVConnection.h */,
 				307A8F9D1385A2EC00E43782 /* CDVConnection.m */,
 				1F92F49E1314023E0046367C /* CDVPluginResult.h */,
@@ -356,7 +350,6 @@
 				1F92F4A01314023E0046367C /* CDVPluginResult.h in Headers */,
 				C937A4561337599E002C4C79 /* CDVFileTransfer.h in Headers */,
 				307A8F9E1385A2EC00E43782 /* CDVConnection.h in Headers */,
-				30956FD2138F1F5600FC3563 /* CDVMotion.h in Headers */,
 				1F584B9B1385A28A00ED25E8 /* CDVCapture.h in Headers */,
 				30E33AF213A7E24B00594D64 /* CDVPlugin.h in Headers */,
 				302965BC13A94E9D007046C5 /* CDVDebug.h in Headers */,
@@ -469,7 +462,6 @@
 				1F92F4A11314023E0046367C /* CDVPluginResult.m in Sources */,
 				C937A4571337599E002C4C79 /* CDVFileTransfer.m in Sources */,
 				307A8F9F1385A2EC00E43782 /* CDVConnection.m in Sources */,
-				30956FD3138F1F5600FC3563 /* CDVMotion.m in Sources */,
 				1F584B9C1385A28A00ED25E8 /* CDVCapture.m in Sources */,
 				30E33AF313A7E24B00594D64 /* CDVPlugin.m in Sources */,
 				30B39EBF13D0268B0009682A /* CDVSplashScreen.m in Sources */,


Mime
View raw message