Return-Path: X-Original-To: apmail-incubator-callback-commits-archive@minotaur.apache.org Delivered-To: apmail-incubator-callback-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6C73DDC63 for ; Fri, 17 Aug 2012 15:53:14 +0000 (UTC) Received: (qmail 93065 invoked by uid 500); 17 Aug 2012 15:53:14 -0000 Delivered-To: apmail-incubator-callback-commits-archive@incubator.apache.org Received: (qmail 93025 invoked by uid 500); 17 Aug 2012 15:53:14 -0000 Mailing-List: contact callback-commits-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: callback-dev@incubator.apache.org Delivered-To: mailing list callback-commits@incubator.apache.org Received: (qmail 92967 invoked by uid 99); 17 Aug 2012 15:53:14 -0000 Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Aug 2012 15:53:14 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id 1D1661DDA5; Fri, 17 Aug 2012 15:53:14 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: macdonst@apache.org To: callback-commits@incubator.apache.org X-Mailer: ASF-Git Admin Mailer Subject: [2/2] js commit: CB-1255: Media.stop calls the success callback twice Message-Id: <20120817155314.1D1661DDA5@tyr.zones.apache.org> Date: Fri, 17 Aug 2012 15:53:14 +0000 (UTC) CB-1255: Media.stop calls the success callback twice I took the call to the success callback out of Media.stop. Just letting the Media.onStatus method handle calling the success callback when it gets a status of STOPPED. Project: http://git-wip-us.apache.org/repos/asf/incubator-cordova-js/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-cordova-js/commit/114232a6 Tree: http://git-wip-us.apache.org/repos/asf/incubator-cordova-js/tree/114232a6 Diff: http://git-wip-us.apache.org/repos/asf/incubator-cordova-js/diff/114232a6 Branch: refs/heads/master Commit: 114232a6323183d9464cbc1eaed7765289914e22 Parents: 33d1ef2 Author: macdonst Authored: Fri Aug 17 11:35:16 2012 -0400 Committer: macdonst Committed: Fri Aug 17 11:35:26 2012 -0400 ---------------------------------------------------------------------- lib/common/plugin/Media.js | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-cordova-js/blob/114232a6/lib/common/plugin/Media.js ---------------------------------------------------------------------- diff --git a/lib/common/plugin/Media.js b/lib/common/plugin/Media.js index 50b3bfe..6b5310d 100644 --- a/lib/common/plugin/Media.js +++ b/lib/common/plugin/Media.js @@ -79,7 +79,6 @@ Media.prototype.stop = function() { var me = this; exec(function() { me._position = 0; - me.successCallback(); }, this.errorCallback, "Media", "stopPlayingAudio", [this.id]); };