incubator-callback-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fil...@apache.org
Subject git commit: todos and asyncblock-ing build command to wait for debug cmd to finish
Date Tue, 28 Aug 2012 23:31:26 GMT
Updated Branches:
  refs/heads/cordova-client e91530b03 -> aa5803f46


todos and asyncblock-ing build command to wait for debug cmd to finish


Project: http://git-wip-us.apache.org/repos/asf/incubator-cordova-labs/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-cordova-labs/commit/aa5803f4
Tree: http://git-wip-us.apache.org/repos/asf/incubator-cordova-labs/tree/aa5803f4
Diff: http://git-wip-us.apache.org/repos/asf/incubator-cordova-labs/diff/aa5803f4

Branch: refs/heads/cordova-client
Commit: aa5803f46ef9f225372ec284b7fdc4024cb76bf3
Parents: e91530b
Author: Fil Maj <maj.fil@gmail.com>
Authored: Tue Aug 28 16:31:12 2012 -0700
Committer: Fil Maj <maj.fil@gmail.com>
Committed: Tue Aug 28 16:31:12 2012 -0700

----------------------------------------------------------------------
 README.md    |    8 +++++---
 src/build.js |   11 ++++++++---
 2 files changed, 13 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-cordova-labs/blob/aa5803f4/README.md
----------------------------------------------------------------------
diff --git a/README.md b/README.md
index c0be20e..a1b739f 100644
--- a/README.md
+++ b/README.md
@@ -148,7 +148,9 @@ mocks/stubs that we override for testing purposes.
 
 ## TO-DO
 
-- fix pluginstall for ios 2.0
-- `grep` through this project for 'TODO'
+- verify android 2.1 support
+- verify ios 2.1 support
+- figure out versioning
+- tests!!!!
 - blackberry support
-- moar tests
+- windows phone support

http://git-wip-us.apache.org/repos/asf/incubator-cordova-labs/blob/aa5803f4/src/build.js
----------------------------------------------------------------------
diff --git a/src/build.js b/src/build.js
index acfeecb..fc8d2f8 100644
--- a/src/build.js
+++ b/src/build.js
@@ -6,6 +6,7 @@ var cordova_util  = require('./util'),
     cpr           = wrench.copyDirSyncRecursive,
     config_parser = require('./config_parser'),
     fs            = require('fs'),
+    asyncblock    = require('asyncblock'),
     util          = require('util');
 
 module.exports = function build () {
@@ -55,8 +56,12 @@ module.exports = function build () {
 
         // shell out to debug command
         var cmd = path.join(projectRoot, 'platforms', platform, 'cordova', 'debug > /dev/null');
-        exec(cmd, function(err, stderr, stdout) {
-            if (err) throw 'An error occurred while building the ' + platform + ' project.
' + err;
-        });
+        exec(cmd, flow.set({
+          key:'debug',
+          firstArgIsError:false,
+          responseFormat:['err', 'stdout', 'stderr']
+        }));
+        var buffers = flow.get('debug');
+        if (buffers.err) throw 'An error occurred while building the ' + platform + ' project.
' + buffers.err;
     });
 };


Mime
View raw message