incubator-callback-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bows...@apache.org
Subject android commit: Fixing bug on ICS where the super.onKeyDown wasn't being called
Date Mon, 09 Jul 2012 21:43:19 GMT
Updated Branches:
  refs/heads/master f095284fa -> 9d4977db0


Fixing bug on ICS where the super.onKeyDown wasn't being called


Project: http://git-wip-us.apache.org/repos/asf/incubator-cordova-android/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-cordova-android/commit/9d4977db
Tree: http://git-wip-us.apache.org/repos/asf/incubator-cordova-android/tree/9d4977db
Diff: http://git-wip-us.apache.org/repos/asf/incubator-cordova-android/diff/9d4977db

Branch: refs/heads/master
Commit: 9d4977db009d62fecc874bac0411e51b7dcce1d3
Parents: f095284
Author: Joe Bowser <bowserj@apache.org>
Authored: Mon Jul 9 14:42:29 2012 -0700
Committer: Joe Bowser <bowserj@apache.org>
Committed: Mon Jul 9 14:42:29 2012 -0700

----------------------------------------------------------------------
 .../src/org/apache/cordova/CordovaWebView.java     |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-cordova-android/blob/9d4977db/framework/src/org/apache/cordova/CordovaWebView.java
----------------------------------------------------------------------
diff --git a/framework/src/org/apache/cordova/CordovaWebView.java b/framework/src/org/apache/cordova/CordovaWebView.java
index 4a85551..ca0dd6d 100755
--- a/framework/src/org/apache/cordova/CordovaWebView.java
+++ b/framework/src/org/apache/cordova/CordovaWebView.java
@@ -676,7 +676,6 @@ public class CordovaWebView extends WebView {
     /*
      * onKeyDown
      */
-
     @Override
     public boolean onKeyDown(int keyCode, KeyEvent event)
     {
@@ -696,11 +695,12 @@ public class CordovaWebView extends WebView {
             }
             else
             {
-                //Do some other stuff!
+                return super.onKeyDown(keyCode, event);
             }
         }
-        return false;
+        return super.onKeyDown(keyCode, event);
     }
+    
 
     @Override
     public boolean onKeyUp(int keyCode, KeyEvent event)
@@ -740,6 +740,7 @@ public class CordovaWebView extends WebView {
         else if(keyUpCodes.contains(keyCode))
         {
             //What the hell should this do?
+            return super.onKeyUp(keyCode, event);
         }
 
 
@@ -747,6 +748,7 @@ public class CordovaWebView extends WebView {
         return false;
     }
 
+    
     public void bindButton(boolean override)
     {
         this.bound = override;


Mime
View raw message