incubator-callback-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From deedu...@apache.org
Subject js commit: [CB-762] Change BlackBerry plugin from Contact to Contacts.
Date Mon, 14 May 2012 16:20:58 GMT
Updated Branches:
  refs/heads/master 229f582b8 -> 81f0bacf5


[CB-762] Change BlackBerry plugin from Contact to Contacts.

The BlackBerry override of the common Contacts API expects the associated native plugin to
be named "Contact" in plugins.xml.This differs from the common cordova-js expectation of "Contacts".This
bug fix will change the BlackBerry implementation to match
common.

Existing Cordova BlackBerry projects will need updated to accountfor this change. Modify the
plugins.xml file of the existingproject to change the following line:

from:
<plugin name="Contact" value="org.apache.cordova.pim.Contact"/>

to:
<plugin name="Contacts" value="org.apache.cordova.pim.Contact"/>


Project: http://git-wip-us.apache.org/repos/asf/incubator-cordova-js/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-cordova-js/commit/81f0bacf
Tree: http://git-wip-us.apache.org/repos/asf/incubator-cordova-js/tree/81f0bacf
Diff: http://git-wip-us.apache.org/repos/asf/incubator-cordova-js/diff/81f0bacf

Branch: refs/heads/master
Commit: 81f0bacf5048625842fcee5cf9e1471771d1e78b
Parents: 229f582
Author: Drew Walters <deedubbu@gmail.com>
Authored: Mon May 14 11:20:18 2012 -0500
Committer: Drew Walters <deedubbu@gmail.com>
Committed: Mon May 14 11:20:18 2012 -0500

----------------------------------------------------------------------
 lib/blackberry/plugin/blackberry/Contact.js |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-cordova-js/blob/81f0bacf/lib/blackberry/plugin/blackberry/Contact.js
----------------------------------------------------------------------
diff --git a/lib/blackberry/plugin/blackberry/Contact.js b/lib/blackberry/plugin/blackberry/Contact.js
index d053c6d..0b5f4ef 100644
--- a/lib/blackberry/plugin/blackberry/Contact.js
+++ b/lib/blackberry/plugin/blackberry/Contact.js
@@ -288,7 +288,7 @@ var saveToDevice = function(contact) {
             // fail
             function(e) {
                 console.log('Contact.setPicture failed:' + e);
-            }, "Contact", "setPicture", [ bbContact.uid, photo.type,
+            }, "Contacts", "setPicture", [ bbContact.uid, photo.type,
                     photo.value ]);
             break;
         }


Mime
View raw message