incubator-callback-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shaz...@apache.org
Subject [1/2] ios commit: Fixed CB-501 - orientationchange event is not being fired in 1.6.0
Date Fri, 13 Apr 2012 14:09:39 GMT
Updated Branches:
  refs/heads/1.6.1 e4355f115 -> 9d63d9b9a


Fixed CB-501 - orientationchange event is not being fired in 1.6.0


Project: http://git-wip-us.apache.org/repos/asf/incubator-cordova-ios/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-cordova-ios/commit/9d63d9b9
Tree: http://git-wip-us.apache.org/repos/asf/incubator-cordova-ios/tree/9d63d9b9
Diff: http://git-wip-us.apache.org/repos/asf/incubator-cordova-ios/diff/9d63d9b9

Branch: refs/heads/1.6.1
Commit: 9d63d9b9a205d28c63d9ed2c9abe142328a514af
Parents: 0db555b
Author: Shazron Abdullah <shazron@apache.org>
Authored: Fri Apr 13 07:07:58 2012 -0700
Committer: Shazron Abdullah <shazron@apache.org>
Committed: Fri Apr 13 07:07:58 2012 -0700

----------------------------------------------------------------------
 CordovaLib/Classes/CDVViewController.m |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-cordova-ios/blob/9d63d9b9/CordovaLib/Classes/CDVViewController.m
----------------------------------------------------------------------
diff --git a/CordovaLib/Classes/CDVViewController.m b/CordovaLib/Classes/CDVViewController.m
index 6fb34cd..95b9066 100644
--- a/CordovaLib/Classes/CDVViewController.m
+++ b/CordovaLib/Classes/CDVViewController.m
@@ -304,7 +304,7 @@
 			break;
 	}
 	// TODO: update JS references here
-	NSString* jsCallback = [NSString stringWithFormat:@"window.__defineGetter__('orientation',function(){
return %d; }); Cordova.fireEvent('orientationchange', window);",i];
+	NSString* jsCallback = [NSString stringWithFormat:@"window.__defineGetter__('orientation',function(){
return %d; }); cordova.fireEvent('orientationchange', window);",i];
 	[self.webView stringByEvaluatingJavaScriptFromString:jsCallback];    
 }
 
@@ -419,7 +419,7 @@
 	NSURL* url = [request URL];
     
     /*
-     * Execute any commands queued with Cordova.exec() on the JS side.
+     * Execute any commands queued with cordova.exec() on the JS side.
      * The part of the URL after gap:// is irrelevant.
      */
 	if ([[url scheme] isEqualToString:@"gap"]) {


Mime
View raw message