incubator-callback-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From macdo...@apache.org
Subject git commit: Reverting CB-289 changes as it breaks PhoneGap.exec
Date Wed, 28 Mar 2012 17:16:55 GMT
Updated Branches:
  refs/heads/master f5d554dde -> b7f788e26


Reverting CB-289 changes as it breaks PhoneGap.exec

The way the code was structured the cordova.exec method did not get mixed in until after the
PhoneGap object was created. If legacy plugins called PhoneGap.exec it would complain that
the object did not have this method.


Project: http://git-wip-us.apache.org/repos/asf/incubator-cordova-js/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-cordova-js/commit/b7f788e2
Tree: http://git-wip-us.apache.org/repos/asf/incubator-cordova-js/tree/b7f788e2
Diff: http://git-wip-us.apache.org/repos/asf/incubator-cordova-js/diff/b7f788e2

Branch: refs/heads/master
Commit: b7f788e26da38c3c76b6a907967f1a47fa3b2a02
Parents: f5d554d
Author: macdonst <simon.macdonald@gmail.com>
Authored: Wed Mar 28 13:15:31 2012 -0400
Committer: macdonst <simon.macdonald@gmail.com>
Committed: Wed Mar 28 13:15:34 2012 -0400

----------------------------------------------------------------------
 lib/cordova.js |   15 +--------------
 1 files changed, 1 insertions(+), 14 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-cordova-js/blob/b7f788e2/lib/cordova.js
----------------------------------------------------------------------
diff --git a/lib/cordova.js b/lib/cordova.js
index 30cae3e..ac55943 100644
--- a/lib/cordova.js
+++ b/lib/cordova.js
@@ -221,20 +221,7 @@ var cordova = {
  * TODO: remove in 2.0.
  */
 if (!window.PhoneGap) {
-    window.PhoneGap = {};
-    for (var i in cordova) {
-        if (cordova.hasOwnProperty(i)) {
-            window.PhoneGap[i] = (function(prop) {
-                return (typeof prop == 'function' ?
-                        function() {
-                            console.log("[DEPRECATION NOTICE] window.PhoneGap will be removed
in version 2.0.");
-                            prop.apply(cordova, arguments);
-                        } : 
-                        prop
-                       );
-            })(cordova[i]);
-        }
-    }
+    window.PhoneGap = cordova;
 }
 
 /**


Mime
View raw message