incubator-callback-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bows...@apache.org
Subject android commit: Fixing a bug with File Upload on Android where Chunked mode isn't used by default
Date Tue, 20 Mar 2012 18:25:31 GMT
Updated Branches:
  refs/heads/master 7e70d7623 -> bbf10e3ba


Fixing a bug with File Upload on Android where Chunked mode isn't used by default


Project: http://git-wip-us.apache.org/repos/asf/incubator-cordova-android/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-cordova-android/commit/bbf10e3b
Tree: http://git-wip-us.apache.org/repos/asf/incubator-cordova-android/tree/bbf10e3b
Diff: http://git-wip-us.apache.org/repos/asf/incubator-cordova-android/diff/bbf10e3b

Branch: refs/heads/master
Commit: bbf10e3baa39977cdb8c8d4a680c431a50da7cff
Parents: 7e70d76
Author: Joe Bowser <bowserj@apache.org>
Authored: Tue Mar 20 11:25:17 2012 -0700
Committer: Joe Bowser <bowserj@apache.org>
Committed: Tue Mar 20 11:25:17 2012 -0700

----------------------------------------------------------------------
 framework/src/org/apache/cordova/FileTransfer.java |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-cordova-android/blob/bbf10e3b/framework/src/org/apache/cordova/FileTransfer.java
----------------------------------------------------------------------
diff --git a/framework/src/org/apache/cordova/FileTransfer.java b/framework/src/org/apache/cordova/FileTransfer.java
index 56bce56..649d3a8 100644
--- a/framework/src/org/apache/cordova/FileTransfer.java
+++ b/framework/src/org/apache/cordova/FileTransfer.java
@@ -94,7 +94,7 @@ public class FileTransfer extends Plugin {
                 mimeType = getArgument(args, 4, "image/jpeg");
                 JSONObject params = args.optJSONObject(5);
                 boolean trustEveryone = args.optBoolean(6);
-                boolean chunkedMode = args.optBoolean(7);
+                boolean chunkedMode = args.optBoolean(7) || args.isNull(7); //Always use
chunked mode unless set to false as per API
                 FileUploadResult r = upload(source, target, fileKey, fileName, mimeType,
params, trustEveryone, chunkedMode);
                 Log.d(LOG_TAG, "****** About to return a result from upload");
                 return new PluginResult(PluginResult.Status.OK, r.toJSONObject());


Mime
View raw message