incubator-callback-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From deedu...@apache.org
Subject git commit: Minor cleanup of messages and comments.
Date Wed, 22 Feb 2012 13:37:44 GMT
Updated Branches:
  refs/heads/master 87ff0c839 -> e642ab6fe


Minor cleanup of messages and comments.


Project: http://git-wip-us.apache.org/repos/asf/incubator-cordova-js/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-cordova-js/commit/e642ab6f
Tree: http://git-wip-us.apache.org/repos/asf/incubator-cordova-js/tree/e642ab6f
Diff: http://git-wip-us.apache.org/repos/asf/incubator-cordova-js/diff/e642ab6f

Branch: refs/heads/master
Commit: e642ab6fe1df13581650e258af822238c22c36b8
Parents: 87ff0c8
Author: Drew Walters <deedubbu@gmail.com>
Authored: Wed Feb 22 07:37:08 2012 -0600
Committer: Drew Walters <deedubbu@gmail.com>
Committed: Wed Feb 22 07:37:08 2012 -0600

----------------------------------------------------------------------
 lib/builder.js                   |    2 +-
 lib/exec/blackberry.js           |    6 +++---
 lib/plugin/blackberry/manager.js |    2 --
 3 files changed, 4 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-cordova-js/blob/e642ab6f/lib/builder.js
----------------------------------------------------------------------
diff --git a/lib/builder.js b/lib/builder.js
index ecc1be2..c933baf 100644
--- a/lib/builder.js
+++ b/lib/builder.js
@@ -12,7 +12,7 @@ function include(parent, objects, clobber) {
           var result = obj.path ? require(obj.path) : {};
 
           if (clobber) {
-              // Set the value if it doesn't exist or if an override is specified.
+              // Clobber if it doesn't exist or if an override is specified.
               if (typeof parent[key] === 'undefined' || typeof obj.path !== 'undefined')
{
                   parent[key] = result;
               }

http://git-wip-us.apache.org/repos/asf/incubator-cordova-js/blob/e642ab6f/lib/exec/blackberry.js
----------------------------------------------------------------------
diff --git a/lib/exec/blackberry.js b/lib/exec/blackberry.js
index 223f043..a5fb81f 100644
--- a/lib/exec/blackberry.js
+++ b/lib/exec/blackberry.js
@@ -28,7 +28,7 @@ module.exports = function(success, fail, service, action, args) {
                     success(v.message);
                 }
                 catch (e) {
-                    console.log("Error in success callback: "+callbackId+" = "+e);
+                    console.log("Error in success callback: "+ service + "." + action + "
= "+e);
                 }
 
             }
@@ -37,7 +37,7 @@ module.exports = function(success, fail, service, action, args) {
 
         } else {
             // If error, then display error
-            console.log("Error: Status="+v.status+" Message="+v.message);
+            console.log("Error: " + service + "." + action + " Status="+v.status+" Message="+v.message);
 
             // If there is a fail callback, then call it now with returned value
             if (fail) {
@@ -45,7 +45,7 @@ module.exports = function(success, fail, service, action, args) {
                     fail(v.message);
                 }
                 catch (e) {
-                    console.log("Error in error callback: "+callbackId+" = "+e);
+                    console.log("Error in error callback: " + service + "." + action + "
= "+e);
                 }
             }
             return null;

http://git-wip-us.apache.org/repos/asf/incubator-cordova-js/blob/e642ab6f/lib/plugin/blackberry/manager.js
----------------------------------------------------------------------
diff --git a/lib/plugin/blackberry/manager.js b/lib/plugin/blackberry/manager.js
index ebdd346..ef353bb 100644
--- a/lib/plugin/blackberry/manager.js
+++ b/lib/plugin/blackberry/manager.js
@@ -38,8 +38,6 @@ function _exec(win, fail, clazz, action, args) {
                     delete Cordova.callbacks[callbackId];
                 }
             } else {
-                console.log("Error: Status=" + evalResult.status + " Message=" + evalResult.message);
-
                 // If there is a fail callback, then call it now with returned evalResultalue
                 if (fail) {
 


Mime
View raw message