incubator-bval-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mben...@apache.org
Subject svn commit: r1002820 - in /incubator/bval/sandbox/lang3-work: bval-core/src/main/java/org/apache/bval/ bval-core/src/main/java/org/apache/bval/model/ bval-jsr303/src/main/java/org/apache/bval/jsr303/ bval-jsr303/src/main/java/org/apache/bval/jsr303/xml...
Date Wed, 29 Sep 2010 19:30:26 GMT
Author: mbenson
Date: Wed Sep 29 19:30:26 2010
New Revision: 1002820

URL: http://svn.apache.org/viewvc?rev=1002820&view=rev
Log:
merge 1002497 changes from trunk

Modified:
    incubator/bval/sandbox/lang3-work/bval-core/src/main/java/org/apache/bval/BeanValidationContext.java
  (contents, props changed)
    incubator/bval/sandbox/lang3-work/bval-core/src/main/java/org/apache/bval/model/MetaProperty.java
  (contents, props changed)
    incubator/bval/sandbox/lang3-work/bval-jsr303/src/main/java/org/apache/bval/jsr303/AppendValidationToBuilder.java
  (contents, props changed)
    incubator/bval/sandbox/lang3-work/bval-jsr303/src/main/java/org/apache/bval/jsr303/ConstraintValidation.java
  (contents, props changed)
    incubator/bval/sandbox/lang3-work/bval-jsr303/src/main/java/org/apache/bval/jsr303/ConstraintValidationListener.java
  (contents, props changed)
    incubator/bval/sandbox/lang3-work/bval-jsr303/src/main/java/org/apache/bval/jsr303/xml/ValidationMappingParser.java
  (contents, props changed)
    incubator/bval/sandbox/lang3-work/bval-jsr303d/src/main/java/org/apache/bval/jsr303/dynamic/DynamicMetaGraphManagerImpl.java
    incubator/bval/sandbox/lang3-work/bval-jsr303d/src/main/java/org/apache/bval/jsr303/dynamic/DynamicModel.java
    incubator/bval/sandbox/lang3-work/bval-xstream/   (props changed)
    incubator/bval/sandbox/lang3-work/bval-xstream/src/main/java/org/apache/bval/routines/NOPValidation.java
    incubator/bval/sandbox/lang3-work/bval-xstream/src/main/java/org/apache/bval/routines/Reasons.java

Modified: incubator/bval/sandbox/lang3-work/bval-core/src/main/java/org/apache/bval/BeanValidationContext.java
URL: http://svn.apache.org/viewvc/incubator/bval/sandbox/lang3-work/bval-core/src/main/java/org/apache/bval/BeanValidationContext.java?rev=1002820&r1=1002819&r2=1002820&view=diff
==============================================================================
--- incubator/bval/sandbox/lang3-work/bval-core/src/main/java/org/apache/bval/BeanValidationContext.java
(original)
+++ incubator/bval/sandbox/lang3-work/bval-core/src/main/java/org/apache/bval/BeanValidationContext.java
Wed Sep 29 19:30:26 2010
@@ -16,11 +16,7 @@
  */
 package org.apache.bval;
 
-import org.apache.bval.model.FeaturesCapable;
-import org.apache.bval.model.MetaBean;
-import org.apache.bval.model.MetaProperty;
-import org.apache.bval.model.ValidationContext;
-import org.apache.bval.model.ValidationListener;
+import org.apache.bval.model.*;
 import org.apache.bval.util.AccessStrategy;
 import org.apache.bval.util.PropertyAccess;
 
@@ -300,10 +296,6 @@ public class BeanValidationContext<T ext
      * {@inheritDoc}
      */
     public void moveDown(MetaProperty prop, AccessStrategy access) {
-        // make the MetaProperty available in case its MetaBean's dynamic
-        // calculation may take the state of the ValidationContext into account;
-        // far-fetched, I know ;)
-        setMetaProperty(prop);
         setBean(getPropertyValue(access), prop.getMetaBean());
     }
 

Propchange: incubator/bval/sandbox/lang3-work/bval-core/src/main/java/org/apache/bval/BeanValidationContext.java
------------------------------------------------------------------------------
--- svn:mergeinfo (added)
+++ svn:mergeinfo Wed Sep 29 19:30:26 2010
@@ -0,0 +1 @@
+/incubator/bval/trunk/bval-core/src/main/java/org/apache/bval/BeanValidationContext.java:992143,992401,992406,992412,992510,992648,993404-993438,996236,996240,997154,1002445,1002497

Modified: incubator/bval/sandbox/lang3-work/bval-core/src/main/java/org/apache/bval/model/MetaProperty.java
URL: http://svn.apache.org/viewvc/incubator/bval/sandbox/lang3-work/bval-core/src/main/java/org/apache/bval/model/MetaProperty.java?rev=1002820&r1=1002819&r2=1002820&view=diff
==============================================================================
--- incubator/bval/sandbox/lang3-work/bval-core/src/main/java/org/apache/bval/model/MetaProperty.java
(original)
+++ incubator/bval/sandbox/lang3-work/bval-core/src/main/java/org/apache/bval/model/MetaProperty.java
Wed Sep 29 19:30:26 2010
@@ -71,8 +71,7 @@ public class MetaProperty extends Featur
      * Set the metabean that owns this property (usually called by MetaBean.putProperty())
      * @param parentMetaBean
      */
-    //TODO could this be made package-private?
-    public void setParentMetaBean(MetaBean parentMetaBean) {
+    void setParentMetaBean(MetaBean parentMetaBean) {
         this.parentMetaBean = parentMetaBean;
     }
 

Propchange: incubator/bval/sandbox/lang3-work/bval-core/src/main/java/org/apache/bval/model/MetaProperty.java
------------------------------------------------------------------------------
--- svn:mergeinfo (added)
+++ svn:mergeinfo Wed Sep 29 19:30:26 2010
@@ -0,0 +1 @@
+/incubator/bval/trunk/bval-core/src/main/java/org/apache/bval/model/MetaProperty.java:992143,992401,992406,992412,992510,992648,993404-993438,996236,996240,997154,1002445,1002497

Modified: incubator/bval/sandbox/lang3-work/bval-jsr303/src/main/java/org/apache/bval/jsr303/AppendValidationToBuilder.java
URL: http://svn.apache.org/viewvc/incubator/bval/sandbox/lang3-work/bval-jsr303/src/main/java/org/apache/bval/jsr303/AppendValidationToBuilder.java?rev=1002820&r1=1002819&r2=1002820&view=diff
==============================================================================
--- incubator/bval/sandbox/lang3-work/bval-jsr303/src/main/java/org/apache/bval/jsr303/AppendValidationToBuilder.java
(original)
+++ incubator/bval/sandbox/lang3-work/bval-jsr303/src/main/java/org/apache/bval/jsr303/AppendValidationToBuilder.java
Wed Sep 29 19:30:26 2010
@@ -55,8 +55,10 @@ public class AppendValidationToBuilder e
         // annotation, so it has to be substituted with a new proxy.
         T originalAnnot = validation.getAnnotation();
         AnnotationProxyBuilder<T> apb = new AnnotationProxyBuilder<T>(originalAnnot);
-        apb.putValue("groups", inheritedGroups.toArray(new Class[inheritedGroups.size()]));
-        apb.putValue("payload", inheritedPayload.toArray(new Class[inheritedPayload.size()]));
+        apb.putValue(ConstraintAnnotationAttributes.GROUPS.getAttributeName(),
+            inheritedGroups.toArray(new Class[inheritedGroups.size()]));
+        apb.putValue(ConstraintAnnotationAttributes.PAYLOAD.getAttributeName(),
+            inheritedPayload.toArray(new Class[inheritedPayload.size()]));
         T newAnnot = apb.createAnnotation();
         validation.setAnnotation(newAnnot);
     }

Propchange: incubator/bval/sandbox/lang3-work/bval-jsr303/src/main/java/org/apache/bval/jsr303/AppendValidationToBuilder.java
------------------------------------------------------------------------------
--- svn:mergeinfo (added)
+++ svn:mergeinfo Wed Sep 29 19:30:26 2010
@@ -0,0 +1 @@
+/incubator/bval/trunk/bval-jsr303/src/main/java/org/apache/bval/jsr303/AppendValidationToBuilder.java:992330-992353,992401,992406,992412,992510,992648,993404-993438,996236,996240,997154,1002445,1002497

Modified: incubator/bval/sandbox/lang3-work/bval-jsr303/src/main/java/org/apache/bval/jsr303/ConstraintValidation.java
URL: http://svn.apache.org/viewvc/incubator/bval/sandbox/lang3-work/bval-jsr303/src/main/java/org/apache/bval/jsr303/ConstraintValidation.java?rev=1002820&r1=1002819&r2=1002820&view=diff
==============================================================================
--- incubator/bval/sandbox/lang3-work/bval-jsr303/src/main/java/org/apache/bval/jsr303/ConstraintValidation.java
(original)
+++ incubator/bval/sandbox/lang3-work/bval-jsr303/src/main/java/org/apache/bval/jsr303/ConstraintValidation.java
Wed Sep 29 19:30:26 2010
@@ -30,7 +30,6 @@ import javax.validation.ConstraintValida
 import javax.validation.Payload;
 import javax.validation.ValidationException;
 import javax.validation.metadata.ConstraintDescriptor;
-
 import java.io.Serializable;
 import java.lang.annotation.Annotation;
 import java.util.*;
@@ -40,8 +39,6 @@ import java.util.*;
  * this instance is immutable!<br/>
  */
 public class ConstraintValidation<T extends Annotation> implements Validation, ConstraintDescriptor<T>
{
-    private static final String ANNOTATION_MESSAGE = "message";
-
     private final ConstraintValidator<T, ?> validator;
     private T annotation; // for metadata request API
     private final AccessStrategy access;
@@ -103,7 +100,7 @@ public class ConstraintValidation<T exte
      */
     void setGroups(Set<Class<?>> groups) {
         this.groups = groups;
-        this.attributes.put("groups", groups.toArray(new Class[groups.size()]));
+        ConstraintAnnotationAttributes.GROUPS.put(attributes, groups.toArray(new Class[groups.size()]));
     }
 
     /**
@@ -113,7 +110,7 @@ public class ConstraintValidation<T exte
      */
     void setPayload(Set<Class<? extends Payload>> payload) {
         this.payload = payload;
-        this.attributes.put("payload", payload.toArray(new Class[payload.size()]));
+        ConstraintAnnotationAttributes.PAYLOAD.put(attributes, payload.toArray(new Class[payload.size()]));
     }
 
     /**
@@ -190,11 +187,9 @@ public class ConstraintValidation<T exte
             }
 
             if (failed) {
-                // TODO RSt - how should the composed constraint error report
-                // look like?
+                // TODO RSt - how should the composed constraint error report look like?
                 ConstraintValidatorContextImpl jsrContext = new ConstraintValidatorContextImpl(context,
this);
-                addErrors(context, jsrContext); // add defaultErrorMessage
-                                                // only*/
+                addErrors(context, jsrContext); // add defaultErrorMessage only
                 return;
             }
         } else {
@@ -272,7 +267,7 @@ public class ConstraintValidation<T exte
      * @return String
      */
     public String getMessageTemplate() {
-        return (String) attributes.get(ANNOTATION_MESSAGE);
+        return ConstraintAnnotationAttributes.MESSAGE.get(attributes);
     }
 
     /**

Propchange: incubator/bval/sandbox/lang3-work/bval-jsr303/src/main/java/org/apache/bval/jsr303/ConstraintValidation.java
------------------------------------------------------------------------------
--- svn:mergeinfo (added)
+++ svn:mergeinfo Wed Sep 29 19:30:26 2010
@@ -0,0 +1 @@
+/incubator/bval/trunk/bval-jsr303/src/main/java/org/apache/bval/jsr303/ConstraintValidation.java:992330-992353,992401,992406,992412,992510,992648,993404-993438,996236,996240,997154,1002445,1002497

Modified: incubator/bval/sandbox/lang3-work/bval-jsr303/src/main/java/org/apache/bval/jsr303/ConstraintValidationListener.java
URL: http://svn.apache.org/viewvc/incubator/bval/sandbox/lang3-work/bval-jsr303/src/main/java/org/apache/bval/jsr303/ConstraintValidationListener.java?rev=1002820&r1=1002819&r2=1002820&view=diff
==============================================================================
--- incubator/bval/sandbox/lang3-work/bval-jsr303/src/main/java/org/apache/bval/jsr303/ConstraintValidationListener.java
(original)
+++ incubator/bval/sandbox/lang3-work/bval-jsr303/src/main/java/org/apache/bval/jsr303/ConstraintValidationListener.java
Wed Sep 29 19:30:26 2010
@@ -28,7 +28,6 @@ import javax.validation.metadata.Constra
 import java.lang.annotation.ElementType;
 import java.util.HashSet;
 import java.util.Set;
-import java.util.concurrent.atomic.AtomicInteger;
 
 /**
  * Description: JSR-303 {@link ValidationListener} implementation; provides {@link ConstraintViolation}s.<br/>
@@ -37,9 +36,8 @@ public final class ConstraintValidationL
     private final Set<ConstraintViolation<T>> constraintViolations = new HashSet<ConstraintViolation<T>>();
     private final T rootBean;
     private final Class<T> rootBeanType;
-    // TODO: Currently there is no need for atomicity here as all the validation process
-    //       is single-threaded and it's unlikely to change in the near future.
-    private final AtomicInteger compositeDepth = new AtomicInteger(0);
+    // the validation process is single-threaded and it's unlikely to change in the near
future (otherwise use AtomicInteger).
+    private int compositeDepth = 0;
     private boolean hasCompositeError;
 
     /**
@@ -72,7 +70,7 @@ public final class ConstraintValidationL
 
     private void addError(String messageTemplate, Path propPath,
                           ValidationContext<?> context) {
-        if (compositeDepth.get() > 0) {
+        if (compositeDepth > 0) {
             hasCompositeError |= true;
             return;
         }
@@ -154,7 +152,7 @@ public final class ConstraintValidationL
      * @return boolean
      */
     public boolean hasViolations() {
-        return compositeDepth.get() == 0 ? !constraintViolations.isEmpty() : hasCompositeError;

+        return compositeDepth == 0 ? !constraintViolations.isEmpty() : hasCompositeError;
     }
 
     /**
@@ -162,7 +160,7 @@ public final class ConstraintValidationL
      * @return <code>true</code> as this call caused the listener to enter report-as-single-violation
mode
      */
     public boolean beginReportAsSingle() {
-        return compositeDepth.incrementAndGet() == 1;
+        return ++compositeDepth == 1;
     }
 
     /**
@@ -170,6 +168,6 @@ public final class ConstraintValidationL
      * @return <code>true</code> as this call caused the listener to exit report-as-single-violation
mode
      */
     public boolean endReportAsSingle() {
-        return compositeDepth.decrementAndGet() == 0;
+        return --compositeDepth == 0;
     }
 }

Propchange: incubator/bval/sandbox/lang3-work/bval-jsr303/src/main/java/org/apache/bval/jsr303/ConstraintValidationListener.java
------------------------------------------------------------------------------
--- svn:mergeinfo (added)
+++ svn:mergeinfo Wed Sep 29 19:30:26 2010
@@ -0,0 +1 @@
+/incubator/bval/trunk/bval-jsr303/src/main/java/org/apache/bval/jsr303/ConstraintValidationListener.java:992330-992353,992401,992406,992412,992510,992648,993404-993438,996236,996240,997154,1002445,1002497

Modified: incubator/bval/sandbox/lang3-work/bval-jsr303/src/main/java/org/apache/bval/jsr303/xml/ValidationMappingParser.java
URL: http://svn.apache.org/viewvc/incubator/bval/sandbox/lang3-work/bval-jsr303/src/main/java/org/apache/bval/jsr303/xml/ValidationMappingParser.java?rev=1002820&r1=1002819&r2=1002820&view=diff
==============================================================================
--- incubator/bval/sandbox/lang3-work/bval-jsr303/src/main/java/org/apache/bval/jsr303/xml/ValidationMappingParser.java
(original)
+++ incubator/bval/sandbox/lang3-work/bval-jsr303/src/main/java/org/apache/bval/jsr303/xml/ValidationMappingParser.java
Wed Sep 29 19:30:26 2010
@@ -17,18 +17,15 @@
 package org.apache.bval.jsr303.xml;
 
 
-import java.io.InputStream;
-import java.io.Serializable;
-import java.lang.annotation.Annotation;
-import java.lang.reflect.Array;
-import java.lang.reflect.Field;
-import java.lang.reflect.Member;
-import java.lang.reflect.Method;
-import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.HashSet;
-import java.util.List;
-import java.util.Set;
+import org.apache.bval.jsr303.ApacheValidatorFactory;
+import org.apache.bval.jsr303.ConstraintAnnotationAttributes;
+import org.apache.bval.jsr303.util.EnumerationConverter;
+import org.apache.bval.jsr303.util.IOUtils;
+import org.apache.bval.jsr303.util.SecureActions;
+import org.apache.bval.util.FieldAccess;
+import org.apache.bval.util.MethodAccess;
+import org.apache.commons.beanutils.ConvertUtils;
+import org.apache.commons.beanutils.Converter;
 
 import javax.validation.Constraint;
 import javax.validation.ConstraintValidator;
@@ -40,15 +37,14 @@ import javax.xml.bind.JAXBException;
 import javax.xml.bind.Unmarshaller;
 import javax.xml.transform.stream.StreamSource;
 import javax.xml.validation.Schema;
-
-import org.apache.bval.jsr303.ApacheValidatorFactory;
-import org.apache.bval.jsr303.util.EnumerationConverter;
-import org.apache.bval.jsr303.util.IOUtils;
-import org.apache.bval.jsr303.util.SecureActions;
-import org.apache.bval.util.FieldAccess;
-import org.apache.bval.util.MethodAccess;
-import org.apache.commons.beanutils.ConvertUtils;
-import org.apache.commons.beanutils.Converter;
+import java.io.InputStream;
+import java.io.Serializable;
+import java.lang.annotation.Annotation;
+import java.lang.reflect.Array;
+import java.lang.reflect.Field;
+import java.lang.reflect.Member;
+import java.lang.reflect.Method;
+import java.util.*;
 
 
 /**
@@ -58,7 +54,10 @@ import org.apache.commons.beanutils.Conv
 public class ValidationMappingParser {
     //    private static final Log log = LogFactory.getLog(ValidationMappingParser.class);
     private static final String VALIDATION_MAPPING_XSD = "META-INF/validation-mapping-1.0.xsd";
-    private static final String[] RESERVED_PARAMS = {"message", "groups", "payload"};
+
+    private static final Set<ConstraintAnnotationAttributes> RESERVED_PARAMS = Collections.unmodifiableSet(EnumSet.of(
+        ConstraintAnnotationAttributes.GROUPS, ConstraintAnnotationAttributes.MESSAGE,
+        ConstraintAnnotationAttributes.PAYLOAD));
 
     private final Set<Class<?>> processedClasses;
     private final ApacheValidatorFactory factory;
@@ -178,9 +177,9 @@ public class ValidationMappingParser {
     }
 
     private void checkValidName(String name) {
-        for (String each : RESERVED_PARAMS) {
-            if (each.equals(name)) {
-                throw new ValidationException(each + " is a reserved parameter name.");
+        for (ConstraintAnnotationAttributes attr : RESERVED_PARAMS) {
+            if (attr.getAttributeName().equals(name)) {
+                throw new ValidationException(name + " is a reserved parameter name.");
             }
         }
     }

Propchange: incubator/bval/sandbox/lang3-work/bval-jsr303/src/main/java/org/apache/bval/jsr303/xml/ValidationMappingParser.java
------------------------------------------------------------------------------
--- svn:mergeinfo (added)
+++ svn:mergeinfo Wed Sep 29 19:30:26 2010
@@ -0,0 +1 @@
+/incubator/bval/trunk/bval-jsr303/src/main/java/org/apache/bval/jsr303/xml/ValidationMappingParser.java:992330-992353,992401,992406,992412,992510,992648,993404-993438,996236,996240,997154,1002445,1002497

Modified: incubator/bval/sandbox/lang3-work/bval-jsr303d/src/main/java/org/apache/bval/jsr303/dynamic/DynamicMetaGraphManagerImpl.java
URL: http://svn.apache.org/viewvc/incubator/bval/sandbox/lang3-work/bval-jsr303d/src/main/java/org/apache/bval/jsr303/dynamic/DynamicMetaGraphManagerImpl.java?rev=1002820&r1=1002819&r2=1002820&view=diff
==============================================================================
--- incubator/bval/sandbox/lang3-work/bval-jsr303d/src/main/java/org/apache/bval/jsr303/dynamic/DynamicMetaGraphManagerImpl.java
(original)
+++ incubator/bval/sandbox/lang3-work/bval-jsr303d/src/main/java/org/apache/bval/jsr303/dynamic/DynamicMetaGraphManagerImpl.java
Wed Sep 29 19:30:26 2010
@@ -339,15 +339,15 @@ final class DynamicMetaGraphManagerImpl 
                 currentValidationState.set(new DynamicValidationStateBean(null, rootMetaBean,
path));
                 result = getMetaBean(beanType);
                 if (propertyName != null) {
-                    result = ((MetaBean) result).getProperty(propertyName);
-                    if (result == null) {
+                    MetaProperty prop = ((MetaBean) result).getProperty(propertyName);
+                    if (prop == null) {
                         // build from its metabean
 
                         findType = new FindType(beanType);
                         PathNavigation.navigateAndReturn(propertyName, findType);
-                        MetaProperty prop = new MetaProperty();
+                        prop = new MetaProperty();
                         prop.setName(propertyName);
-                        prop.setParentMetaBean((MetaBean) result);
+                        ((MetaBean) result).putProperty(propertyName, prop);
                         prop.setType(findType.type);
 
                         // replace the propertyName, but I doubt it matters

Modified: incubator/bval/sandbox/lang3-work/bval-jsr303d/src/main/java/org/apache/bval/jsr303/dynamic/DynamicModel.java
URL: http://svn.apache.org/viewvc/incubator/bval/sandbox/lang3-work/bval-jsr303d/src/main/java/org/apache/bval/jsr303/dynamic/DynamicModel.java?rev=1002820&r1=1002819&r2=1002820&view=diff
==============================================================================
--- incubator/bval/sandbox/lang3-work/bval-jsr303d/src/main/java/org/apache/bval/jsr303/dynamic/DynamicModel.java
(original)
+++ incubator/bval/sandbox/lang3-work/bval-jsr303d/src/main/java/org/apache/bval/jsr303/dynamic/DynamicModel.java
Wed Sep 29 19:30:26 2010
@@ -104,7 +104,6 @@ public class DynamicModel {
         if (result == null) {
             result = new MetaProperty();
             result.setName(name);
-            result.setParentMetaBean(metaBean);
             result.setType(new PropertyAccess(metaBean.getBeanClass(), name).getJavaType());
             MetaBean propertyBean = new MetaBean();
             propertyBean.setBeanClass(result.getTypeClass());

Propchange: incubator/bval/sandbox/lang3-work/bval-xstream/
------------------------------------------------------------------------------
--- svn:mergeinfo (added)
+++ svn:mergeinfo Wed Sep 29 19:30:26 2010
@@ -0,0 +1 @@
+/incubator/bval/trunk/bval-xstream:992143,992401,992406,992412,992510,992648,993404-993438,996236,996240,997154,1002445,1002497

Modified: incubator/bval/sandbox/lang3-work/bval-xstream/src/main/java/org/apache/bval/routines/NOPValidation.java
URL: http://svn.apache.org/viewvc/incubator/bval/sandbox/lang3-work/bval-xstream/src/main/java/org/apache/bval/routines/NOPValidation.java?rev=1002820&r1=1002819&r2=1002820&view=diff
==============================================================================
--- incubator/bval/sandbox/lang3-work/bval-xstream/src/main/java/org/apache/bval/routines/NOPValidation.java
(original)
+++ incubator/bval/sandbox/lang3-work/bval-xstream/src/main/java/org/apache/bval/routines/NOPValidation.java
Wed Sep 29 19:30:26 2010
@@ -22,8 +22,6 @@ import org.apache.bval.model.ValidationL
 
 /**
  * Description: DO NOTHING VALIDATION (can be used to turn off standard validation)<br/>
- * 
- * TODO RSt - could become part of optional module, depends on proprietary XML support only
(package org.apache.bval.xml)
  */
 public class NOPValidation implements Validation {
 

Modified: incubator/bval/sandbox/lang3-work/bval-xstream/src/main/java/org/apache/bval/routines/Reasons.java
URL: http://svn.apache.org/viewvc/incubator/bval/sandbox/lang3-work/bval-xstream/src/main/java/org/apache/bval/routines/Reasons.java?rev=1002820&r1=1002819&r2=1002820&view=diff
==============================================================================
--- incubator/bval/sandbox/lang3-work/bval-xstream/src/main/java/org/apache/bval/routines/Reasons.java
(original)
+++ incubator/bval/sandbox/lang3-work/bval-xstream/src/main/java/org/apache/bval/routines/Reasons.java
Wed Sep 29 19:30:26 2010
@@ -21,8 +21,6 @@ import org.apache.bval.model.Features;
 /**
  * Description: StandardReasons for validation errors found in
  * {@link org.apache.bval.ValidationResults}<br/>
- * 
- * TODO RSt - could become part of optional module or remove this interface. it depends indirectly
on proprietary XML support only (package org.apache.bval.xml)
  */
 public interface Reasons extends Features.Property {
     // The reasons inherited from Features are VALIDATION features only.



Mime
View raw message