incubator-blur-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tim Williams <william...@gmail.com>
Subject Re: [2/3] git commit: Changing the behavior of missing attribute multi field manager to previous implied default of true.
Date Wed, 11 Feb 2015 14:33:59 GMT
On Wed, Feb 11, 2015 at 9:19 AM,  <amccurry@apache.org> wrote:
> Changing the behavior of missing attribute multi field manager to previous implied default
of true.
>
>
> Project: http://git-wip-us.apache.org/repos/asf/incubator-blur/repo
> Commit: http://git-wip-us.apache.org/repos/asf/incubator-blur/commit/c0e54e98
> Tree: http://git-wip-us.apache.org/repos/asf/incubator-blur/tree/c0e54e98
> Diff: http://git-wip-us.apache.org/repos/asf/incubator-blur/diff/c0e54e98
>
> Branch: refs/heads/master
> Commit: c0e54e9887c1facaf52516481c3c417d16c218b3
> Parents: 9714a1d
> Author: Aaron McCurry <amccurry@gmail.com>
> Authored: Wed Feb 11 08:53:20 2015 -0500
> Committer: Aaron McCurry <amccurry@gmail.com>
> Committed: Wed Feb 11 08:53:20 2015 -0500
>
> ----------------------------------------------------------------------
>  .../main/java/org/apache/blur/analysis/HdfsFieldManager.java | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/incubator-blur/blob/c0e54e98/blur-query/src/main/java/org/apache/blur/analysis/HdfsFieldManager.java
> ----------------------------------------------------------------------
> diff --git a/blur-query/src/main/java/org/apache/blur/analysis/HdfsFieldManager.java
b/blur-query/src/main/java/org/apache/blur/analysis/HdfsFieldManager.java
> index bef55b4..dac34fc 100644
> --- a/blur-query/src/main/java/org/apache/blur/analysis/HdfsFieldManager.java
> +++ b/blur-query/src/main/java/org/apache/blur/analysis/HdfsFieldManager.java
> @@ -195,7 +195,13 @@ public class HdfsFieldManager extends BaseFieldManager {
>        inputStream.close();
>        boolean fieldLessIndexing = Boolean.parseBoolean(properties.getProperty(FIELD_LESS_INDEXING));
>        boolean sortenabled = Boolean.parseBoolean(properties.getProperty(SORTENABLED));
> -      boolean multiValueField = Boolean.parseBoolean(properties.getProperty(MULTI_VALUE_FIELD));
> +      String mvfProp = properties.getProperty(MULTI_VALUE_FIELD);
> +      boolean multiValueField;
> +      if (mvfProp == null || mvfProp.trim().isEmpty()) {
> +        multiValueField = true;
> +      } else {
> +        multiValueField = Boolean.parseBoolean(mvfProp);
> +      }

It turns out this isn't enough to get pure backwards compatible
behavior since field types themselves have the check - specifically,
BaseSpatialField.  I dunno, maybe 100% backward compat isn't worth it,
but I wanted to bring it up at least...

Thanks,
--tim

Mime
View raw message