incubator-blur-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chris Rohr <rohr.ch...@gmail.com>
Subject Re: Potentially serious problem with BlurClient.getClient
Date Thu, 16 Oct 2014 19:10:03 GMT
Thank you

On Thu, Oct 16, 2014 at 2:54 PM, Aaron McCurry <amccurry@gmail.com> wrote:
> Should be fixed now.
>
> https://github.com/apache/incubator-blur/commit/63504e50badc69a27570195cec595ee46f75aeed
> https://github.com/apache/incubator-blur/commit/b2fe85ae44a07c831aa5d77a5e72efde57c7fd88
>
> On Thu, Oct 16, 2014 at 12:38 PM, Tim Williams <williamstw@gmail.com> wrote:
>
>> On Thu, Oct 16, 2014 at 12:28 PM, Andrew <andrew.va@gmail.com> wrote:
>> > Tim,
>> > Thanks for the clarification. We'll definitely change the console to
>> re-use
>> > one client.
>> > My concern is that this could be a breaking change. If a user was
>> > re-requesting the client like we were, this small point release update
>> > could break their system.
>> > I don't know that we need to roll back the change, but we need to be sure
>> > to clearly communicate this in the release notes.
>>
>> Definitely, I think it's a bug only in master that can just be patched
>> prior to the release to get it back to the previous behavior.  We
>> should add some notes about expected usage, but the patch should make
>> it about as efficient as it ever was to get a new one each time.
>>
>> --tim
>>

Mime
View raw message